Giter VIP home page Giter VIP logo

open-meteo-rs's People

Contributors

angelodlfrtr avatar rparrett avatar tulku avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

open-meteo-rs's Issues

Forecast / Air Quality code refractoring

PR #5 introduced air-quality endpoint.

Some code is shared between the forecast and air-quality modules :

  • extract_times, unix_time_to_naive_datetime methods.
  • CellSelection, CurrentResult, ForecastResultHourly, ForecastResultItem structs.

Methods could be moved to an utils module and structs to a more generic form that could be shared with forecast and air-quality modules.

Testing

The code is not yet tested.

Tests should be added :

  • Call endpoints, check responses types / values / params.
  • TryFrom TryInto`, ... implementations.
  • Utils methods
  • ...

Time Zone parameter is not passed correctly.

It seems that time_zone is sent, but timezone is required. See docs.

This is manifesting for me as this error

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: InvalidResponseStatus { status_code: 400, text: "{\"reason\":\"Timezone is required\",\"error\":true}" }', src/main.rs:21:43

When requesting daily data with slightly modified example code:

let mut opts = open_meteo_rs::forecast::Options::default();
opts.location = open_meteo_rs::Location {
    lat: 48.864716,
    lng: 2.349014,
};
opts.current_weather = Some(true);
opts.daily = vec![
    "temperature_2m_max".to_string(),
    "temperature_2m_min".to_string(),
    "precipitation_probability_max".to_string(),
    "windspeed_10m_max".to_string(),
];

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.