Re-implement and fix event music about ac-music-extension HOT 3 OPEN

Thanks for that! The main reason why it was temporarily removed was because not all games had corresponding event music, and it was causing errors because of this.

We'll definitely uncomment that part and fix up everything eventually, we just have to find every event song for every game and do a few touch-ups here and there.

from ac-music-extension.

This might be the next big feature of the extension! Let me know if I can help with this in anyway.

PD: I believe this should be marked as a new feature instead of an enhacement.

from ac-music-extension.

Glad to see this brought up again!
I've already written the code for detecting events and running their respective music files, some time ago, which should be functional.

Once all the event's song files are added, it should suffice to uncomment the block of code at line 60 in /scripts/background/AudioManager.js, which, if there is an event ongoing, changes the song's filename to the name of the current event. This lies inside the method playHourSong() at line 52.

To add events and their filenames, see the getEvent() function at line 58 of /scripts/background/TimeKeeper.js

An option should also be added to disable/enable all event music, adding a "eventMusicEnabled" boolean to the if-statement at line 60 of AudioManager.js would do the trick.

from ac-music-extension.