Giter VIP home page Giter VIP logo

ac-music-extension's People

Contributors

bordenjardine avatar buzz627 avatar gammagames avatar jdotcarver avatar jordigarcl avatar julian-mjk avatar kowsen avatar maxschaefer avatar mn6 avatar paladique avatar pikadude avatar syzztem avatar xane123 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ac-music-extension's Issues

Someone is travelling to your town!

Hey @JdotCarver,

I've been giving this a lot of thought; I'd actually enjoy taking on some responsibility to fix this extension up if you'd want to swap ownership.

Is that something you're still looking at?

Re-implement and fix event music

Currently in the process of finding all events with custom music. Once complete, music dumps, play times and loop need to be found and implemented.

Animal Crossing Events:

  • Cheery
  • Halloween
  • New Year Countdown
  • New Years Day

City Folk/Wild World Events:

New Leaf Events:

  • Christmas
  • Easter
  • Festivale (Carnival)
  • Fireworks
  • Halloween
  • Harvest Festival
  • New Year Countdown
  • New Years Day (Gantan)

The 5pm loop is off...

The loop returns a little early when it reaches the two notes on the piano part ;/, just a minor pet peeve. Love this extension tho :)

incorrect file name

the file /img/icon_32.png is named incorrectly, it should be icon_32_kk.png.

Tab Audio Behavior is inconsistent in Opera

Most of the time, the Tab Audio Behavior does not react when audio starts or stops playing in a tab. instead reacting when the settings tab is selected. Sometimes it may react as intended, however it is uncommon.

Add ambience sounds

Some people have requested a toggleable feature that plays ambient noises (like rain sounds, crickets/cicada's chirping, etc.) along with the extension's music. Would be a nice addition I believe.

Add Firefox support

Should be pretty easy to do, I managed to get an older build somewhat working.

[request] Use opus over vorbis for audio encoding

I chose a random audio file from the google drive folder:

new-leaf-raining/10am.ogg

and re-encoded it using ffmpeg:

ffmpeg -i 10am.ogg -acodec opus -vn -f ogg out.ogg

and found that the filesize was reduced by 67%. Either the original files were
encoded with excessively high bitrates or opus is just that much better. I
didn't hear any difference in quality either.

Redo audio formats and dumps for songs

Some songs, such as the ACNL music is stored at a crazy 499kbps, despite the fact that the original soundtrack from the games files only exists at 299kbps. This is substantially larger than required and is also insane for any audio format. Songs need to be reduced to 320kbps maximum to reduce file size. Some songs for other games are also of lower quality than what's available and also contain audible artefacts of their lower quality.

Progress

  • Animal Crossing (Sunny):
  • ✔71.0mb (320kb/s)
  • ✔audible quality is good
  • ❌songs have been slightly slowed down
  • Animal Crossing (Snowing):
  • ✔68.9mb (320kb/s)
  • ✔audible quality is good
  • ❌songs have been slightly slowed down
  • Animal Crossing (Cheery):
  • ✔68.0mb (320kb/s)
  • ✔audible quality is good
  • ❌songs have been slightly slowed down
  • Animal Crossing (Events)
  • City Folk/Wild World (Sunny):
  • ✔56.2mb (208kb/s)
  • ⚠some songs have soft static and some have audible buzzing, there don't appear to be any high quality rips without these issues. doesn't appear to be incredibly noticeable unless you have the song at a deafening volume, and it's only a handful of songs, so i think it should be fine
  • City Folk/Wild World (Snowing):
  • ✔59.0mb (208kb/s)
  • ⚠some songs have soft static and some have audible buzzing, there don't appear to be any high quality rips without these issues. doesn't appear to be incredibly noticeable unless you have the song at a deafening volume, and it's only a handful of songs, so i think it should be fine
  • City Folk/Wild World (Raining):
  • ✔55.4mb (208kb/s)
  • ⚠some songs have soft static and some have audible buzzing, there don't appear to be any high quality rips without these issues. doesn't appear to be incredibly noticeable unless you have the song at a deafening volume, and it's only a handful of songs, so i think it should be fine
  • City Folk/Wild World (Events)
  • New Leaf (Sunny):
  • ✔71.4mb (300kb/s)
  • ✔audible quality is good
  • New Leaf (Raining):
  • ✔62.9mb (300kb/s)
  • ✔audible quality is good
  • New Leaf (Snowing):
  • ✔70.1mb (300kb/s)
  • ✔audible quality is now good
  • New Leaf (Events)
  • KK (Live)
  • ⚠291mb (192/320/kb/s) (CF/WW songs are 192kb/s as a higher version isn't available, NL songs are about 100kb/s since I can't locate any higher quality dumps.)
  • ✔audible quality is good
  • ✔contains all kk songs from ac, ww/cf and nl (91 songs, hence the large size)
  • KK (Aircheck)
  • ⚠173mb (208/320kb/s) (CW/WW songs are 208kb/s as a higher version isn't available, NL songs are about 100kb/s since I can't locate any higher quality dumps.)
  • ✔audible quality is good
  • ✔contains all kk songs from ac, ww/cf and nl (91 songs, hence the large size)

Rework live weather inputs

At the moment, the text accompanying the live weather inputs in options are quite misleading, saying it needs a country code to function when it's actually looking for an ISO code. And also, the link from the zip codes text leads to a pretty shoddy website, a better one would be https://worldpostalcode.com/

Add ? note support to town tune

In the AC games, there's support for a ? note, which is just a randomly selected note. This allows the note to variate each time the town tune plays.

Add proxy authentication or option for downloading file packs

For people trying to use the extension on corporate/VPN devices, this extension doesn't allow proxy auth, so music can't be fetched.

Two potential options are allowing there to be an auto-proxy detection url setting where you add the url for your proxy pac.

The other option would be to allow an 'offline' mode where you can download the tracks, although I think this would be much more difficult.

I know this is a pretty big ask and will probably never get done, and if I had more time I'd just write it myself, but alas, figured it was worth an ask since I wish I could use this on VPN/private proxy networks.

Option to rotate through soundtracks

i.e. if it's 4:00pm play the 4:00 song from Animal Crossing, then Wild World, then New Leaf, then loop.

It would keep it from getting quite so repetitive.

Allow volume of town tune to be edited

Right now, the town tune player ignores the volume of the music and there is no way to even change the volume. It currently plays at 100% volume and can be quite annoying.

Update Step Volume

See PR here. Closed as it was very old and new version is currently under development.

Changing the step interval allows for more precise volume adjustments.

I just want to point out

wild world and Let's go the City are missing both their snow and rain versions. I've got the tunes on my flash drive if you need them.

Option to cycle between games

Add an option to cycle between games after every loop so you're not listening to the exact same 1-2 minute loop for a full hour.

Extension Size

Another thread had me examining the size of the music files them self and weighing the quality vs. size options of managing an extension such as this. The first thought I had was why not take advantage of Google's REST API to dynamically access the files from the google drive folder instead of having every user download them to local storage.

Something as simple as a request resource in a URI should be very simple to implement. There are pros and cons to this.

Pros:

  • File size of the extension would drop dramatically, to a few Kbs most likely.
  • Files would have a centralized source outside the repository (git is for text anyway)
  • Files could be of a higher bitrate/quality

Cons:

  • I'm not sure how many people use this extension. Multiple people asking for a file at the same time from the source may cause load times if there isn't enough bandwidth.
  • HTML5 Audio objects have a preload setting for buffering the files from remote sources, but I'm not sure of the performance.
  • The music would not play without an internet connection.

This is a short list but either way I believe it is a worthwhile pursuit. It would involve a few steps:

  1. Remove all local file system resources
  2. Code their retrieval into URIs using the Google Drive.
  3. Adjustments for best load time/quality of sound:
    a. Find highest lossless versions of music
    b. Tweak with encodings/bitrates
    c. test load times/buffering into the HTML5 audio objects
  4. profit???

In the end if the REST api calls prove to be too slow, the music will still have quality adjustments and size reduction.

Thoughts @JdotCarver @KyleChu ???

No longer playing in Opera for me getting error.

I get this error when trying to play in Opera Version:66.0.3515.72

Info

Uncaught TypeError: Cannot read property 'setActionHandler' of undefined

Context

_generated_background_page.html

// Make notifyListeners public to allow for easier notification sending.
window.notify = notifyListeners;

if (DEBUG_FLAG) {
	window.setTime = function (hour, playTownTune) {
		notifyListeners("hourMusic", [hour, options.weather, options.music, playTownTune]);
	};
}

}

On/off toggle via keyboard shortcut

A little icon in the side doesn't work well with my flow. It would be great to have keyboard shortcut which would turn on and off, or better yet pause, the music.

Volume Slider apparently not working

PLEASE NOTE THAT THE VOLUME SLIDER DOES WORK.
EVERY CHANGE THAT YOU MAKE WITHIN THE OPTIONS PAGE CAN ONLY BE APPLIED AFTER SAVING AND RESTARTING THE EXTENSION.

Just make your changes, hit save, click twice the extension's icon and voilà!

Please stop reporting this. ^^'

Is this extension still maintained?

Hello! I recently came up with an idea to make some sort of program that would play the associated Animal Crossing music tracks in real-time. Turns out that already exists (right here), but I've noticed that development and maintaining has slowed or almost stopped, and that the extension on the Chrome Store hasn't been updated in a few years. I also noticed that this extension was in potential need of developers or something along those lines. I've made a Chrome Extension and also a Firefox extension in the past and have pretty good experience with JS, HTML and CSS (my profile is a bad example, I don't have a lot of open-source projects) and I'd be down to lend a hand with this whenever possible.

Extension not working in Opera since 4.0 update

As the title says, ever since the 4.0 update, the extension has stopped working on Opera despite the fact that it used worked fine before.
I have tried different settings, reinstalling the extension, and toggling off the tracker blocker and ad blocker but nothing seems to help. I'm on Windows 10 and I'm not using a VPN.

Allow which K.K. songs to play

A function that allows the user to select which K.K. Slider songs that are allowed to play would be nice. A lot of people aren't a fan of every single on of his songs, which is fair since each one is so diverse.

Make town tune sound effects more accurate to the sounds in the games

Currently the sound effects in the town tune editor and when it actually plays aren't quite the same to the ones from the real games. Using dumps or rips from the files we could make them more accurate to most likely Animal Crossing New Leaf as it's the most modern and crisper sounding one.

Add town-tune save states

I think a nice addition to the town-tune editor, without making it too complicated, would be a few save slots where you could save & retrieve tunes you've made, say 3 of them for simplicity's sake.

It is a feature I know I would personally enjoy, and given the sheer amount of town-tunes shared & googled on the internet and especially YouTube, I believe this is a feature more people than just me would be interested in.

Options menu does not work

When I try to open up the options menu, a blank screen pops up:
image

I am on Google Chrome Stable Version 50.0.2661.102 m (64-bit).

Thank you for putting in your time and effort into developing and releasing this extension.

EDIT: I have found a workaround for accesing the options menu.

https://gfycat.com/GiddyHelplessFlamingo

By manually typing in the extension's address, followed by options.html, I am able to access it.
.

Are you still here ? (I need help)

When I upload your new version on google extensions I'm facing an issue.
Moreover I'm a total beginner ....
Here is the problem :
Failed to load ressource: net: :ERR_FILE_NOT_FOUND 11am.ogg.1
Uncaught (in promise) DOMException _generated_background_page.html1

Enable the user to either choose Live K.K. songs or Aircheck songs

I've tried to fiddle around with the files to realize that the best way I can see to do this would be by:

  • adding a checkbox underneath the 3 K.K. options saying "Play K.K. Aircheck songs instead"
  • which would replace the value of currentMusic to kkac in:
// get path of a song file
    function setAudioUrl(file) {
        if (checkKK()) {
            currentMusic = 'kk';
        }
        else {
            currentMusic = options.music;
            file += 'm';
        }
        audio.src = '../' + currentMusic + '/' + file + '.ogg';

The kkac music is in the Resources category on the readme

Is this still being worked on?

The github version is v3.4 but the one in the web store is still v3. So will the extension eventually be updated or has development completely stopped on this project?

(I know this isn't the right place for questions like this. It's just that I don't know where to ask this instead)

Dynamic Music according to local Weather

I have just received a mail from a user that wanted to help out. Hopefully we will be able to use this to implement the feature. Here is what he had to say:

"
It should be simple enough to use the OpenWeatherMap API (http://openweathermap.org/current) to periodically get the local weather for a city of the user's choice and determine whether to play sunny/rainy/snowy music. Granted the user can do it manually, but I think this would be a cute feature if it doesn't take much time to implement.

tl;dr of above link --

call http://api.openweathermap.org/data/2.5/weather?q=CityName&mode=xml 
and check precipitation.mode: "no" = sunny, "rain" = rainy, "snow" = snowy.

"

and then you'd need to make it change the value of option.music in:

// get path of a song file
function setAudioUrl(file) {
    if (checkKK()) {
        currentMusic = 'kk';
    }
    else {
        currentMusic = options.music;
        file += 'm';
    }
    audio.src = '../' + currentMusic + '/' + file + '.ogg';
}

to switch weather music type and BAM.

Music copyright

Out of curiosity, under which license it the music from animal crossing? I hear it often in youtube videos and streams used as background music.
Just curious.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.