animeshbaranawal / book48511 Goto Github PK

Running se modernize-spelling results in a number of changes which should be accepted. Make sure to commit these with a message starting with "[Editorial]".

You seem to have gone backwards and forwards a few times with the spelling of Brahma. I think "Bramha" is surely a mistake on Burton's part and could be corrected in an "[Editorial]" commit. Do you have a view on this? Is there a reason you reverted to "Bramha"?

Note that there are problems with a number of your existing commits which are marked as "[Editorial]", some of which shouldn't be. I'll address these in a separate issue.

If you run typogrify again it makes a total of five changes, all of which I think you should allow. Mostly these are instances of commas preceding dashes.

For example:

R. W. Lavinia has not known the trial that Bella has known

should be:

<abbr epub:type="z3998:given-name">R. W.</abbr> Lavinia has not known the trial that Bella has known

and similarly throughout.

In the preface, we have:

which Apuleius calls ‘Milesius sermo,’

Is the quoted phrase Latin? If so, I think it needs to be italicised not quoted and given the appropriate language tag.

Regarding commit 7d5d844 .

You don't need to fiddle with the word count in content.opf. Indeed, you should leave it as the placeholder WORD_COUNT, similarly with READING_EASE. These are set with the se prepare-release function, but that's something which Alex does just before release.

I'm still seeing issues when I run lint. Let's look at these one by one:

s-060 | Manual Review | endnotes.xhtml | Italics on name that requires quotes. This is just a stylistic decision on our part, which should probably be covered in the manual, but as yet I don't think it is (I'll fix that). Song titles, short stories and essays don't get italics, but are quoted, eg "Essay on Vikram". You could if you like leave a span containing the semantic information, eg:

“<span epub:type="se:name.publication.essay">Essay on Vikram</span>”

I don't think you should set the default size of the paragraphs to be x-small. The whole thing looks tiny now, see the screenshot below from Apple Books. Even the first line is a bit small. Maybe use sizes specified in ems?

In instances like these in chapters 1 and 7:

“<i>ughs</i>” and “<i>poohs</i>,”

I would suggest it would be best to drop either the italics or the quotes, rather than using both, regardless of what the page scans show. I would probably drop the italics.

This is a big issue, I'm afraid.

A number of your commits marked as [Editorial] don't appear as though they are Editorial changes by our standards, rather they are corrections or adjustments to formatting. We reserve the [Editorial] flag for commits which change the text away from what is shown by the page scans (eg what happens during the se modernize-spelling process). Changes to formatting, the correction of typos, etc, don't fall into that category. We only want to mark changes with [Editorial] if they represent an editorial decision to deviate from the page scans.

Also, there are many commits which seem to combine an editorial commit with other actions, which isn't acceptable. However, because most of these seem to be to do with changing or reverting the spelling of Brahma and the change from O to O', which were ultimately reverted, I think it would be OK to just remove the [Editorial] marking from those messages.

However, before you take any action on this issue, we'll need to ask Alex @acabal to comment on whether he agrees this is a reasonable approach.

For your and Alex's reference, these are the commits which in my view should have the [Editorial] removed using an interactive rebase:

eda01bc: Finalise changes to conclusion [Editorial] Revert changes to (Bramha,Brahma)
40e25af: Finalise changes to chapter 11 [Editorial] revert changes like (O,O')
271bff7: Finalise changes to chapter 10 [Editorial] Revert changes like (O,O') and (Brahma,Bramha)
143f498: Finalise changes to chapter 8 [Editorial] Revert changes to spelling (Brahma, Bramha).
bbddd6f: Finalised changes to chapter 6. [Editorial] Reverted changes on spellings (Brahma, Bramha).
626d9de: Finalised changes to introduction [Editorial] Revert spelling changes (Brahma,Bramha)
e69e745: Typogrify changes to Conclusion [Editorial] Bramha -> Brahma
9df726a: Typogrify chanes to chapter 10. [Editorial] Bramha -> Brahma, O -> O'
d96e845: Typogrify changes to Chapter8 [Editorial] Murdev -> Muldev, Bramha->Brahma

In the last one, it looks as though Murdev was a typo for Muldev, so it didn't need to be [Editorial].

The following early commits seem to be just normal proof-reading/formatting, and should definitely have [Editorial] removed.

9486d20: [Editorial] Pass through Introduction completed. Some typogrify changes to Preface.
36c51fe: [Editorial] Pass through Preface completed.

You just need to run se typogrify again, check what typogrify has done (it's usually correct) and commit the changes.

Lint throws up a number of problems, but the following should fix most of them.

One major issue: it's not our practice to include the "Sir" as part of the author's name (see, for example, our books by Sir Arthur Conan Doyle). You would need to change this in several places in your repository. The best way to deal with this (and the lint issues to do with mismatches with our template files) would be:

1. Make sure you're running the latest version of our toolset

2. In a new folder, re-run se create-draft with a command-line like:

se create-draft -a="Richard Francis Burton" -t="Vikram and the Vampire"

3. From this new (dummy) folder, copy these files into your current repository folder, overwriting your current ones:

LICENSE.md
images/cover.svg
images/titlepage.svg
src/epub/css/se.css
src/epub/images/logo.svg
src/epub/text/uncopyright.xhtml

4. Re-run se build-images .

5. Manually edit src/epub/text/titlepage.xhtml, colophon.xhtml and imprint to remove the 'Sir' as appropriate.

6. Do the same carefully in content.opf, both in SE urls and in the meta data of the author's name. You might note that even Wikipedia's canonical link for this person doesn't use the Sir, though the version you have is redirected to it.

7. While you're in content.opf, add the roles to the author which lint complains are missing.

I think that's all for the moment.

Our normal CSS will do what is required with indentation. You should remove p.noindent from local.css and in all instances where it has been used.

Also, it's not our style to put the first word or word of a chapter in small-caps as you've done with <b> tags. You should remove those too.

You'll need to change this to remove the sir :

`href="https://standardebooks.org/ebooks/sir-richard-francis-burton"'

Your own name should be treated in the same way as those of the transcribers by placing it within a semanticated <b> tag unless you want to hyperlink it somewhere, in which case it should of course be in an <a> tag.