Edit the installation doc so that the git clone section asks the user to git clone https://github.com/systers/vms
This should improve clarity.

Search features have a volunteer link but it currently does not give flexibility to enter hours, i.e., it creates a SAT entry with 1 hr as default.

Task 13 from the task list:

Add functionality so that a shift cannot be deleted if at least one volunteer is signed up for it or has logged hours for it.

After updating Django I can run

python manage.py runserver [::]:8000

but not

python manage.py test

I get an error:

django.db.utils.ProgrammingError: relation "auth_user" does not exist

@tapasweni-pathak @jayesh92 do you have this problem with Django 1.8? Can you run tests?

@vubo I don't see a time picker in create shift? There are start and end time fields there.

Can we add the timepicker wherever we are using the time related fields?

Currently, the validation process is implemented but instead of widget a placeholder text is provided.

http://vms.readthedocs.org/en/latest/Installation%20Guide/#download-systers-ubuntu-virtual-machine

This section of the doc should be updated to reflect current status. Also, all links should direct to a Systers/repo and should not direct to an individual's repo.

This issue is assigned to Vanda @veniemi1

It would be helpful to have the ability to locally render documentation. There's a lot of great content in the documentation that has already been done. Python and Django projects often use Sphinx to build documentation and Read The Docs to render the documentation.

While testing I found admin user can create a job with same details twice inside one event. Also, the same applies for shift inside job. Shouldn't it be unique ?

On volunteer’s page, All Assigned SAT’s tab does not contain the feature to log WLT, User has to go to Log WLT entry to select a SAT from dropdown and then log hours. This can be enhance to same page.

@Nerdylicious when you have time, could you explain please the difference between "Upcoming Shifts" and "Shift Hours".

• Why after a volunteer makes "log hours" for a shift, she/he does not see this shift in the "Upcoming Shifts" list?
• If a volunteer does not make "log hours" for a shift, what does that mean?

@jayesh92 perhaps you could also help with this issue?

Thank you!

Add parens to existing print statement to make Python 3 compliant.

In creation of shift, currently we provide to add Event & Job through forms, and if the corresponding event of job selected is not equal to event selected, an error is raised. However, it should be like the user should be given to select event and then on the basis of event selected job fields should be displayed using AJAX

@vubo Do we have one check which restricts the user to not create an event which is ended already, post dated event?

I'm writing test to check if admin can access a volunteer view or not, but the build fails. The test can be viewed at jayesh92/vms@45a3993#diff-0df96ededa86aa47a9dbdb5655a6908aR177 . I've created an admin account and tried to browse url /shift/view_volunteer_shifts/1 which is meant to be a volunteer view. I get a 500 error instead of 403. The code for view being tested is https://github.com/systers/vms/blob/develop/vms/shift/views.py#L285 . The problem here is at line 290, since it's an admin account it's volunteer field will be None and we can't access its 'id'. It would be better if we first check if its not a volunteer and then raise a 403 or better we create a decorator to check admin and use this for all volunteer views.

@Nerdylicious @willingc @vubo

@rosariorobinson offered to run the test VMS project and to collect the feedbacks and reviews of those users who will test the project.

@willingc @tapasweni-pathak maybe you know a suitable platform for the collection of the users feedbacks? Thank you!

Django 1.8 is a long term supported release (LTS). It would be useful to upgrade the code bases to Django 1.8 since it will have longer term support than the current version used. https://www.djangoproject.com/download/ for details.

pyc files are unneeded. The .gitignore file should be set to ignore pyc files.

• Volunteer model view allows - as a valid character. https://github.com/systers/vms/blob/develop/vms/volunteer/models.py#L11
• Volunteer form does NOT allow - as a valid character. https://github.com/systers/vms/blob/develop/vms/volunteer/forms.py#L12
• As a result, during a test I can register a volunteer with a - but cannot enter a - in the form for Volunteer Search functionality
• Test fails

@Nerdylicious @vubo @willingc

• while writing tests, I've found that unique parameter used is username and not email
• I'm able to register more than one volunteers with same email but different usernames.

Should it be like this ?
@willingc @vubo

A install psycopg link in the installation.md file redirects to an empty page instead of the documenation.

Display a simple notification to the user that they have registered successfully. Use Bootstrap Lumen Indicators: http://bootswatch.com/lumen/

Similar to issue #41, let's refactor the event unit tests:

• Import statements
• Docstring
• File - spaces vs. tabs
• DRY - don't repeat yourself - a reasonable goal which may or may not apply to these tests but important to recognize when developing

While testing the shift hours view, I can enter end time less than start time. This should not be allowed and a corresponding check should be added. Also, I think same is the case with all time fields.

Many Django projects use the coverage project to measure test coverage and display the resulting percentage in the GitHub repo. Projects also frequently use Travis for continuous integration to build, test, and report on the project. Travis integration with GitHub provides a nice widget to display current build status.

Task 15 from the task list:

Need to add location (such as country, city and state) that the event/job/shift is being held at. Country, city and state fields should only need to belong to the Event, Job or Shift models. I would ask Rose, as an administrator of VMS, where she would like to specify the location. Does she want to specify location when creating Events? Or when creating Jobs? Or is it possible that shifts can take place at multiple locations, so she should specify the location at the Shift level?

@rosariorobinson would you answer these questions please? Should I program the location specification at the Event, Job, or Shift? Thank you!

Configure access for administrators and volunteers (return HTTP_Forbidden code for for each administrator functionality that a volunteer tries to access and for each volunteer functionality that the administrator tries to access).

For administrators only

• Manage Volunteer Shifts: /shift/volunteer_search/
• Manage Volunteer Shifts: /shift/manage_volunteer_shifts/
• Manage Volunteer Shifts: /shift/add_hours_manager/
• Manage Volunteer Shifts: /shift/edit_hours_manager/
• Manage Volunteer Shifts: /shift/clear_hours_manager/
• Manage Volunteer Shifts: /shift/cancel/
• Manage Volunteer Shifts: /administrator/report/

Create, edit and delete events, jobs, shifts:

• Settings: /event/create/
• Settings: /event/edit/
• Settings: /event/delete/
• Settings: /job/create/
• Settings: /job/edit/
• Settings: /job/delete/
• Settings: /shift/create/
• Settings: /shift/delete/
• Settings: /organization/create/
• Settings: /organization/edit/
• Settings: /organization/delete/

Since administrators can be volunteers, they should have access to all pages of volunteers.

I have created reporting based on several parameters, however we need to integrate all reporting functionality into one tab i.e., display a form with date, event etc and then generate report based on the intersection of all fields selected.

The README.md file of a project's repository is the world's outside view to the project. Examples of well done and not so well done examples can be found be looking at other projects.

Since the vms project will be actively worked on this summer and there are docs now at read the docs and a number of other places, let's make it easier for new contributors, current contributors, mentors, and future users to find the documentation that they are looking for. One of my favorite resources on documentation is Write the Docs. Here's a link to their tips on what makes a good README.md file: http://docs.writethedocs.org/writing/beginners-guide-to-docs/#readme

Use the template at the end of the Write the Docs section and the Systers/Portal README files for guidance. Some helpful things to include:

• Brief Project description (2 or 3 sentences)
• Features (link to the existing requirements documents) Also make a note that the project is under active development
• Installation instructions (for now just link to the Read the Docs for VMS)
• Contributing (links to source code, issue tracker)
• GSOC 2015 (links to key docs - timeline, blog)
• GSOC 2014 (links to key docs)
• License (refer to the license file)

@vubo I just saw yesterday's recording. I have one question, are we validating city and countries, when the user is entering the data in create event e.t.c?

If not, I feel its good to do that. There are packages that can achieve that for us.

@vubo Do we have unique ids associated with every new event. If not, I feel its good to add it.

If there are two events having same details, name and same start and end time, are we able to distinguish between the two in our code?

Task 17 from the task list:

@rosariorobinson should be able administrators to manage (add/edit/delete) the shift hours for volunteers?

Let's refactor the following:

• Import statements - I would like to be conservative on importing the libraries needed for testing. Avoid * imports. Do not import libraries that are not used (I don't think the auth import is needed currently; let's not add until needed). General style: python standard library imports - blank line - django imports - blank line - application specific imports.
• Docstring - One line describing individual unit tests
• File - spaces vs. tabs - double check that all tabs are converted to spaces before check in (there is usually an editor setting for this
• DRY - don't repeat yourself - a reasonable goal which may or may not apply to these tests but important to recognize when developing

It's possible that it could confuse newcomers whether the commands should be entered in the VM window or the local machine's terminal. Provide an example to help clarify for the user.

Refactor the delete_organization function so that a function that checks if the organization is empty (organization_empty) could be called within the delete function.

#28 (comment)

• This view is to register a new volunteer into the system
• When I was testing this view, It gives 500 Server Error. After struggling a lot to find if the reason is due to wait for page load or any other selenium issue, I found that the problem is in the view itself
• Problem is at https://github.com/systers/vms/blob/develop/vms/registration/views.py#L67 . organization_list is output of list of organization from services.py .
• If it's empty (like in my case), view redirects to organization/add_organizations.html . There is no such template corresponding to this. There is a create template.
• There is no need to check for organization_list. Since, we already have a field for other-organization if it's not in the dropdown. We can use the logic for inserting this organization first and then get the id of this newly inserted org and use it for the foreign_key relationship of newly created volunteer object.

@Nerdylicious @willingc @vubo

Issue 11 from the task list:

When clicking on date in the administrator and volunteer reports, a datepicker (https://jqueryui.com/datepicker/) pops out. Add a datepicker to the templates where they are missing. For example, add the datepicker when specifying dates when creating events and jobs.

The jQuery UI datepicker code has already been imported, so it should be as easy as adding "id="datepicker" to the code, like this:

<div class="form-group">
    <label class="col-md-2 control-label">Date</label>
    <div class="col-md-8">
        <input class="form-control" type="text" name="date" id="datepicker" value="{% if form.date.value %}{{ form.date.value }}{% endif %}">
    </div>
</div>

For administrator:

• Create event
• Create job
• Create shift

It would be helpful to have a short style guide for the vms project.

I am assigning this to myself to pair with Vanda on creating this document.

@willingc How about showing a small map to the user, in features like create event, where we have something as 'location'?

@vubo What do you think about it? There are packages that we can easily use to implement this feature.

• Add missing unit tests in organization/tests.py
• Add missing unit tests in event/tests.py
• Add missing unit tests in job/tests.py
• Add missing unit tests in shift/tests.py
• Add missing unit tests in volunteer/tests.py

Here is sample of the GHC committee volunteer application from last year. The GHC Committee would be a volunteer job.

Add a calender / date range opportunity for the event search.

Volunteer must be able to find all the events for specific dates.

Here are the improvements I would add to the VMS installation guide. I can put these in when I get back from training at the end of July if need be.

Vms/Installation Guide.md:

Clone Project:
*git clone https://github.com/systers/vms.git
*Make sure you are in the top level directory of where you want the cloned files to end up.
*Check the contents of the destination directory to ensure that clone took place.
Download Systers Ubuntu Virtual Machine
*Replace content of Vagrantfile with file from @willingc in issue #49.
Using Vagrant
*Type everything in the command prompt rather than the virtual machine. Leave the virtual machine window open though.
*Use Linux commands in command prompt.
Install python-psycopg2 module
*Stay in the VM while doing this.

• Setup PostgreSQL
  *x.x is version number. I used version 9.3.
  *Before entering python manage.py syncdb command go into the file /vms/vms/vms/settings.py and under DATABASES change ‘myuser’ to ‘vmsadmin’ and ‘mypassword’ to ‘0xdeadbeef’

`# Database

DATABASES = {
'default': {
'ENGINE' : 'django.db.backends.postgresql_psycopg2', #your database engine
'NAME' : 'vms', #the name of your database
'USER' : 'vmsadmin', #your DBMS username
'PASSWORD' : '0xdeadbeef', #your DBMS password
'HOST' : 'localhost',
}
}`

@willingc Here are my changes for the Installation Guide. Thank you again for all your help these last three weeks!

Allow volunteer or administrator to choose how to display the time: 12 hour or 24 hour format.

Task 20 from the task list:

@rosariorobinson would you like email notifications to be sent to volunteers when a shift they have signed up for is coming up?

Progressively, go through vms app folder and refactor files. Things to look at comments, import statements, spacing after a keyword (there are several instances for an extra space in the code.

Files:

• settings.py
• urls.py
• wsgi.py

Related to this comment #28 (comment) I tried to run the code through a pep8 locally. I have used autopep8 and got an error:

Traceback (most recent call last):
  File "V:\Python27\lib\runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "V:\Python27\lib\runpy.py", line 72, in _run_code
    exec code in run_globals
  File "V:\Python27\Scripts\autopep8.exe\__main__.py", line 5, in <module>
  File "V:\Python27\lib\site-packages\autopep8.py", line 119, in <module>
    DEFAULT_CONFIG = os.path.expanduser(r'~\.pep8')
  File "V:\Python27\lib\ntpath.py", line 310, in expanduser
    return userhome + path[i:]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 9: ordinal
not in range(128)

If an admin has assigned a shift from 0900hrs to 1500hrs, volunteer is able to log hours in a shift from 1800hrs to 1830hrs also. Should this be allowed ?
Tests pass with this use case

Issue 12 from the task list:

There are some views where the user has to enter a time (such as when they are logging their volunteer hours). Make it easier for the user to add times by finding a timepicker tool and using it in the project to add times.

Here is an example of a possible tool to use: http://jdewit.github.io/bootstrap-timepicker/

Feel free to experiment with different ones.

Task 14 from the task list:

When creating events, you need to specify a date range for that event. What if an event is only a day long?