Comments (4)
Hi Karthik,
Thanks for pointing out. I had never tried those characters. I had a look at the code. I could successfully add the long R^I vowels, whose mappings were absent.
So pitR^In is now rendered as पित्ॠ्न्.
However, the correct maatra is not being generated. In the Unicode chart, these characters are not continguous with the other vowels - which seems to be cause of the error. See the function 'DevanagariCharacter' - where these mappings are computed. I tried a few things, but didn't work out. Do you have an idea of this part of the code.
from indic_nlp_library.
So, I located the required changes to support maatra for these long R^I vowels. Also added support for R^l and R^L vowels and their maatras. The changes are currently on the branch bug_4. Please check and let me know if things are working properly.
from indic_nlp_library.
Looks perfect; I had tried a dirty fix by putting the matra for the vowel (worked!) -- but this seems good. Will test it in the evening and let you know.
from indic_nlp_library.
Works perfect. I ran it on some large ITX files and I can confirm that nothing else has been broken by the fixes too :) It's quite a neat hack. Thanks!
from indic_nlp_library.
Related Issues (20)
- Text Normalisation HOT 4
- Script conversion of danda and double danda HOT 1
- Placement of Anuswara HOT 2
- AttributeError: 'NoneType' object has no attribute 'iloc' HOT 3
- sentence_split missing all_script_phonetic_data.csv
- installation of latest version not working correctly HOT 3
- Is translate function available? HOT 1
- Schwa deletion in romanization for Hindi
- Make a kaggle dataset to use this library in the inferece of a kaggle competetion HOT 1
- Inappropriate Hindi English Transliteration HOT 1
- Text Normalisation using Indic NLP library not working HOT 2
- ImportError: No module named indicnlp.common
- BrahmiNet is down HOT 2
- Unable to do transliteration using BrahmiNet REST API HOT 1
- AttributeError: 'NoneType' object has no attribute 'iloc' HOT 1
- Broken "Getting Started" links HOT 2
- Making indic-nlp-library available via Conda Forge HOT 4
- Bad sentence splitting performance on flores 200 hindi language HOT 1
- Add more NLP models list
- Sentence tokenizer creating issue while splitting for end of the sentence.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from indic_nlp_library.