ans-group / basebot Goto Github PK

Describe the bug
In basebot-core, the models extracted from middlewares are passed into the storage engine as an array of objects. But the storage engine expects a single object.

In the basebot-core init function:

  const logger = getSingleModule(config.logger)
  const channels = getAllModules(config.channels)
  const rawMiddleware = getAllModules(config.middleware)
  const models = getAllModels(rawMiddleware)
  const storage = getSingleModule(config.storage)({ logger, models: models })
  const middleware = rawMiddleware.map(mw => mw({ storage, logger }))
  const info = logger('core', 'info')
  const { server, app } = Server({ logger })
  const controllers = startChannels({ channels, storage, logger, server, app })

Should be:

  const logger = getSingleModule(config.logger)
  const channels = getAllModules(config.channels)
  const rawMiddleware = getAllModules(config.middleware)
  const models = getAllModels(rawMiddleware)
  const storage = getSingleModule(config.storage)({ logger, models: Object.assign(...models) })
  const middleware = rawMiddleware.map(mw => mw({ storage, logger }))
  const info = logger('core', 'info')
  const { server, app } = Server({ logger })
  const controllers = startChannels({ channels, storage, logger, server, app })

Note the merging of the array of objects into one object with Object.assign(...models)

Source: https://github.com/ans-group/basebot/blob/master/packages/basebot-core/src/index.js#L11

This was observed when using the azure table storage engine

Describe the bug
The URL https://basebot.ans.tools is no longer accessible

To Reproduce
Steps to reproduce the behavior:

1. Go to your browser of choice
2. Navigate to https://basebot.ans.tools

Hmmm… can't reach this pagebasebot.ans.tools’s server IP address could not be found.
ERR_NAME_NOT_RESOLVED

Expected behavior
Basebot documentation site loads

Desktop (please complete the following information):

• OS: OSX 10.15.6
• Browser Edge
• Version 84.0.522.63

Smartphone (please complete the following information):

• Device: iPhone 11 Pro Maz
• OS: IOS 14.0 (beta4)
• Browser: Safari

At this line https://github.com/ans-group/basebot/blob/master/packages/basebot-core/src/applySkills.js#L45

The bot statically registers a default response. This should be configurable - either to disable it entirely, or change the message

Describe the bug

The console is polluted with "RESPONSE IS ...." making it difficult to see other log info.

Offending lines:
https://github.com/ans-group/basebot/blob/master/packages/basebot-controller-web/index.js#L258

Describe the bug
Frontend app is blank due to incorrect script path in basebot generator template

To Reproduce

1. npm i -g basebot-cli
2. basebot create
3. follow instructions from the docs but skip NLP service
4. npm run dev
5. visit localhost:3000 and notice blank screen

Expected behavior
Web page shows bot frontend app

Screenshots

Desktop (please complete the following information):

• OS: Windows 10 20H2 (19042.572)
• Browser: Edge
• Version: 86.0.622.69

Smartphone (please complete the following information):

Additional context

Describe the bug
Missing import for uuid module in azure table storage module

This line makes reference to uuid but the import is missing.
https://github.com/ans-group/basebot/blob/master/packages/basebot-storage-azuretables/index.js#L73