anthonya1999 / goodnight Goto Github PK

The application doesn'r work properly with the Reduce white point option enabled

As of commit 25aec5dxx, the temperature isn't working right in my 6s+ on 9.2. Using manual mode, the temperature initially displays correctly at 6500K. If I adjust it and try to get it back to 6500K it doesn't show correctly. The 6500K value has a pinkish tint to it. As soon as I move the slider even slightly the screen immediately get too much pink/orange to it. Also, all of the other values have more orange to them than they should. Sometimes when I disable the manual setting the screen doesn't revert back to the true 6500K value. I have to flip the toggle a few times and slide the slider around and finally it reverts back to the true 6500K value.

Is that a bug or feature :D

I alway have to close it myelf..

Geolocation and consequently sunrise and sunset times are not used

Not an issue... but interesting to see Apple getting into the game at last...
http://www.apple.com/ios/preview/

iOS 9.1, iPhone 6s. Compiled with Xcode 7.1

iOS reverts back to a default temperature in a random manner (i.e. browsing AppStore, loading Facebook or any other third-party apps). Going back to GoodNight app fixes it for another few hours.

Happens both in manual and automatic mode.

A few widget observations. Using "Gamma On" doesn't seem to play nicely with using the color changing time setting. If have Color Changing (Time) enable, enabling Gamma On changes it to 3400K overriding the daytime setting (5000K) I have specified. Disabling Gamma On/Off, returns the screen to 6500K instead of the original 5000K but leaves the Color Changing (Time) button enabled. The screen doesn't revert to the correct temperature until I disable/reenable the time based setting.

Also, if I turn Gamma On in the widget, then enable Darkroom On in the widget, the screen becomes a greyscale of sorts (sometimes). If I enable Darkroom On, then enable Gamma On, gamma comes on but the darkroom toggle doesn't revert to darkroom on. If I enable Gamma On and then disable it, then enable Darkroom on, the screen also goes to greyscale. This is on an iPhone 6.

This is more of a question than an issue. I have the temperature controls enable--specifically using location option. If I'm on the temperature screen and adjust the temperature setting for any of the modes (day/night/bedtime), the screen updates to reflect that temperature (which makes sense). I would assume this would be temporary to show what that temperature looks like, but it never reverts back to the current set temperature until I close the app and reopen it or disable/enable the location-based setting. Is this how it's supposed be. I would like to see it show that temperature for maybe 5 seconds and then revert back to the current temperature based on either time or location.

Did not occur on the version I got last week. And it still says version 1.1 for some reason in Xcode.

When I activate GoodNight and put the temperature at 6500K, the screen is still noticeably tinted orange. Putting the temperature at 6500K when GoodNight is activated should look the same as when GoodNight is not activated at all, but it does not. Moreover, once I enable GoodNight, disabling it only makes the screen return to the '6500K' temperature that is still tinted orange, not the regular temperature without GoodNight. I have to restart my phone every time I wish to return the temperature to normal.

I am on an iPhone 5, iOS 9.1, non-jailbroken. If you need anymore information, feel free to ask.

Fresh install. ios 9.2. You enable temperature and as soon as you try to enable "Automatic Color Changing" the app just closes (goes back to home).

Thank you for all of the changes you guys have been making. The response speed and turn-around time has been amazing. I love using this app so please keep up the good work building it out and fixing bugs.

I do have a lingering issue on my 6S+ running 9.2 that I don't have on my 5C running 9.2. I installed Goodnight on both to test and here's what I found. It works great on my 5C; however, I'm having an issue with the temperature resetting to the correct 6500K value when I disable Goodnight on my 6S+. If my screen is at 6500K and I enable manual mode, the screen stays at 6500K until I move the slider. Once I move the slider to any position and then try to return it to 6500K, the 6500K value has a slight orangish hue to it which tells me it's not returning to the correct value. The issue does not fix itself even if I disable manual mode. I have to restart my phone for it to return to the correct 6500K value. It appears to stay somewhere around 5500K if I compare it to my 5C with Goodnight enabled. The other issue this causes is that 5000K on my 6S+ is noticeably darker than 5000K on my 5C.

Any thoughts on this issue?

This is more of a request than an issue but didn't know where to put it.

First off, I love this app and appreciate all of the hard work and effort you guys are putting into it. I wanted to know if it's possible to add functionality to independently set the temperature per mode. I normally keep my daytime screen temperature at 5000K. In the evening, I'd like automatically change to 3400K at a specific time. Then a bit later I'd like it to change to night mode at a desired time. Right now I have to do some of these manually.

Does that make sense?

Awesome app,
Is it possible to add in-app updates likes f.lux implemented when they shared their app ?

Thanks

When trying to move the temperature slider, it crashes the app. It also crashes when trying to turn the location option on and turning on the other switches. The app started crashing after updating to beta 2. It works fine on the iPad Pro on beta 2 though.

In the Temperature settings view, when you move the temperature slider, the text in the table section header/footer updates with the current value of the slider.

However, there is currently a bug that, when the slider is updating rapidly, the new text is simply rendered in-place on top of the old text without clearing the old text.

After a half-second or so, the old text is finally cleared away, and only the most recent value is rendered. So this isn't a permanent glitch; it only happens when the temperature value is updating rapidly. Unfortunately, that makes the text illegible when actively changing the temperature slider, which makes it hard to set the exact value you want.

Tapping the rows "turn on color changing at" and "turn off color changing at" do not do anything.

ping @mariokorte

I'm using the latest build as four hours ago. Two questions. (1) If I enable darkroom mode, previously it was red on black, now it looks almost exactly like turning on the "invert colors" option on the accessibility menu. Is that the intent? (2) If I enable darkroom mode, then select "reset brightness", the darkroom mode toggle is disabled but the screen doesn't change back. I have to reenable the toggle and then disable it again to revert to normal.

Every time GoodNight changes the color temperature the screen turns on briefly.

Greetings,

I have Goodnight set to change color to 2700 at 5 PM and change back at 7 AM. That works great. Now I'm trying to enable low temperature night mode from 9:30 PM yo 6:30 AM. When I flip the switch to enabled, everything is OK, but when I hit the back arrow to leave the temperature settings screen, and then go back to the temperature settings, low temperature night mode is disabled again. There doesn't seem to be anything I can do to get it to stay in the enabled position.

iPhone 6 plus, iOS 9.1, background refresh on, notifications off, locations while using.

Thanks.

Whenever I move the slider to adjust temperature, in GammaController.m:130, an assertion failure happens:

2016-01-08 08:09:07.564 GoodNight[317:79220] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid parameter not satisfying: file != NULL'

Seems like fopen fails?

Installed goodnight app (latest from source code) but do nothing.
Changed/Reseted every setting and still nothing

I cannot seem to complete a build for the project without getting the error: Embedded binary's bundle identifier is not prefixed with the parent app's bundle identifier.

is this tweak compatible with iOS 7? if not could you please make it so? i would be willing to help in order to make this possible

Hi all,
This is a fantastic piece of work, and I want to thank everyone who contributed!

I have one small feature request: it seems that currently the widget occupies way more screen real estate than it needs. The text is carried over to two lines instead of one (it may fit on one for larger-screen devices). Also, the text is possibly not needed, since the button names are completely self-explanatory. I prefer my widgets as compact as possible, and this is no exception :) I tried to modify it myself, but have so little iOS development experience that even something as simple as attempting to remove the text caused a huge visual mess.

Thanks again everyone,
Eugene

I was playing around with the new modes functionality and I don't think it's working right (or I don't understand how it's suppose to work). If I enable the temperature, it defaults to 3400K (my night setting) -- no other toggles are on. It appears that the night toggle is the master setting for when the temperature setting is enabled. If I turn it off it goes back to 6500K. I tried enabling the time settings only and they work great for night mode and bedtime mode but day mode (the time prior to switching to night mode) still defaults to 6500K instead of my day setting of 5000K.

Here's what I'm trying to do: set my default temp to 5000K (which activates when I enable the switch to change to night mode at a specific time or simply by enabling the temperature switch), enable night mode based on time to activate at 7 pm at a temp of 3400K, and enable bedtime mode based on time to activate at 11 pm at a temp of 2000.

This is probably an issue on my end, but I'm trying to build GoodNight without any changes and I'm getting the following errors: https://gist.github.com/pH14/4a234d79ddd4ea9fa487

This is with Xcode 7 and Xcode 7-beta, any thoughts?

Could you add support for the 4th generation Apple TV?

On iphone 6s ios 9.1

After enabling low brightness setting disable works only on the first try.

Other attempts the switch flips to disable but the screen stays dimmed (enabled), must hit reset brightness together with enabling the switch to get the display brightness back to normal. Happens both in app and also 3d touch.

The same goes for color setting, while temperature enable disable works fine in app and 3D touch

Hi

I managed to download Goodnight after reading through the different guides. There was a problem where I had to change the name on the Bundle Identifier on BOTH Goodnight and Goodnight Widget. Now I got the app on my iPhone 6s, but there is another problem. whenever I change the temperature, brightness or color, I get a lot of strange colors I KNOW shouldn't be there.

When I tried to get screenshots of the weird behaviour, I noticed the pictures was completely normal, they didn't get affected, just the iPhone/screen.

Here is a few pictures taken from another phone:

Please help me, I really want the app to work properly. I use an Iphone 6s 64gb Space gray not jailbroken

Iphone 6s Plus, as soon as you click the toogle the app crashes. It works fine with 3d touch.

Shame because the schedule would be very useful.

I just traveled to the east coast. While I can't confirm it, it didn't seem that GoodNight adjusted either the location-based fading or the time-based. Fading didn't seem to correspond to the sunset in my location; GoodNight was still doing its thing, but on central time, even though the phone auto-adjusted to east coast time.
Can anyone confirm whether GoodNight correctly reacts to time zone changes?

Even though it is enabled, it does not change at 7pm & 7am.

The application doesn't stop working at 7AM. I've been using it fro two days now and the screen is still yellow at 7AM. Haven't noticed though when it changes hue back to normal though. I am using iOS 9.0.2 on an iPhone7,2 device.

https://justgetflux.com/sideload/

unlike f.lux GoodNight does not have an automatic setting to enable color changing at sunset and disable it at sunrise.

Went through entire process in Xcode, says that build was successful, then says running GoodNight on my iPhone, but when app opens it is only a black screen. What did I do wrong?

I have auto change temperature activated (night mode as well) and in the morning after the app has reverted, there's still an orange-ish hue to the color of the device. If I restart it changes back to its correct color. My iPad Air 2 doesn't seem to do that.

Hi,

the app force closes if I want to activate one of the 4 Adjustments.
It was working fine the last days. I have updated the source and now it force closes. I discarded all changes in Xcode and deleted the app and used git pull, but it still crashes :/

Can I get the old version (maybe 2 days ago)?

Thanks in advance!

Are there any special build instructions? I'm having issues building the project on Xcode 7.0.0 beta and 7.1.1. Tried adding the notification center framework to the Build Phases to see if that would resolve it.

https://gist.github.com/codeman869/f785cbdfd70ea6b57009

So first of all, I would like to thank you, the devs of this app, all for making f.lux feature available for all of us at a better comfortability after Thomas Finch seems liek has abandoned the gamma thingy project for whatever reason I don't know.

Goodnight has been a great help to me and I like how it integrates well with background app refresh and is able to change the gamma almost immediately, and doesn't require the notification to wake screen to turn on like the sideloaded flux version 1.

SInce it's so great like that, I would like to suggest, why not make it even more like f.lux on windows. If either of you have followed the project done by Thomas, then later forked by Amangelo, he worked on a transition branch for the app, so the color will adjust gradually for 1h or 30 min beforehand to let the eye adapt better to the change of color. This I think is extremely helpful for Goodnight when changing from Night mode to bedtime mode, which is a lot of increase of orangeness there.

In application-wise, I would suggest that the iOS framework kit will just divide the gamma value evenly maybe by 10 minute block within a set timeframe of transition. So option of 1 hour transition beforehand the orangeness will adjust 6 times during the period. It will be even better if then we could choose the number of hour of transition in settings as well as transition blocks. That might runs a bit of battery there but I think it's totally worth it, for the better health.

Thank you guys for making an incredibly helpful app

Hi all,

Right now, I have no earthly idea which version/branch/build I'm running, and it doesn't seem I can find out from the app. There should probably be a branch / commit / version number or something available inside the app, yes?

Thanks!

iPhone 4s, iOS 7.1.2

GoodNight seems to work fine so far; however, although my Location Services is on, it does not appear under Location Services so that I can give access to it and enable Color Changing (Location) mode. Trying to enable this mode results in a No access to location popup. I double-checked my Bundle Identifiers and appGroupIDs, uninstalled and reinstalled the app, turned on Background App Refresh, reset Location & Privacy, and restarted my phone—still unresolved.

As is, it doesn't work on iPad Pro. Planned?

Thanks!

Just installed the latest build and as always I delete the old version before installing a new one. Followed all the steps since I know this has the new widget so there's extra things to change. Everything installed fine.

I launch the app and go to enable color changing (location) and the prompt comes up to allow location when using the app, I click allow. The color changing (location) option is still disabled so I try to turn it on again and the app crashes. I try to re-open the app and it crashes on launch. I can't open the app anymore even if I kill it from the task switcher.

Additionally, I tried uninstalling, rebooting and reinstalling GoodNight. Still does the same as I previously said.

Reverted to Dec 20th build before widget and App Groups was added and everything seems fine.

Hi, I have no problems enabling Temperature Changing - but when I press Automatic Color Changing, it just freezes, and I have to reinstall the app to get it working again.

Xcode gives the following:
2015-12-27 18:02:45.561 GoodNight[357:34548] -[MainViewController colorChangingEnabledSwitchChanged]: unrecognized selector sent to instance 0x13d634940
2015-12-27 18:02:45.565 GoodNight[357:34548] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[MainViewController colorChangingEnabledSwitchChanged]: unrecognized selector sent to instance 0x13d634940'
*** First throw call stack:
(0x182d69900 0x1823d7f80 0x182d7061c 0x182d6d5b8 0x182c7168c 0x187a93e50 0x187a93dcc 0x187a7ba88 0x187ceb92c 0x187ceb14c 0x187ceb460 0x187fdcdbc 0x187c005b8 0x187a8e9b0 0x187fde3bc 0x187a4db58 0x187a4a8dc 0x187a8c820 0x187a8be1c 0x187a5c4cc 0x187a5a794 0x182d20efc 0x182d20990 0x182d1e690 0x182c4d680 0x18415c088 0x187ac4d90 0x10009569c 0x1827ee8b8)
libc++abi.dylib: terminating with uncaught exception of type NSException
(lldb)

Also, when I press Brightness, the app just crashes. Xcode gives the following:
2015-12-27 18:03:37.896 GoodNight[361:35010] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'Storyboard (<UIStoryboard: 0x134508ff0>) doesn't contain a view controller with identifier 'whitepointController''
*** First throw call stack:
(0x182d69900 0x1823d7f80 0x188182224 0x10011a34c 0x100107658 0x187b91f38 0x187c50018 0x187d0cb70 0x187d1a030 0x187a4dc24 0x182d20588 0x182d1e32c 0x182d1e75c 0x182c4d680 0x18415c088 0x187ac4d90 0x10011d69c 0x1827ee8b8)
libc++abi.dylib: terminating with uncaught exception of type NSException
(lldb)

Again, I've to reinstall the app to get basic Temperature working again. Is this indicative of wrong group ID and app group problems?
I've uploaded my project here. I apologise if this is a rookie mistake.

GoodNight-masterkly.zip