Giter VIP home page Giter VIP logo

Comments (4)

antonbabenko avatar antonbabenko commented on August 17, 2024

First, thanks for opening this issue!

The question which I have been asking myself few times in several projects which version(s) of sed should I use. If I understand correctly GNU sed is more powerful and easily available for the most of operating systems (right?).

Will it be fine, if we just extend the script to print a statement that GNU sed should be installed? "pass" if GNU sed does not exist.

It may be possible to rewrite it using Python (or anything else), but there will be the similar issue - which version of Python to expect (python 2.7 vs 3.x?)

from pre-commit-terraform.

brainsik avatar brainsik commented on August 17, 2024

I ended up rewriting the sed commands in Perl, which should make the script more universally usable without external tools. See #15.

from pre-commit-terraform.

varac avatar varac commented on August 17, 2024

Well, not excatly because it breaks setups in small docker images where perl is not installed (like the official hashicorp/terraform:0.13.5 docker image i.e.):

Terraform docs...........................................................Failed
- hook id: terraform_docs
- exit code: 127

/builds/project-0/.cache/pre-commit/repowvx2neb8/terraform_docs.sh: line 144: perl: command not found

from pre-commit-terraform.

antonbabenko avatar antonbabenko commented on August 17, 2024

Make sure to install perl. I know it sounds odd in 2020 but we use it here also :)

from pre-commit-terraform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.