Giter VIP home page Giter VIP logo

pre-commit-terraform's Introduction

Collection of git hooks for Terraform to be used with pre-commit framework

Github tag maintenance status Help Contribute to Open Source

SWUbanner

Want to contribute? Check open issues and contributing notes.

Sponsors


Terramate: Automate, Orchestrate and Observe Terraform

Terramate is an IaC collaboration, visibility and observability platform that empowers your team to manage Terraform and OpenTofu faster and more confidently than ever before.

If you want to support the development of pre-commit-terraform and many other open-source projects, please become a GitHub Sponsor!

Table of content

How to install

1. Install dependencies

  • pre-commit, terraform or opentofu, git, BASH 3.2.57 or newer, Internet connection (on first run), x86_64 or arm64 compatible operation system, Some hardware where this OS will run, Electricity for hardware and internet connection, Some basic physical laws, Hope that it all will work.

  • checkov required for terraform_checkov hook
  • terraform-docs required for terraform_docs hook
  • terragrunt required for terragrunt_validate and terragrunt_valid_inputs hooks
  • terrascan required for terrascan hook
  • TFLint required for terraform_tflint hook
  • TFSec required for terraform_tfsec hook
  • Trivy required for terraform_trivy hook
  • infracost required for infracost_breakdown hook
  • jq required for terraform_validate with --retry-once-with-cleanup flag, and for infracost_breakdown hook
  • tfupdate required for tfupdate hook
  • hcledit required for terraform_wrapper_module_for_each hook

1.1 Custom Terraform binaries and OpenTofu support

It is possible to set custom path to terraform binary.
This makes it possible to use OpenTofu binary tofu instead of terraform.

How binary discovery works and how you can redefine it (first matched takes precedence):

  1. Check if per hook configuration --hook-config=--tf-path=<path_to_binary_or_binary_name> is set
  2. Check if PCT_TFPATH=<path_to_binary_or_binary_name> environment variable is set
  3. Check if TERRAGRUNT_TFPATH=<path_to_binary_or_binary_name> environment variable is set
  4. Check if terraform binary can be found in the user's $PATH
  5. Check if tofu binary can be found in the user's $PATH
Docker

Pull docker image with all hooks:

TAG=latest
docker pull ghcr.io/antonbabenko/pre-commit-terraform:$TAG

All available tags here.

Build from scratch:

[!IMPORTANT] To build image you need to have docker buildx enabled as default builder.
Otherwise - provide TARGETOS and TARGETARCH as additional --build-arg's to docker build.

When hooks-related --build-args are not specified, only the latest version of pre-commit and terraform will be installed.

git clone [email protected]:antonbabenko/pre-commit-terraform.git
cd pre-commit-terraform
# Install the latest versions of all the tools
docker build -t pre-commit-terraform --build-arg INSTALL_ALL=true .

To install a specific version of individual tools, define it using --build-arg arguments or set it to latest:

docker build -t pre-commit-terraform \
    --build-arg PRE_COMMIT_VERSION=latest \
    --build-arg OPENTOFU_VERSION=latest \
    --build-arg TERRAFORM_VERSION=1.5.7 \
    --build-arg CHECKOV_VERSION=2.0.405 \
    --build-arg HCLEDIT_VERSION=latest \
    --build-arg INFRACOST_VERSION=latest \
    --build-arg TERRAFORM_DOCS_VERSION=0.15.0 \
    --build-arg TERRAGRUNT_VERSION=latest \
    --build-arg TERRASCAN_VERSION=1.10.0 \
    --build-arg TFLINT_VERSION=0.31.0 \
    --build-arg TFSEC_VERSION=latest \
    --build-arg TFUPDATE_VERSION=latest \
    --build-arg TRIVY_VERSION=latest \
    .

Set -e PRE_COMMIT_COLOR=never to disable the color output in pre-commit.

MacOS
brew install pre-commit terraform-docs tflint tfsec trivy checkov terrascan infracost tfupdate minamijoyo/hcledit/hcledit jq
Ubuntu 18.04
sudo apt update
sudo apt install -y unzip software-properties-common
sudo add-apt-repository ppa:deadsnakes/ppa
sudo apt install -y python3.7 python3-pip
python3 -m pip install --upgrade pip
pip3 install --no-cache-dir pre-commit
python3.7 -m pip install -U checkov
curl -L "$(curl -s https://api.github.com/repos/terraform-docs/terraform-docs/releases/latest | grep -o -E -m 1 "https://.+?-linux-amd64.tar.gz")" > terraform-docs.tgz && tar -xzf terraform-docs.tgz && rm terraform-docs.tgz && chmod +x terraform-docs && sudo mv terraform-docs /usr/bin/
curl -L "$(curl -s https://api.github.com/repos/terraform-linters/tflint/releases/latest | grep -o -E -m 1 "https://.+?_linux_amd64.zip")" > tflint.zip && unzip tflint.zip && rm tflint.zip && sudo mv tflint /usr/bin/
curl -L "$(curl -s https://api.github.com/repos/aquasecurity/tfsec/releases/latest | grep -o -E -m 1 "https://.+?tfsec-linux-amd64")" > tfsec && chmod +x tfsec && sudo mv tfsec /usr/bin/
curl -L "$(curl -s https://api.github.com/repos/aquasecurity/trivy/releases/latest | grep -o -E -i -m 1 "https://.+?/trivy_.+?_Linux-64bit.tar.gz")" > trivy.tar.gz && tar -xzf trivy.tar.gz trivy && rm trivy.tar.gz && sudo mv trivy /usr/bin
curl -L "$(curl -s https://api.github.com/repos/tenable/terrascan/releases/latest | grep -o -E -m 1 "https://.+?_Linux_x86_64.tar.gz")" > terrascan.tar.gz && tar -xzf terrascan.tar.gz terrascan && rm terrascan.tar.gz && sudo mv terrascan /usr/bin/ && terrascan init
sudo apt install -y jq && \
curl -L "$(curl -s https://api.github.com/repos/infracost/infracost/releases/latest | grep -o -E -m 1 "https://.+?-linux-amd64.tar.gz")" > infracost.tgz && tar -xzf infracost.tgz && rm infracost.tgz && sudo mv infracost-linux-amd64 /usr/bin/infracost && infracost auth login
curl -L "$(curl -s https://api.github.com/repos/minamijoyo/tfupdate/releases/latest | grep -o -E -m 1 "https://.+?_linux_amd64.tar.gz")" > tfupdate.tar.gz && tar -xzf tfupdate.tar.gz tfupdate && rm tfupdate.tar.gz && sudo mv tfupdate /usr/bin/
curl -L "$(curl -s https://api.github.com/repos/minamijoyo/hcledit/releases/latest | grep -o -E -m 1 "https://.+?_linux_amd64.tar.gz")" > hcledit.tar.gz && tar -xzf hcledit.tar.gz hcledit && rm hcledit.tar.gz && sudo mv hcledit /usr/bin/
Ubuntu 20.04+
sudo apt update
sudo apt install -y unzip software-properties-common python3 python3-pip python-is-python3
python3 -m pip install --upgrade pip
pip3 install --no-cache-dir pre-commit
pip3 install --no-cache-dir checkov
curl -L "$(curl -s https://api.github.com/repos/terraform-docs/terraform-docs/releases/latest | grep -o -E -m 1 "https://.+?-linux-amd64.tar.gz")" > terraform-docs.tgz && tar -xzf terraform-docs.tgz terraform-docs && rm terraform-docs.tgz && chmod +x terraform-docs && sudo mv terraform-docs /usr/bin/
curl -L "$(curl -s https://api.github.com/repos/tenable/terrascan/releases/latest | grep -o -E -m 1 "https://.+?_Linux_x86_64.tar.gz")" > terrascan.tar.gz && tar -xzf terrascan.tar.gz terrascan && rm terrascan.tar.gz && sudo mv terrascan /usr/bin/ && terrascan init
curl -L "$(curl -s https://api.github.com/repos/terraform-linters/tflint/releases/latest | grep -o -E -m 1 "https://.+?_linux_amd64.zip")" > tflint.zip && unzip tflint.zip && rm tflint.zip && sudo mv tflint /usr/bin/
curl -L "$(curl -s https://api.github.com/repos/aquasecurity/tfsec/releases/latest | grep -o -E -m 1 "https://.+?tfsec-linux-amd64")" > tfsec && chmod +x tfsec && sudo mv tfsec /usr/bin/
curl -L "$(curl -s https://api.github.com/repos/aquasecurity/trivy/releases/latest | grep -o -E -i -m 1 "https://.+?/trivy_.+?_Linux-64bit.tar.gz")" > trivy.tar.gz && tar -xzf trivy.tar.gz trivy && rm trivy.tar.gz && sudo mv trivy /usr/bin
sudo apt install -y jq && \
curl -L "$(curl -s https://api.github.com/repos/infracost/infracost/releases/latest | grep -o -E -m 1 "https://.+?-linux-amd64.tar.gz")" > infracost.tgz && tar -xzf infracost.tgz && rm infracost.tgz && sudo mv infracost-linux-amd64 /usr/bin/infracost && infracost auth login
curl -L "$(curl -s https://api.github.com/repos/minamijoyo/tfupdate/releases/latest | grep -o -E -m 1 "https://.+?_linux_amd64.tar.gz")" > tfupdate.tar.gz && tar -xzf tfupdate.tar.gz tfupdate && rm tfupdate.tar.gz && sudo mv tfupdate /usr/bin/
curl -L "$(curl -s https://api.github.com/repos/minamijoyo/hcledit/releases/latest | grep -o -E -m 1 "https://.+?_linux_amd64.tar.gz")" > hcledit.tar.gz && tar -xzf hcledit.tar.gz hcledit && rm hcledit.tar.gz && sudo mv hcledit /usr/bin/
Windows 10/11

We highly recommend using WSL/WSL2 with Ubuntu and following the Ubuntu installation guide. Or use Docker.

[!IMPORTANT] We won't be able to help with issues that can't be reproduced in Linux/Mac. So, try to find a working solution and send PR before open an issue.

Otherwise, you can follow this gist:

  1. Install git and gitbash
  2. Install Python 3
  3. Install all prerequisites needed (see above)

Ensure your PATH environment variable looks for bash.exe in C:\Program Files\Git\bin (the one present in C:\Windows\System32\bash.exe does not work with pre-commit.exe)

For checkov, you may need to also set your PYTHONPATH environment variable with the path to your Python modules.
E.g. C:\Users\USERNAME\AppData\Local\Programs\Python\Python39\Lib\site-packages

2. Install the pre-commit hook globally

Note

Not needed if you use the Docker image

DIR=~/.git-template
git config --global init.templateDir ${DIR}
pre-commit init-templatedir -t pre-commit ${DIR}

3. Add configs and hooks

Step into the repository you want to have the pre-commit hooks installed and run:

git init
cat <<EOF > .pre-commit-config.yaml
repos:
- repo: https://github.com/antonbabenko/pre-commit-terraform
  rev: <VERSION> # Get the latest from: https://github.com/antonbabenko/pre-commit-terraform/releases
  hooks:
    - id: terraform_fmt
    - id: terraform_docs
EOF

4. Run

Execute this command to run pre-commit on all files in the repository (not only changed files):

pre-commit run -a

Or, using Docker (available tags):

Tip

This command uses your user id and group id for the docker container to use to access the local files. If the files are owned by another user, update the USERID environment variable. See File Permissions section for more information.

TAG=latest
docker run -e "USERID=$(id -u):$(id -g)" -v $(pwd):/lint -w /lint ghcr.io/antonbabenko/pre-commit-terraform:$TAG run -a

Execute this command to list the versions of the tools in Docker:

TAG=latest
docker run --rm --entrypoint cat ghcr.io/antonbabenko/pre-commit-terraform:$TAG /usr/bin/tools_versions_info

Available Hooks

There are several pre-commit hooks to keep Terraform configurations (both *.tf and *.tfvars) and Terragrunt configurations (*.hcl) in a good shape:

Hook name Description Dependencies
Install instructions here
checkov and terraform_checkov checkov static analysis of terraform templates to spot potential security issues. Hook notes checkov
Ubuntu deps: python3, python3-pip
infracost_breakdown Check how much your infra costs with infracost. Hook notes infracost, jq, Infracost API key
terraform_docs Inserts input and output documentation into README.md. Recommended. Hook notes terraform-docs
terraform_docs_replace Runs terraform-docs and pipes the output directly to README.md. DEPRECATED, see #248. Hook notes python3, terraform-docs
terraform_docs_without_
aggregate_type_defaults
Inserts input and output documentation into README.md without aggregate type defaults. Hook notes same as for terraform_docs terraform-docs
terraform_fmt Reformat all Terraform configuration files to a canonical format. Hook notes -
terraform_providers_lock Updates provider signatures in dependency lock files. Hook notes -
terraform_tflint Validates all Terraform configuration files with TFLint. Available TFLint rules. Hook notes. tflint
terraform_tfsec TFSec static analysis of terraform templates to spot potential security issues. DEPRECATED, use terraform_trivy. Hook notes tfsec
terraform_trivy Trivy static analysis of terraform templates to spot potential security issues. Hook notes trivy
terraform_validate Validates all Terraform configuration files. Hook notes jq, only for --retry-once-with-cleanup flag
terragrunt_fmt Reformat all Terragrunt configuration files (*.hcl) to a canonical format. terragrunt
terragrunt_validate Validates all Terragrunt configuration files (*.hcl) terragrunt
terragrunt_validate_inputs Validates Terragrunt unused and undefined inputs (*.hcl)
terragrunt_providers_lock Generates .terraform.lock.hcl files using Terragrunt. terragrunt
terraform_wrapper_module_for_each Generates Terraform wrappers with for_each in module. Hook notes hcledit
terrascan terrascan Detect compliance and security violations. Hook notes terrascan
tfupdate tfupdate Update version constraints of Terraform core, providers, and modules. Hook notes tfupdate

Check the source file to know arguments used for each hook.

Hooks usage notes and examples

Known limitations

Terraform operates on a per-dir basis, while pre-commit framework only supports files and files that exist. This means if you only remove the TF-related file without any other changes in the same dir, checks will be skipped. Example and details here.

All hooks: Usage of environment variables in --args

All, except deprecated hooks: checkov, terraform_docs_replace

You can use environment variables for the --args section.

Important

You must use the ${ENV_VAR} definition, $ENV_VAR will not expand.

Config example:

- id: terraform_tflint
  args:
  - --args=--config=${CONFIG_NAME}.${CONFIG_EXT}
  - --args=--module

If for config above set up export CONFIG_NAME=.tflint; export CONFIG_EXT=hcl before pre-commit run, args will be expanded to --config=.tflint.hcl --module.

All hooks: Set env vars inside hook at runtime

All, except deprecated hooks: checkov, terraform_docs_replace

You can specify environment variables that will be passed to the hook at runtime.

Important

Variable values are exported verbatim:

  • No interpolation or expansion are applied
  • The enclosing double quotes are removed if they are provided

Config example:

- id: terraform_validate
  args:
    - --env-vars=AWS_DEFAULT_REGION="us-west-2"
    - --env-vars=AWS_PROFILE="my-aws-cli-profile"

All hooks: Disable color output

All, except deprecated hooks: checkov, terraform_docs_replace

To disable color output for all hooks, set PRE_COMMIT_COLOR=never var. Eg:

PRE_COMMIT_COLOR=never pre-commit run

All hooks: Log levels

In case you need to debug hooks, you can set PCT_LOG=trace.

For example:

PCT_LOG=trace pre-commit run -a

Less verbose log levels will be implemented in #562.

Many hooks: Parallelism

All, except deprecated hooks: checkov, terraform_docs_replace and hooks which can't be paralleled this way: infracost_breakdown, terraform_wrapper_module_for_each.
Also, there's a chance that parallelism have no effect on terragrunt_fmt and terragrunt_validate hooks

By default, parallelism is set to number of logical CPUs - 1.
If you'd like to disable parallelism, set it to 1

- id: terragrunt_validate
  args:
    - --hook-config=--parallelism-limit=1

In the same way you can set it to any positive integer.

If you'd like to set parallelism value relative to number of CPU logical cores - provide valid Bash arithmetic expression and use CPU as a reference to the number of CPU logical cores

- id: terraform_providers_lock
  args:
    - --hook-config=--parallelism-limit=CPU*4

Tip

Info useful for parallelism fine-tunning
Tests below were run on repo with 45 Terraform dirs on laptop with 16 CPUs, SSD and 1Gbit/s network. Laptop was slightly used in the process.

Observed results may vary greatly depending on your repo structure, machine characteristics and their usage.

If during fine-tuning you'll find that your results are very different from provided below and you think that this data could help someone else - feel free to send PR.

Hook Most used resource Comparison of optimization results / Notes
terraform_checkov CPU heavy -
terraform_fmt CPU heavy -
terraform_providers_lock (3 platforms,
--mode=always-regenerate-lockfile)
Network & Disk heavy defaults (CPU-1) - 3m 39s; CPU*2 - 3m 19s; CPU*4 - 2m 56s
terraform_tflint CPU heavy -
terraform_tfsec CPU heavy -
terraform_trivy CPU moderate defaults (CPU-1) - 32s; CPU*2 - 30s; CPU*4 - 31s
terraform_validate (t validate only) CPU heavy -
terraform_validate (t init + t validate) Network & Disk heavy, CPU moderate defaults (CPU-1) - 1m 30s; CPU*2 - 1m 25s; CPU*4 - 1m 41s
terragrunt_fmt CPU heavy N/A? need more info from TG users
terragrunt_validate CPU heavy N/A? need more info from TG users
terrascan CPU moderate-heavy defaults (CPU-1) - 8s; CPU*2 - 6s
tfupdate Disk/Network? too quick in any settings. More info needed
args:
  - --hook-config=--parallelism-ci-cpu-cores=N

If you don't see code above in your pre-commit-config.yaml or logs - you don't need it.
--parallelism-ci-cpu-cores used only in edge cases and is ignored in other situations. Check out its usage in hooks/_common.sh

checkov (deprecated) and terraform_checkov

checkov hook is deprecated, please use terraform_checkov.

Note that terraform_checkov runs recursively during -d . usage. That means, for example, if you change .tf file in repo root, all existing .tf files in the repo will be checked.

  1. You can specify custom arguments. E.g.:

    - id: terraform_checkov
      args:
        - --args=--quiet
        - --args=--skip-check CKV2_AWS_8

    Check all available arguments here.

For deprecated hook you need to specify each argument separately:

- id: checkov
  args: [
    "-d", ".",
    "--skip-check", "CKV2_AWS_8",
  ]
  1. When you have multiple directories and want to run terraform_checkov in all of them and share a single config file - use the __GIT_WORKING_DIR__ placeholder. It will be replaced by terraform_checkov hooks with the Git working directory (repo root) at run time. For example:

    - id: terraform_checkov
      args:
        - --args=--config-file __GIT_WORKING_DIR__/.checkov.yml

infracost_breakdown

infracost_breakdown executes infracost breakdown command and compare the estimated costs with those specified in the hook-config. infracost breakdown parses Terraform HCL code, and calls Infracost Cloud Pricing API (remote version or self-hosted version).

Unlike most other hooks, this hook triggers once if there are any changed files in the repository.

  1. infracost_breakdown supports all infracost breakdown arguments (run infracost breakdown --help to see them). The following example only shows costs:

    - id: infracost_breakdown
      args:
        - --args=--path=./env/dev
      verbose: true # Always show costs
    Output
    Running in "env/dev"
    
    Summary: {
    "unsupportedResourceCounts": {
        "aws_sns_topic_subscription": 1
      }
    }
    
    Total Monthly Cost:        86.83 USD
    Total Monthly Cost (diff): 86.83 USD
  2. Note that spaces are not allowed in --args, so you need to split it, like this:

    - id: infracost_breakdown
      args:
        - --args=--path=./env/dev
        - --args=--terraform-var-file="terraform.tfvars"
        - --args=--terraform-var-file="../terraform.tfvars"
  3. (Optionally) Define cost constraints the hook should evaluate successfully in order to pass:

    - id: infracost_breakdown
      args:
        - --args=--path=./env/dev
        - --hook-config='.totalHourlyCost|tonumber > 0.1'
        - --hook-config='.totalHourlyCost|tonumber > 1'
        - --hook-config='.projects[].diff.totalMonthlyCost|tonumber != 10000'
        - --hook-config='.currency == "USD"'
    Output
    Running in "env/dev"
    Passed: .totalHourlyCost|tonumber > 0.1         0.11894520547945205 >  0.1
    Failed: .totalHourlyCost|tonumber > 1           0.11894520547945205 >  1
    Passed: .projects[].diff.totalMonthlyCost|tonumber !=10000              86.83 != 10000
    Passed: .currency == "USD"              "USD" == "USD"
    
    Summary: {
    "unsupportedResourceCounts": {
        "aws_sns_topic_subscription": 1
      }
    }
    
    Total Monthly Cost:        86.83 USD
    Total Monthly Cost (diff): 86.83 USD
    • Only one path per one hook (- id: infracost_breakdown) is allowed.
    • Set verbose: true to see cost even when the checks are passed.
    • Hook uses jq to process the cost estimation report returned by infracost breakdown command
    • Expressions defined as --hook-config argument should be in a jq-compatible format (e.g. .totalHourlyCost, .totalMonthlyCost) To study json output produced by infracost, run the command infracost breakdown -p PATH_TO_TF_DIR --format json, and explore it on jqplay.org.
    • Supported comparison operators: <, <=, ==, !=, >=, >.
    • Most useful paths and checks:
      • .totalHourlyCost (same as .projects[].breakdown.totalHourlyCost) - show total hourly infra cost
      • .totalMonthlyCost (same as .projects[].breakdown.totalMonthlyCost) - show total monthly infra cost
      • .projects[].diff.totalHourlyCost - show the difference in hourly cost for the existing infra and tf plan
      • .projects[].diff.totalMonthlyCost - show the difference in monthly cost for the existing infra and tf plan
      • .diffTotalHourlyCost (for Infracost version 0.9.12 or newer) or [.projects[].diff.totalMonthlyCost | select (.!=null) | tonumber] | add (for Infracost older than 0.9.12)
  4. Docker usage. In docker build or docker run command:

    • You need to provide Infracost API key via -e INFRACOST_API_KEY=<your token>. By default, it is saved in ~/.config/infracost/credentials.yml
    • Set -e INFRACOST_SKIP_UPDATE_CHECK=true to skip the Infracost update check if you use this hook as part of your CI/CD pipeline.

terraform_docs

  1. terraform_docs and terraform_docs_without_aggregate_type_defaults will insert/update documentation generated by terraform-docs framed by markers:

    <!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
    
    <!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->

    if they are present in README.md.

  2. It is possible to pass additional arguments to shell scripts when using terraform_docs and terraform_docs_without_aggregate_type_defaults.

  3. It is possible to automatically:

    • create a documentation file

    • extend existing documentation file by appending markers to the end of the file (see item 1 above)

    • use different filename for the documentation (default is README.md)

    • use the same insertion markers as terraform-docs by default. It will be default in v2.0.
      To migrate to terraform-docs insertion markers, run in repo root:

      grep -rl 'BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK' . | xargs sed -i 's/BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK/BEGIN_TF_DOCS/g'
      grep -rl 'END OF PRE-COMMIT-TERRAFORM DOCS HOOK' . | xargs sed -i 's/END OF PRE-COMMIT-TERRAFORM DOCS HOOK/END_TF_DOCS/g'
    - id: terraform_docs
      args:
        - --hook-config=--path-to-file=README.md        # Valid UNIX path. I.e. ../TFDOC.md or docs/README.md etc.
        - --hook-config=--add-to-existing-file=true     # Boolean. true or false
        - --hook-config=--create-file-if-not-exist=true # Boolean. true or false
        - --hook-config=--use-standard-markers=true     # Boolean. Defaults in v1.x to false. Set to true for compatibility with terraform-docs
  4. You can provide any configuration available in terraform-docs as an argument to terraform_doc hook, for example:

    - id: terraform_docs
      args:
        - --args=--config=.terraform-docs.yml

    Warning
    Avoid use recursive.enabled: true in config file, that can cause unexpected behavior.

  5. If you need some exotic settings, it can be done too. I.e. this one generates HCL files:

    - id: terraform_docs
      args:
        - tfvars hcl --output-file terraform.tfvars.model .

terraform_docs_replace (deprecated)

DEPRECATED. Will be merged in terraform_docs.

terraform_docs_replace replaces the entire README.md rather than doing string replacement between markers. Put your additional documentation at the top of your main.tf for it to be pulled in.

To replicate functionality in terraform_docs hook:

  1. Create .terraform-docs.yml in the repo root with the following content:

    formatter: "markdown"
    
    output:
    file: "README.md"
    mode: replace
    template: |-
        {{/** End of file fixer */}}
  2. Replace terraform_docs_replace hook config in .pre-commit-config.yaml with:

    - id: terraform_docs
    args:
        - --args=--config=.terraform-docs.yml

terraform_fmt

  1. terraform_fmt supports custom arguments so you can pass supported flags. Eg:

     - id: terraform_fmt
       args:
         - --args=-no-color
         - --args=-diff
         - --args=-write=false

terraform_providers_lock

Note

The hook requires Terraform 0.14 or later.

Note

The hook can invoke terraform providers lock that can be really slow and requires fetching metadata from remote Terraform registries - not all of that metadata is currently being cached by Terraform.

Note

Read this if you used this hook before v1.80.0 | Planned breaking changes in v2.0
We introduced `--mode` flag for this hook. If you'd like to continue using this hook as before, please:
  • Specify --hook-config=--mode=always-regenerate-lockfile in args:
  • Before terraform_providers_lock, add terraform_validate hook with --hook-config=--retry-once-with-cleanup=true
  • Move --tf-init-args= to terraform_validate hook

In the end, you should get config like this:

- id: terraform_validate
  args:
    - --hook-config=--retry-once-with-cleanup=true
    # - --tf-init-args=-upgrade

- id: terraform_providers_lock
  args:
  - --hook-config=--mode=always-regenerate-lockfile

Why? When v2.x will be introduced - the default mode will be changed, probably, to only-check-is-current-lockfile-cross-platform.

You can check available modes for hook below.

  1. The hook can work in a few different modes: only-check-is-current-lockfile-cross-platform with and without terraform_validate hook and always-regenerate-lockfile - only with terraform_validate hook.

    • only-check-is-current-lockfile-cross-platform without terraform_validate - only checks that lockfile has all required SHAs for all providers already added to lockfile.

      - id: terraform_providers_lock
        args:
        - --hook-config=--mode=only-check-is-current-lockfile-cross-platform
    • only-check-is-current-lockfile-cross-platform with terraform_validate hook - make up-to-date lockfile by adding/removing providers and only then check that lockfile has all required SHAs.

      Important Next terraform_validate flag requires additional dependency to be installed: jq. Also, it could run another slow and time consuming command - terraform init

      - id: terraform_validate
        args:
          - --hook-config=--retry-once-with-cleanup=true
      
      - id: terraform_providers_lock
        args:
        - --hook-config=--mode=only-check-is-current-lockfile-cross-platform
    • always-regenerate-lockfile only with terraform_validate hook - regenerate lockfile from scratch. Can be useful for upgrading providers in lockfile to latest versions

      - id: terraform_validate
        args:
          - --hook-config=--retry-once-with-cleanup=true
          - --tf-init-args=-upgrade
      
      - id: terraform_providers_lock
        args:
        - --hook-config=--mode=always-regenerate-lockfile
  2. terraform_providers_lock supports custom arguments:

     - id: terraform_providers_lock
       args:
          - --args=-platform=windows_amd64
          - --args=-platform=darwin_amd64
  3. It may happen that Terraform working directory (.terraform) already exists but not in the best condition (eg, not initialized modules, wrong version of Terraform, etc.). To solve this problem, you can find and delete all .terraform directories in your repository:

    echo "
    function rm_terraform {
        find . \( -iname ".terraform*" ! -iname ".terraform-docs*" \) -print0 | xargs -0 rm -r
    }
    " >>~/.bashrc
    
    # Reload shell and use `rm_terraform` command in the repo root

    terraform_providers_lock hook will try to reinitialize directories before running the terraform providers lock command.

  4. terraform_providers_lock support passing custom arguments to its terraform init:

    Warning
    DEPRECATION NOTICE: This is available only in no-mode mode, which will be removed in v2.0. Please provide this keys to terraform_validate hook, which, to take effect, should be called before terraform_providers_lock

    - id: terraform_providers_lock
      args:
        - --tf-init-args=-upgrade

terraform_tflint

  1. terraform_tflint supports custom arguments so you can enable module inspection, enable / disable rules, etc.

    Example:

    - id: terraform_tflint
      args:
        - --args=--module
        - --args=--enable-rule=terraform_documented_variables
  2. When you have multiple directories and want to run tflint in all of them and share a single config file, it is impractical to hard-code the path to the .tflint.hcl file. The solution is to use the __GIT_WORKING_DIR__ placeholder which will be replaced by terraform_tflint hooks with the Git working directory (repo root) at run time. For example:

    - id: terraform_tflint
      args:
        - --args=--config=__GIT_WORKING_DIR__/.tflint.hcl
  3. By default, pre-commit-terraform performs directory switching into the terraform modules for you. If you want to delgate the directory changing to the binary - this will allow tflint to determine the full paths for error/warning messages, rather than just module relative paths. Note: this requires tflint>=0.44.0. For example:

    - id: terraform_tflint
          args:
            - --hook-config=--delegate-chdir

terraform_tfsec (deprecated)

DEPRECATED. tfsec was replaced by trivy, so please use terraform_trivy.

  1. terraform_tfsec will consume modified files that pre-commit passes to it, so you can perform whitelisting of directories or files to run against via files pre-commit flag

    Example:

    - id: terraform_tfsec
      files: ^prd-infra/

    The above will tell pre-commit to pass down files from the prd-infra/ folder only such that the underlying tfsec tool can run against changed files in this directory, ignoring any other folders at the root level

  2. To ignore specific warnings, follow the convention from the documentation.

    Example:

    resource "aws_security_group_rule" "my-rule" {
        type = "ingress"
        cidr_blocks = ["0.0.0.0/0"] #tfsec:ignore:AWS006
    }
  3. terraform_tfsec supports custom arguments, so you can pass supported --no-color or --format (output), -e (exclude checks) flags:

     - id: terraform_tfsec
       args:
         - >
           --args=--format json
           --no-color
           -e aws-s3-enable-bucket-logging,aws-s3-specify-public-access-block
  4. When you have multiple directories and want to run tfsec in all of them and share a single config file - use the __GIT_WORKING_DIR__ placeholder. It will be replaced by terraform_tfsec hooks with Git working directory (repo root) at run time. For example:

    - id: terraform_tfsec
      args:
        - --args=--config-file=__GIT_WORKING_DIR__/.tfsec.json

    Otherwise, will be used files that located in sub-folders:

    - id: terraform_tfsec
      args:
        - --args=--config-file=.tfsec.json

terraform_trivy

  1. terraform_trivy will consume modified files that pre-commit passes to it, so you can perform whitelisting of directories or files to run against via files pre-commit flag

    Example:

    - id: terraform_trivy
      files: ^prd-infra/

    The above will tell pre-commit to pass down files from the prd-infra/ folder only such that the underlying trivy tool can run against changed files in this directory, ignoring any other folders at the root level

  2. To ignore specific warnings, follow the convention from the documentation.

    Example:

    #trivy:ignore:AVD-AWS-0107
    #trivy:ignore:AVD-AWS-0124
    resource "aws_security_group_rule" "my-rule" {
        type = "ingress"
        cidr_blocks = ["0.0.0.0/0"]
    }
  3. terraform_trivy supports custom arguments, so you can pass supported --format (output), --skip-dirs (exclude directories) and other flags:

     - id: terraform_trivy
        args:
          - --args=--format=json
          - --args=--skip-dirs="**/.terraform"
  4. When you have multiple directories and want to run trivy in all of them and share a single config file - use the __GIT_WORKING_DIR__ placeholder. It will be replaced by terraform_trivy hooks with Git working directory (repo root) at run time. For example:

    - id: terraform_trivy
      args:
        - --args=--ignorefile=__GIT_WORKING_DIR__/.trivyignore

terraform_validate

Important

If you use TF_PLUGIN_CACHE_DIR, we recommend enabling --hook-config=--retry-once-with-cleanup=true or disabling parallelism (--hook-config=--parallelism-limit=1) to avoid race conditions when terraform init writes to it.

  1. terraform_validate supports custom arguments so you can pass supported -no-color or -json flags:

     - id: terraform_validate
       args:
         - --args=-json
         - --args=-no-color
  2. terraform_validate also supports passing custom arguments to its terraform init:

    - id: terraform_validate
      args:
        - --tf-init-args=-upgrade
        - --tf-init-args=-lockfile=readonly
  3. It may happen that Terraform working directory (.terraform) already exists but not in the best condition (eg, not initialized modules, wrong version of Terraform, etc.). To solve this problem, you can delete broken .terraform directories in your repository:

    Option 1

    - id: terraform_validate
      args:
        - --hook-config=--retry-once-with-cleanup=true     # Boolean. true or false

    Important
    The flag requires additional dependency to be installed: jq.

    Note
    Reinit can be very slow and require downloading data from remote Terraform registries, and not all of that downloaded data or meta-data is currently being cached by Terraform.

    When --retry-once-with-cleanup=true, in each failed directory the cached modules and providers from the .terraform directory will be deleted, before retrying once more. To avoid unnecessary deletion of this directory, the cleanup and retry will only happen if Terraform produces any of the following error messages:

    • "Missing or corrupted provider plugins"
    • "Module source has changed"
    • "Module version requirements have changed"
    • "Module not installed"
    • "Could not load plugin"

    Warning
    When using --retry-once-with-cleanup=true, problematic .terraform/modules/ and .terraform/providers/ directories will be recursively deleted without prompting for consent. Other files and directories will not be affected, such as the .terraform/environment file.

    Option 2

    An alternative solution is to find and delete all .terraform directories in your repository:

    echo "
    function rm_terraform {
        find . \( -iname ".terraform*" ! -iname ".terraform-docs*" \) -print0 | xargs -0 rm -r
    }
    " >>~/.bashrc
    
    # Reload shell and use `rm_terraform` command in the repo root

    terraform_validate hook will try to reinitialize them before running the terraform validate command.

    Caution
    If you use Terraform workspaces, DO NOT use this option (details). Consider the first option, or wait for force-init option implementation.

  4. terraform_validate in a repo with Terraform module, written using Terraform 0.15+ and which uses provider configuration_aliases (Provider Aliases Within Modules), errors out.

    When running the hook against Terraform code where you have provider configuration_aliases defined in a required_providers configuration block, terraform will throw an error like:

    Error: Provider configuration not present To work with <resource> its original provider configuration at provider ["registry.terraform.io/hashicorp/aws"].<provider_alias> is required, but it has been removed. This occurs when a provider configuration is removed while objects created by that provider still exist in the state. Re-add the provider configuration to destroy <resource>, after which you can remove the provider configuration again.

    This is a known issue with Terraform and how providers are initialized in Terraform 0.15 and later. To work around this you can add an exclude parameter to the configuration of terraform_validate hook like this:

    - id: terraform_validate
      exclude: '^[^/]+$'

    This will exclude the root directory from being processed by this hook. Then add a subdirectory like "examples" or "tests" and put an example implementation in place that defines the providers with the proper aliases, and this will give you validation of your module through the example. If instead you are using this with multiple modules in one repository you'll want to set the path prefix in the regular expression, such as exclude: modules/offendingmodule/[^/]+$.

    Alternately, you can use terraform-config-inspect and use a variant of this script to generate a providers file at runtime:

    terraform-config-inspect --json . | jq -r '
      [.required_providers[].aliases]
      | flatten
      | del(.[] | select(. == null))
      | reduce .[] as $entry (
        {};
        .provider[$entry.name] //= [] | .provider[$entry.name] += [{"alias": $entry.alias}]
      )
    ' | tee aliased-providers.tf.json

    Save it as .generate-providers.sh in the root of your repository and add a pre-commit hook to run it before all other hooks, like so:

    - repos:
      - repo: local
        hooks:
          - id: generate-terraform-providers
             name: generate-terraform-providers
             require_serial: true
             entry: .generate-providers.sh
             language: script
             files: \.tf(vars)?$
             pass_filenames: false
    
      - repo: https://github.com/pre-commit/pre-commit-hooks
    [...]

    Tip
    The latter method will leave an "aliased-providers.tf.json" file in your repo. You will either want to automate a way to clean this up or add it to your .gitignore or both.

terraform_wrapper_module_for_each

terraform_wrapper_module_for_each generates module wrappers for Terraform modules (useful for Terragrunt where for_each is not supported). When using this hook without arguments it will create wrappers for the root module and all modules available in "modules" directory.

You may want to customize some of the options:

  1. --module-dir=... - Specify a single directory to process. Values: "." (means just root module), "modules/iam-user" (a single module), or empty (means include all submodules found in "modules/*").
  2. --module-repo-org=... - Module repository organization (e.g. "terraform-aws-modules").
  3. --module-repo-shortname=... - Short name of the repository (e.g. "s3-bucket").
  4. --module-repo-provider=... - Name of the repository provider (e.g. "aws" or "google").

Sample configuration:

- id: terraform_wrapper_module_for_each
  args:
    - --args=--module-dir=.   # Process only root module
    - --args=--dry-run        # No files will be created/updated
    - --args=--verbose        # Verbose output

If you use hook inside Docker:
The terraform_wrapper_module_for_each hook attempts to determine the module's short name to be inserted into the generated README.md files for the source URLs. Since the container uses a bind mount at a static location, it can cause this short name to be incorrect.
If the generated name is incorrect, set them by providing the module-repo-shortname option to the hook:

- id: terraform_wrapper_module_for_each
  args:
    - '--args=--module-repo-shortname=ec2-instance'

terrascan

  1. terrascan supports custom arguments so you can pass supported flags like --non-recursive and --policy-type to disable recursive inspection and set the policy type respectively:

    - id: terrascan
      args:
        - --args=--non-recursive # avoids scan errors on subdirectories without Terraform config files
        - --args=--policy-type=azure

    See the terrascan run -h command line help for available options.

  2. Use the --args=--verbose parameter to see the rule ID in the scanning output. Useful to skip validations.

  3. Use --skip-rules="ruleID1,ruleID2" parameter to skip one or more rules globally while scanning (e.g.: --args=--skip-rules="ruleID1,ruleID2").

  4. Use the syntax #ts:skip=RuleID optional_comment inside a resource to skip the rule for that resource.

tfupdate

  1. Out of the box tfupdate will pin the terraform version:

    - id: tfupdate
      name: Autoupdate Terraform versions
  2. If you'd like to pin providers, etc., use custom arguments, i.e provider=PROVIDER_NAME:

    - id: tfupdate
      name: Autoupdate AWS provider versions
      args:
        - --args=provider aws # Will be pined to latest version
    
    - id: tfupdate
      name: Autoupdate Helm provider versions
      args:
        - --args=provider helm
        - --args=--version 2.5.0 # Will be pined to specified version

Check tfupdate usage instructions for other available options and usage examples.
No need to pass --recursive . as it is added automatically.

terragrunt_providers_lock

Tip

Use this hook only in infrastructure repos managed solely by terragrunt and do not mix with terraform_providers_lock to avoid conflicts.

Warning

Hook may be very slow, because terragrunt invokes t init under the hood.

Hook produces same results as terraform_providers_lock, but for terragrunt root modules.

It invokes terragrunt providers lock under the hood and terragrunt does its' own magic for handling lock files.

- id: terragrunt_providers_lock
  name: Terragrunt providers lock
  args:
    - --args=-platform=darwin_arm64
    - --args=-platform=darwin_amd64
    - --args=-platform=linux_amd64

terragrunt_validate_inputs

Validates Terragrunt unused and undefined inputs. This is useful for keeping configs clean when module versions change or if configs are copied.

See the Terragrunt docs for more details.

Example:

- id: terragrunt_validate_inputs
  name: Terragrunt validate inputs
  args:
    # Optionally check for unused inputs
    - --args=--terragrunt-strict-validate

Note

This hook requires authentication to a given account if defined by config to work properly. For example, if you use a third-party tool to store AWS credentials like aws-vault you must be authenticated first.

See docs for the iam_role attribute and --terragrunt-iam-role flag for more.

Docker Usage

File Permissions

A mismatch between the Docker container's user and the local repository file ownership can cause permission issues in the repository where pre-commit is run. The container runs as the root user by default, and uses a tools/entrypoint.sh script to assume a user ID and group ID if specified by the environment variable USERID.

The recommended command to run the Docker container is:

TAG=latest
docker run -e "USERID=$(id -u):$(id -g)" -v $(pwd):/lint -w /lint ghcr.io/antonbabenko/pre-commit-terraform:$TAG run -a

which uses your current session's user ID and group ID to set the variable in the run command. Without this setting, you may find files and directories owned by root in your local repository.

If the local repository is using a different user or group for permissions, you can modify the USERID to the user ID and group ID needed. Do not use the username or groupname in the environment variable, as it has no meaning in the container. You can get the current directory's owner user ID and group ID from the 3rd (user) and 4th (group) columns in ls output:

$ ls -aldn .
drwxr-xr-x 9 1000 1000 4096 Sep  1 16:23 .

Download Terraform modules from private GitHub repositories

If you use a private Git repository as your Terraform module source, you are required to authenticate to GitHub using a Personal Access Token.

When running pre-commit on Docker, both locally or on CI, you need to configure the ~/.netrc file, which contains login and initialization information used by the auto-login process.

This can be achieved by firstly creating the ~/.netrc file including your GITHUB_PAT and GITHUB_SERVER_HOSTNAME

# set GH values (replace with your own values)
GITHUB_PAT=ghp_bl481aBlabl481aBla
GITHUB_SERVER_HOSTNAME=github.com

# create .netrc file
echo -e "machine $GITHUB_SERVER_HOSTNAME\n\tlogin $GITHUB_PAT" >> ~/.netrc

The ~/.netrc file will look similar to the following:

machine github.com
  login ghp_bl481aBlabl481aBla

Tip

The value of GITHUB_SERVER_HOSTNAME can also refer to a GitHub Enterprise server (i.e. github.my-enterprise.com).

Finally, you can execute docker run with an additional volume mount so that the ~/.netrc is accessible within the container

# run pre-commit-terraform with docker
# adding volume for .netrc file
# .netrc needs to be in /root/ dir
docker run --rm -e "USERID=$(id -u):$(id -g)" -v ~/.netrc:/root/.netrc -v $(pwd):/lint -w /lint ghcr.io/antonbabenko/pre-commit-terraform:latest run -a

Github Actions

You can use this hook in your GitHub Actions workflow togehther with pre-commit. To easy up dependency management, you can use the managed docker image within your workflow. Make sure to set the image tag to the version you want to use.

In this repository's pre-commit workflow file we run pre-commit without the container image.

Here is an example that use the container image, includes caching of pre-commit dependencies and uses the pre-commit command to run the checks (but fixes will be not automatically push back to your branch, when it possible):

name: pre-commit-terraform

on:
  pull_request:

jobs:
  pre-commit:
    runs-on: ubuntu-latest
    container:
      image: ghcr.io/antonbabenko/pre-commit-terraform:latest # latest used here for simplicity, not recommended
    defaults:
      run:
        shell: bash
    steps:
      - uses: actions/checkout@v4
        with:
          fetch-depth: 0
          ref: ${{ github.event.pull_request.head.sha }}

      - run: |
          git config --global --add safe.directory $GITHUB_WORKSPACE
          git fetch --no-tags --prune --depth=1 origin +refs/heads/*:refs/remotes/origin/*

      - name: Get changed files
        id: file_changes
        run: |
          export DIFF=$(git diff --name-only origin/${{ github.base_ref }} ${{ github.sha }})
          echo "Diff between ${{ github.base_ref }} and ${{ github.sha }}"
          echo "files=$( echo "$DIFF" | xargs echo )" >> $GITHUB_OUTPUT

      - name: fix tar dependency in alpine container image
        run: |
          apk --no-cache add tar
          # check python modules installed versions
          python -m pip freeze --local

      - name: Cache pre-commit since we use pre-commit from container
        uses: actions/cache@v4
        with:
          path: ~/.cache/pre-commit
          key: pre-commit-3|${{ hashFiles('.pre-commit-config.yaml') }}

      - name: Execute pre-commit
        run: |
          pre-commit run --color=always --show-diff-on-failure --files ${{ steps.file_changes.outputs.files }}

Authors

This repository is managed by Anton Babenko with help from these awesome contributors:

Star History Chart

License

MIT licensed. See LICENSE for full details.

Additional information for users from Russia and Belarus

pre-commit-terraform's People

Contributors

ajax-ryzhyi-r avatar antonbabenko avatar bmbferreira avatar brainsik avatar carlosbustillordguez avatar choppedpork avatar krzyzakp avatar lexton avatar matiaszilli avatar mavogel avatar maxbrunet avatar maxymvlasov avatar mcdonnnj avatar metmajer avatar mj3c avatar mohitsaxenaknoldus avatar mpomery avatar nkazarian-spokeo avatar nshenry03 avatar ouranos avatar pasqualedevita avatar prahaladramji avatar renovate[bot] avatar robinbowes avatar robsonpeixoto avatar rothandrew avatar semantic-release-bot avatar sergei-ivanov avatar snolan-uturn avatar yermulnik avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

pre-commit-terraform's Issues

It should show the file path when something is changed or goes wrong

When something get wrong, it doesn't show the file path and it is very useful.

❯ git commit -v
[WARNING] Unstaged files detected.
[INFO] Stashing unstaged files to /Users/robinho/.cache/pre-commit/patch1562252730.
Terraform fmt............................................................Failed
hookid: terraform_fmt

Files were modified by this hook. Additional output:

cluster.tf

Error: Invalid block definition

  on vars.tf line 20:
  (source code not available)

A block definition must have block content delimited by "{" and "}", starting
on the same line as the block header.

Terraform v0.12x changes not working if TMPDIR not set with trailing slash

Thanks for the update...however, I received the following error when running:

Check for merge conflicts................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
hookid: terraform_docs

mktemp: failed to create file via template ‘/tmpterraform-docs-XXXXXXXXXX’: Permission denied

Looked at code and ran export TMPDIR=/tmp/, then:

$ pre-commit run -a
Check for merge conflicts................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
hookid: terraform_docs

2019/06/18 11:15:40 At 34:15: nested object expected: LBRACE got: ASSIGN

Thanks!

terraform_docs does not like "description"

Since v1.13.0 when terraform_docs hook began to work with Terraform 0.12 syntax, the awk script which is used to do the magic for Terraform 0.12 types does not like variables or outputs named "description".

As a result, this module - https://github.com/terraform-aws-modules/terraform-aws-security-group - can't use this hook.

How to reproduce?

  1. Clone this repository
  2. Clone failing terraform-aws-module repository - https://github.com/terraform-aws-modules/terraform-aws-security-group
  3. cd terraform-aws-security-group
  4. pre-commit try-repo ~/cloned-repo/pre-commit-terraform terraform_docs --verbose --all-files

Error:

At 1:17: Unknown token: 1:17 IDENT var.description

@cytopia, could you take a look at this?

terraform_validate_no_variables fails if there is no .tf files

I've got a terragrunt config tree like this:

live
├── aws
│   ├── aws
│   │   ├── cloud.tfvars
│   │   ├── eu-west-1
│   │   │   ├── development
│   │   │   │   └── terraform.tfvars
│   │   │   ├── production
│   │   │   │   └── terraform.tfvars
│   │   │   ├── region.tfvars
│   │   │   └── staging
│   │   │       └── terraform.tfvars
│   │   └── us-east-1
│   │       └── development
│   └── site.tfvars
└── terraform.tfvars

I have the terraform_validate_no_variables pre-commit hook enabled and it fails with the following msg:

Error: No Terraform configuration files found in directory:

Can't use arguments for module inspection

Hello!

I'm not sure why but I can't add arguments to terraform_tflint hook. I'm trying to use tflint --module or any argument but I always get the following error message:

getopt: unrecognize option '--module'

Project structures

I'm using official terraform modules which are located in the .terraform file and custom modules.

.
├── .terraform
├── .pre-commit-config.yaml
├── main.tf
├── variables.tf
└── outputs.tf

or

.
├── custom_module
│   ├── main.tf
│   ├── outputs.tf
│   └── variables.tf
│
├── .terraform
├── .pre-commit-config.yaml
├── main.tf
├── outputs.tf
└── variables.tf

pre-commit-config.yaml just contains the following hooks :

- repo: git://github.com/antonbabenko/pre-commit-terraform
  rev: v1.21.0
  hooks:
    - id: terraform_tflint
      args: ['--module']

I use TFLint version 0.13.1, pre-commit 1.20.0 and pre-commit-terraform v1.21.0. pre-commit is up to date.

Is there something I'm missing ? If you have any suggestion or workaround to help us with this problem, I'd greatly appreciate it.

terraform-docs broken in 1.11.0 ?

Hi, trying to use pre-commit hooks for terraform-docs but every-time the hook is passed no readme.md file is created. It works well for terraform-fmt though and modify the files accordingly. Thanks for your support!

System Information:

MacOS : 10.14.4 (18E226)
Terraform-docs : 0.6.0
Bash version : GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin18)
Terraform v0.11.13
Python 3.7.3

Files:

├── main.tf
├── output.tf
└── variable.tf

.pre-commit-hook.yaml:

  rev: v1.11.0
  hooks:
    - id: terraform_fmt
    - id: terraform_docs

Issue:

% pre-commit run -c .pre-commit-config.yaml --all-files --verbose
[terraform_fmt] Terraform fmt............................................Passed
[terraform_docs] Terraform docs..........................................Passed

Does not work on directories with spaces

Error:

/Users/Bob/.cache/pre-commit/repo7hr9pvka/terraform_fmt.sh: line 20: pushd: $path_uniq: No such file or directory

Related code:

for path_uniq in $(echo "${paths[*]}" | tr ' ' '\n' | sort -u); do
...
done

Add changes made by terraform_fmt

Hi
It would be cool if terraform_fmt would add the changes done to the file to the commit. Right know, if you don't format the files, the process is:

  • git add
  • git commit
  • the hook modifies the unformatted file, formatting it
  • git add
  • git commit

It may be:

  • git add
  • git commit
  • the hook modifies the unformatted file, formatting it, and adds it to the commit

I remember this happening automatically with this hook a couple of months ago, but I can't reproduce it, so maybe I'm just wrong.

PD: Thanks for your work, it's awesome.

hook fails if comment tags not found

I would expect a tool like this to operate in a very standard mode, not trying to do anything like inserting between comments. This is your design decision to make but I'd much prefer a more standard execution of the tool like:

terraform-docs md ./ | cat -s | ghead -n -1 > README.md

This approach is markdown linter compliant and supports the standard of putting your documentation in the main.tf

screen shot 2018-05-17 at 12 48 57 am

Pass command line options to terraform-docs

With segmentio/terraform-docs being maintained again, it would be great to leverage some new terraform-docs options, such as:

  • --no-sort: no name-sorting of inputs and outputs when the order of variables should be preserved
  • --with-aggregate-type-defaults: renders default values of types list and map as JSON string into the document

Ideally, the hook would support a pass-through option that relays command line arguments on to terraform-docs. @antonbabenko: Thoughts?

tflint - No such file or directory

Hello, for my typical terraform + terragrunt repo with following .tflint.hcl configuration:

config {
  module     = true
  deep_check = false
  force      = false
}

And following hook configuration:

  - repo: git://github.com/antonbabenko/pre-commit-terraform
    rev: v1.21.0
    hooks:
      - id: terraform_fmt
      - id: terraform_validate
      - id: terraform_tflint
        args: [' --config .tflint.hcl']
      - id: terragrunt_fmt

Getting following errors:

/Users/user/.cache/pre-commit/repo31phc1no/terraform_tflint.sh: line 42: pushd --config .tflint.hcl modules/dynamodb-table/dynamodb-table.tf modules/dynamodb-table/dynamodb-table-outputs.tf modules/s3-state-bucket: No such file or directory

The hook terraform_docs_replace uses sed

The terraform_docs_replace hook uses sed, rather than taking care of the cleaning up of the document using native Python. Removing the dependency on sed will make this hook more platform agnostic.

Release new version

Hi @antonbabenko

When I run pre-commit I had this message:

[INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks.
updating v0.4.2 -> 46251c9523506b68419aefdf5ff6ff2fbc4506a4.
Updating git://github.com/antonbabenko/pre-commit-terraform...[INFO] Initializing environment for git://github.com/antonbabenko/pre-commit-terraform.
[WARNING] git://github.com/antonbabenko/pre-commit-terraform uses legacy hooks.yaml to provide hooks.
In newer versions, this file is called .pre-commit-hooks.yaml
This will work in this version of pre-commit but will be removed at a later time.
If `pre-commit autoupdate` does not silence this warning consider making an issue / pull request.
[INFO] Initializing environment for git://github.com/antonbabenko/pre-commit-terraform.
updating v1.0.0 -> b50c154638d10aef306b3c5538b1813bb3c70064.

I saw you created these days a .pre-commit-hooks.yaml to work with the new pre-commit version.

Is it possible to release it as the version 1.1 ?

tfvars files omitted from run

.tfvars files are skipped when the extension is set in .pre-commit-hooks.yaml

name: Terraform fmt
description: Rewrites all Terraform configuration files to a canonical format.
entry: terraform_fmt.sh
language: script
files: \.tfvars$

$ pre-commit run terraform_fmt

Terraform fmt........................................(no files to check)Skipped

New error coming from terraform_docs

You can see below.

pre-commit run -a
Check for merge conflicts................................................Passed
Trim Trailing Whitespace.................................................Passed
Check JSON...............................................................Passed
Check Yaml...............................................................Passed
Detect Private Key.......................................................Passed
Detect AWS Credentials...................................................Passed
Don't commit to branch...................................................Passed
Pretty format JSON.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
hookid: terraform_docs

2019/09/06 10:53:17 At 60:1: expected: IDENT | STRING | ASSIGN | LBRACE got: RBRACE

Non-executable shell script filename ends in .sh.........................Passed
Check shell style with shfmt.............................................Passed

Maybe being a bit more verbose? Though that looks like Terraform to me? HCL2 syntax?

pre-commit has changed from hooks.yaml -> .pre-commit-hooks.yaml

Hello pre-commit hook implementer!

In version 0.12.0 pre-commit has changed the default location for the file formerly known as hooks.yaml to make it more convincing for others to add more hooks.

As such, a migration has to (unfortunately) occur.

For maximum compatibility it is suggested to cp hooks.yaml .pre-commit-hooks.yaml (at least for the migration period). A copy is suggested over a symlink unless you do not care for windows compatibility (and I wouldn't blame you!).

Once the migration period is over (or you no longer care to support old versions of pre-commit), the hooks.yaml file is no longer necessary and may be deleted.

See pre-commit/pre-commit#470 for more details

Thanks again for contributing to the pre-commit ecosystem, we couldn't do it without you :)
Anthony

terraform_docs failing on presence of README.md past v1.7.3

Here is the simplest example I could make of the problem:

image

Here are some tests of various versions using a README.md with the begin/end tags.

image

Here, I drop back to v1.7.3 and I can get terraform_docs to work again:

image

Here, I bump to v1.7.4 and the problem returns:

image

I can repeat that with any version past v1.7.3. Here's v1.9.0:

image

Unfortunately, I'm not sure where these hook scripts are installed, otherwise I'd try tracking down the failure myself. I'm happy to dig further myself if you can point me to where the hooks are installed so I can modify them for debugging?

Failure on terraform 0.11.x

The terraform_docs plugin is failing on terraform 0.11.x.

$ pre-commit run -a terraform_docs
Terraform docs...........................................................Failed
- hook id: terraform_docs
- exit code: 1

It's caused by a combination of set -e and this line:

hack_terraform_docs=$(terraform version | head -1 | grep -c 0.12)

This exits with error code 1 on terraform 0.11.x, and the set -e causes the script to exit.

Working on a fix...

TFLint --deep argument

I'd like to see the tflint pre-commit script have --deep be an optional argument rather than the default. I believe --deep only works with AWS and causes issues if you attempt to run it for GCP or Azure infrastructure.

terraform fmt being run in .terraform dir

Not sure why yet but this hook runs in the .terraform dir for me but from the code it looks like that dir should be ignored?

I will investigate further and post an update.

terraform_docs_replace does not work in root directory

.pre-commit-config.yaml:

repos:
- repo: git://github.com/antonbabenko/pre-commit-terraform
  rev: v1.8.0
  hooks:
    - id: terraform_fmt
    - id: terraform_docs_replace
      args: ['--with-aggregate-type-defaults', '--sort-inputs-by-required']

There are *.tf and *.tfvars files in root and in directories.

README.md in directories is correct, but README.md in the root dir has this content:

Usage:
    terraform-docs [--no-required] [--no-sort | --sort-inputs-by-required] [--with-aggregate-type-defaults] [json | markdown | md] <path>...

PS: @RothAndrew could you please take a look and fix this.

terraform_docs hook requires GNU sed

I kept getting this error when trying to use the terraform_docs hook:

Terraform Docs...........................................................Failed
hookid: terraform_docs

sed: 1: "/BEGINNING OF PRE-COMMI ...": unexpected EOF (pending }'s)

Further inspection revealed this is a limitation of the BSD sed shipping with the latest macOS:

$ sed -i -n '/BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK/{p;:a;N;/END OF PRE-COMMIT-TERRAFORM DOCS HOOK/!ba;s/.*\n/I_WANT_TO_BE_REPLACED\n/};p' README.md
sed: 1: "/BEGINNING OF PRE-COMMI ...": unexpected EOF (pending }'s)

Running the same command using GNU sed (installed as gsed by Homebrew):

$ gsed -i -n '/BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK/{p;:a;N;/END OF PRE-COMMIT-TERRAFORM DOCS HOOK/!ba;s/.*\n/I_WANT_TO_BE_REPLACED\n/};p' README.md
$ cat README.md 
<!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
I_WANT_TO_BE_REPLACED
<!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->

terraform_docs with terraform 0.12 doesn't work with mawk

mawk (the default version of awk on Debian/Ubuntu) doesn't work with the terraform 0.12 awk script. gawk (and the awk in busybox) works fine. I'm not sure it's worth trying to figure out why and can probably be immediately closed.

Hopefully this note helps someone else who runs into the same thing

Using v1.19.0 of the terraform_docs hook.

With mawk

$ sudo update-alternatives --set awk /usr/bin/mawk
update-alternatives: using /usr/bin/mawk to provide /usr/bin/awk (awk) in manual mode

$ pre-commit run -a
Terraform docs...........................................................Failed
hookid: terraform_docs

Files were modified by this hook.

$ cat README.md 
<!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->

<!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->

With gawk

$ sudo update-alternatives --set awk /usr/bin/gawk
update-alternatives: using /usr/bin/gawk to provide /usr/bin/awk (awk) in manual mode

$ pre-commit run -a
Terraform docs...........................................................Failed
hookid: terraform_docs

Files were modified by this hook.

$ cat README.md 
<!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
## Inputs

| Name | Description | Type | Default | Required |
|------|-------------|:----:|:-----:|:-----:|
| test\_number |  | number | n/a | yes |
| test\_string |  | string | `"testing"` | no |

<!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->

failing hook leaves temp files in repo root

If temp files need to be a part of this hook, I'd suggest putting them in a standard tucked away temp file location on the system. Since you're using bash anyway, we can assume Windows isn't supported unless through WSL. Consider sticking temp files in /tmp/ and having some cleanup logic if the hook fails.

screen shot 2018-05-17 at 12 48 57 am

Support running executables via docker

Would it be possible to support running the docker versions of the executables?

i.e.
terraform -> docker run -i -t hashicorp/terraform:light
tflint -> docker run --rm -v $(pwd):/data -t wata727/tflint

terraform validate with / with out variable hooks not working.

Hello,

Frist, thank you so much for the shared pre-commit code. i am referencing this original repo in pre-config yaml but somehow both validation with / without variable ones are not working as expected. see below.

λ cat .pre-commit-config.yaml

- repo: git://github.com/antonbabenko/pre-commit-terraform
  rev: v1.7.3
  hooks:
    - id: terraform_fmt
    - id: terraform_validate_no_variables
    - id: terraform_validate_with_variables

λ pre-commit install
pre-commit installed at C:\Cloud\Github\pre-commit\tf-test3\tf-test3.git\hooks\pre-commit

λ git status
modified: main.tf

λcat main.tf

provider "aws" {}
resource "aws_s3_bucket_test1" "b" "e" "f" {
  bucket1                   = "my-tf-test-bucket-1"
  acl     = "private"
}
provider "aws" {}
resource "aws_s3_bucket_test2" "b" "c" "d" {
  bucket1 = "my-tf-test-bucket-2"
  acl                 = "private-public"
}

λ git commit -m "main.tf add"
Terraform fmt............................................................Failed
hookid: terraform_fmt

Files were modified by this hook. Additional output:
main.tf

Terraform validate without variables.....................................Passed
Terraform validate with variables........................................Passed

We can see here that fmt working as expected but somehow validation hooks are not catching the issues in main.tf file ( which shouldn't go through validation passed ).

Really appreciate help on this.

terraform_docs failing on complex types which contains "description"

How reproduce

Working code:

staged README.md

<!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->

<!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->

staged vars.tf

variable "ingress_cidr_blocks" {
  description = "Bzzzzz"
  type = list(
    object({
      # description = string
      cidr_blocks = string
      from_port   = number
      to_port     = number
      protocol    = string
    })
  )

  default = [
    {
      description = "SG"
      cidr_blocks = "10.0.0.0/32"
      from_port   = 22
      to_port     = 22
      protocol    = "tcp"
    },
  ]
}

provider "aws" {
  region = "eu-west-1"
}

If uncomment # description = string - terraform_docs failed:

Terraform docs...........................................................Failed
hookid: terraform_docs

2019/09/09 18:19:45 At 4:21: Unknown token: 4:21 IDENT string

Root case

Error happens because awk rewrite this type to next construction:

variable "ingress_cidr_blocks" {
  description = "Bzzzzz"
  type = "list("
      description = string
  default = [
    {
      description = "SG"
      cidr_blocks = "10.0.0.0/32"
      from_port   = 22
      to_port     = 22
      protocol    = "tcp"
    },
  ]
}

Suggestion

"type" need be rewrite to "multiline", but I spend about 2 hours on it and not get excepted result.
I made crutch that fix error, but it will be good have full value, as in "default" block.

Workaround

Just not specify description field in complex types.

Failed to read module directory

I had to upgrade terraform-docs because of issue with a null value in variables.tf
terraform-docs/terraform-docs#161
Now pre-commit complains about the directory.

Here is some information about the versions.
pre-commit-config.yaml

- repo: git://github.com/antonbabenko/pre-commit-terraform
  rev: v1.22.0
  hooks:
    - id: terraform_fmt
    - id: terraform_docs

run pre-commit run -a

pre-commit run -a
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
hookid: terraform_docs

2020/01/14 16:27:41 Failed to read module directory: Module directory /var/folders/_v/n250j8397bj273wj64d3rz180000gn/T//terraform-docs-TQYHbozJA7.tf does not exist or cannot be read.

terraform-docs version

terraform-docs version
terraform-docs version v0.8.0-rc.2 d52122d darwin/amd64 BuildDate: 2020-01-12T20:38:24+0000

mktemp illegal action

╭─ workpc ~/Projects/billing-pipeline-tf-module  ‹master*›                                                                   ╰─$ pre-commit run -a
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
hookid: terraform_docs

mktemp: illegal option -- -                                                                                                                             usage: mktemp [-d] [-q] [-t prefix] [-u] template ...
       mktemp [-d] [-q] [-u] -t prefix                                                                                                                  
╭─ workpc ~/Projects/billing-pipeline-tf-module  ‹master*›                                                                   ╰─$ cat .pre-commit-config.yaml                                                                                                                   127 ↵
- repo: git://github.com/antonbabenko/pre-commit-terraform
  rev: v1.14.0
  hooks:
    - id: terraform_fmt
    - id: terraform_docs

mktemp doesn't seem to be working on Mac.

terraform_docs fails to update README due to module directory failure

Hi all,

I'm running pre-commit run -a and the Terraform docs emits a Failure, but doesn't update the readme. I get an error that a module directory can't be found:

Terraform docs...........................................................Failed
- hook id: terraform_docs
- exit code: 1

2020/02/13 11:31:39 Failed to read module directory: Module directory /var/folders/nh/3_wcty396z3bqg1nsjxjmxqm0000gq/T//terraform-docs-CWUNv7Sw6d.tf does not exist or cannot be read.

And then the README won't update. I'm currently on this version:
pre-commit 2.0.1

And this is what my yaml file looks like:

- repo: git://github.com/antonbabenko/pre-commit-terraform
  rev: v1.21.0
  hooks:
    - id: terragrunt_fmt
    - id: terraform_fmt
    - id: terraform_docs
    - id: terraform_tflint
      exclude: ^test/

Validate without variables fails when there is a subfolder present with TF code

Hi
My modules contains examples/ folder with implementation example. After upgrade of pre-commit-terraform and my code to 0.12.x the validate without variables stopped working for subfolders complaining that module wasn't initialised but it actually was.

My hook config:

- repo: git://github.com/antonbabenko/pre-commit-terraform
  rev: v1.17.0
  hooks:
    - id: terraform_fmt
    - id: terraform_docs
    - id: terraform_validate

Error:
pre-commit run -a
Terraform fmt............................................................Passed
Terraform docs...........................................................Passed
Terraform validate without variables.....................................Failed
hookid: terraform_validate

Success! The configuration is valid.


Failed path: examples
================================

Error: Module not installed

  on examples/main.tf line 6:
   6: module "s3_bucket" {

This module is not yet installed. Run "terraform init" to install all modules
required by this configuration.

terraform-docs - not compatible with latest 0.12.6 changes for complex variable types

Here is the variable it hasn't been able to handle.

  type = list(object({
    name            = string
    category        = string
    owner           = string
    provider        = string
    version         = string
    input_artifacts = list(string)
  }))
  default = [{
    name            = "Apply"
    category        = "Build"
    owner           = "AWS"
    provider        = "CodeBuild"
    version         = "1"
    input_artifacts = ["Source"]
  }]
}

This is the output:

| stages |  | object | `[ { "category": "Build", "input_artifacts": [ "Source" ], "name": "Apply", "owner": "AWS", "provider": "CodeBuild", "version": "1" } ]` | no |

Validate & linting doesn't work for projects with sub-directories

I'm sad to be posting this because I've been struggling for days to get these simple pre-commit hooks to work. So far, the only one I've actually gotten functional is terraform_fmt. I'm aware of #59 but there's been no response there since October of 2019. Here are some details:

terraform_validate

Fails with several errors:

  • Error: Module not installed
  • Error: provider.aws: no suitable version installed
  • Error: Could not satisfy plugin requirements

All of these are basically indicating the same thing, init has not been run in the sub-directory. There are a few problems with this:

  1. init has indeed been run in each of these sub-directories but the pre-commit hook (or perhaps Terraform) doesn't seem to be aware
  2. Running terraform validate from the project root directory succeeds without error

What is the pre-commit hook doing that the CLI command isn't (or vice-versa)?

terraform_tflint

I see several variations of the following error:

  • ERROR: unable to resolve endpoint for service "ecs", region "", err: UnknownEndpointError: could not resolve endpoint (replace ecs with any other service we're using)
  • also: Error: An error occurred while invoking DescribeSecurityGroups; MissingRegion: could not find region configuration

Now, running tflint --deep --module returns one error (the first one detailed above) so this is also probably an issue with that tool but ... is no one else using sub-directories? I find that incredibly hard to believe.

So, in the end, the only pre-commit hook I've gotten to work is terraform_fmt. Kind of disappointing as I've been extolling the value of validating & linting but am unable to deliver a working MVP to prove it due to the above problems.

Has anyone experienced these pains? Are there any workarounds or fixes for the above issues? Any advice at all? Thanks for your time & effort.

terraform_lint doesn't correctly parse args

I've added the following to my pre-commit config:

repos:
  - repo: git://github.com/antonbabenko/pre-commit-terraform
    rev: v1.25.0
    hooks:
      - id: terraform_fmt
      - id: terraform_validate
      - id: terraform_tflint
        args: ['--deep']

but:

$ pre-commit run -a
Terraform fmt............................................................Passed
Terraform validate without variables.....................................Passed
Terraform validate with tflint...........................................Failed
- hook id: terraform_tflint
- exit code: 1

getopt: unrecognized option '--deep'
getopt: unrecognized option '--deep'
getopt: unrecognized option '--deep'
getopt: unrecognized option '--deep'
getopt: unrecognized option '--deep'
getopt: unrecognized option '--deep'
getopt: unrecognized option '--deep'
getopt: unrecognized option '--deep'

Terraform fmt fails when fixing a file

Hey guys,

running git commit -va give me this:

Terraform fmt............................................................Failed
- hook id: terraform_fmt
- files were modified by this hook

main.tf

Markdownlint.........................................(no files to check)Skipped
- repo: git://github.com/antonbabenko/pre-commit-terraform
  rev: v1.24.0 # Get the latest from: https://github.com/antonbabenko/pre-commit-terraform/releases
  hooks:
    - id: terraform_fmt
- repo: https://github.com/markdownlint/markdownlint
  rev: v0.8.0
  hooks:
    - id: markdownlint

we're having terraform dir in a mono-repo for now.

Terraform v0.12.19

Any ideas how to debug that?

terraform_docs hook throwing errors depending on terraform format.

Hi All,

I had this strange problem with the hook that it would throw me

Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
hookid: terraform_docs

2019/07/17 16:41:09 At 6:4: illegal char

Trying to debug it I checked the file on /tmp folder. Where I discovered which line was causing the problem.

...
     3	 }
     4	output "kubeconfig" {
     5	  description = "Kubernetes configuration file for kubectl"
     6	  })
     7	output "name" {
...

On the original terraform file this had been declared in the following manner

output "kubeconfig" {
  description = "Kubernetes configuration file for kubectl"
  value = templatefile("${path.module}/templates/kubeconfig.tpl", {
    cluster_name     = var.name
    cluster_endpoint = aws_eks_cluster.this.endpoint
    cluster_ca_data  = aws_eks_cluster.this.certificate_authority[0].data
  })
}

Changing this to

output "kubeconfig" {
  description = "Kubernetes configuration file for kubectl"
  value = templatefile("${path.module}/templates/kubeconfig.tpl",
    {
      cluster_name     = var.name
      cluster_endpoint = aws_eks_cluster.this.endpoint
      cluster_ca_data  = aws_eks_cluster.this.certificate_authority[0].data
    }
  )
}

solved the problem.

I'm running terraform >0.12.0 so I believe this may happen because of the terraform_0.12 hack.

terraform_docs failing on TF0.12

Hi,

This is connected to #45 that was fixed in v1.15.0. That version has fixed the issue i had with mktemp but i am getting a new error on this version:

$ pre-commit run terraform_docs -a
Terraform docs...........................................................Failed
hookid: terraform_docs

2019/06/19 10:45:22 At 62:1: expected: IDENT | STRING | ASSIGN | LBRACE got: RBRACE

But on another terraform config we have the error slightly differs:

$ pre-commit run terraform_docs -a
Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
Terraform docs...........................................................Failed
hookid: terraform_docs

2019/06/19 10:48:03 At 24:11: nested object expected: LBRACE got: ASSIGN

Both of these worked previously as they have fully populated README's. I would look into this further but not sure where the files are that the error location refers too (if you point me in the right direction i am more than happy to investigate)

Thanks,

Unclear on new terraform validate behaviour regarding variable checking

I can see that in the later versions of this project the two existing validate hooks have been reduced to one (terraform_validate_with_variables.sh and terraform_validate_no_variables.sh -> terraform_validate.sh)

The hooks file still suggests this single hook validates without checking variables:

- id: terraform_validate
name: Terraform validate without variables
description: Validates all Terraform configuration files.

But the script itself does not specify -check-variables and so seems to default to true, as per the docs:
https://www.terraform.io/docs/commands/validate.html#check-variables-true

if ! terraform validate $path_uniq; then

Please could you clarify the intended behaviour/reasoning behind dropping the option to not check variables? Would you accept a PR that re-introduced the option to skip the variable check without duplicating the script and creating a separate hook (e.g. allowing the hook to accept an argument to skip the checks).

Our project structure is such that some variables are only defined by external files, passed in via -var-file arguments to Terraform, and therefore do not validate successfully on their own

Many thanks

better handle missing dependancies

it's unclear from the documentation that various hooks don't work unless you install a separate tool into the path. It would be great to call this out on README. I was running terraform_docs_replace and it was just writing an empty file. I had to dive into the code to determine that it requires a separate install.

Does pre-commit not support a way to install the dependencies? Unfortunately, my team won't be able to use those hooks since it doesn't automatically install them.

terraform_validate hooks don't exit with non-zero status, never report failure

From the pre-commit docs for Creating New Hooks:

The hook must exit nonzero on failure or modify files in the working directory (since 0.6.3).

Neither of the validation hooks in this repo will exit with a non-zero status on failure. The if ! terraform validate command uses the non-zero exit code, and then moves on. The scripts will then reach end of file and exit 0.

Because they exit 0, pre-commit interprets that as Passed and suppresses all output. For my own project, I've enabled the verbose option so that its not a no-op.

if ! terraform validate -check-variables=false ; then

if ! terraform validate -check-variables=true ; then

Terraform_docs hook is not working with virtualbox shared folder

When virtualbox shared folder is hosted by Windows you get all limitations of Windows filesystems (can't rename or delete open file). terraform_docs.sh script is using perl's -i option which is not working with vboxsf mountpoints - in this case perl tries to delete open file. Perl options like -i.bak also won't help since perl will try to "rename" open file.

I tried sed and it's working fine with shared folders. Possible fix could be python-native, sed or something else.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.