Giter VIP home page Giter VIP logo

Comments (11)

james-gonzalez avatar james-gonzalez commented on July 18, 2024 1

I thought it might be related to the way I've mix/matched the variables syntax :P Let me refactor them.

from pre-commit-terraform.

antonbabenko avatar antonbabenko commented on July 18, 2024

Hi James!

Make sure that you are using Terraform version 0.12. The error you get is because code can't be processed by the hook. Unfortunately, it is pretty hard to make the output more verbose (and useful) because of the way the terraform-docs hack (see awk script) is working.

from pre-commit-terraform.

james-gonzalez avatar james-gonzalez commented on July 18, 2024

Hey Anton! Morning :) Hope you and your family are well.

Terraform v0.12.7

from pre-commit-terraform.

antonbabenko avatar antonbabenko commented on July 18, 2024

Ok, then verify that the terraform configs are valid.

Also, if you combine them in one file you will see the problem on line 60. It is likely a bug in awk script because of the way how you define variable block. If you can provide a problem piece of configuration somebody may take a look at awk and improve it.

from pre-commit-terraform.

james-gonzalez avatar james-gonzalez commented on July 18, 2024
- repo: https://github.com/antonbabenko/pre-commit-terraform
  rev: v1.19.0
  hooks:
    - id: terraform_fmt
    - id: terraform_docs
variable "ecs_name" {
  type        = "string"
  description = "Default name of the ECS cluster"
  default     = "default-cluster"
}

variable "region" {
  description = "region"
  type        = string
  default     = "us-east-2"
}

variable "s3_bucket_name" {
  default = "jamesg-data-test-bucket"
}

variable "bucket_access" {
}

variable "additional_user_data_script" {
  type        = "string"
  description = "extra stuff you want to put into your user-data.sh scripts"
  default     = "echo example ecs cluster being provisioned"
}

variable "ecs_env" {
  default = "development"
}

variable "ecr_repo_name" {
  description = "name of the ECR repo to create for the ECS setup"
  default     = "example-repo"
}

variable "task_definition_name" {
  description = "This must be a prefix to a file in templates/ matching the file name for your service cluster. i.e. slaf "
  default     = "default"
}

variable "container_name_lb" {
  description = "Name of the container which needs to be exposed via the ALB"
  default     = "default"
}

variable "vpc_id" {variable "ecs_name" {
  type        = "string"
  description = "Default name of the ECS cluster"
  default     = "default-cluster"
}

variable "region" {
  description = "region"
  type        = string
  default     = "us-east-2"
}

variable "s3_bucket_name" {
  default = "jamesg-data-test-bucket"
}

variable "bucket_access" {
}

variable "additional_user_data_script" {
  type        = "string"
  description = "extra stuff you want to put into your user-data.sh scripts"
  default     = "echo example ecs cluster being provisioned"
}

variable "ecs_env" {
  default = "development"
}

variable "ecr_repo_name" {
  description = "name of the ECR repo to create for the ECS setup"
  default     = "example-repo"
}

variable "task_definition_name" {
  description = "This must be a prefix to a file in templates/ matching the file name for your service cluster. i.e. slaf "
  default     = "default"
}

variable "container_name_lb" {
  description = "Name of the container which needs to be exposed via the ALB"
  default     = "default"
}

variable "vpc_id" {
  default = ""
}

variable "docdb_cluster_master_password" {
  default = ""
}

variable "azure_credentials_arn" {
  default = ""
}

variable "docdb_endpoint" {
  default = ""
}

variable "account" {}

variable "template_folder" {
  default = "task-definitions"
}

variable "docdb_password" {
  default = ""
}

variable "task_definition_file" {
  default = ""
}

  default = ""
}

variable "docdb_cluster_master_password" {
  default = ""
}

variable "azure_credentials_arn" {
  default = ""
}

variable "docdb_endpoint" {
  default = ""
}

variable "account" {}

variable "template_folder" {
  default = "task-definitions"
}

variable "docdb_password" {
  default = ""
}

variable "task_definition_file" {
  default = ""
}

from pre-commit-terraform.

james-gonzalez avatar james-gonzalez commented on July 18, 2024

This was the fix, I think this should be classed as a bug.

variable "account" {}

to

variable "account" {
}

from pre-commit-terraform.

antonbabenko avatar antonbabenko commented on July 18, 2024

Yes, this is definitely a bug which @cytopia may know about.

Btw big kudos to @cytopia for making an awk script we are using in this repo!

from pre-commit-terraform.

cytopia avatar cytopia commented on July 18, 2024

Yes, this is definitely a bug which @cytopia may know about.

I'll have a look into this

Btw big kudos to @cytopia for making an awk script we are using in this repo!

For credits: The script was originally created by @osterman here

from pre-commit-terraform.

cytopia avatar cytopia commented on July 18, 2024

@james-gonzalez if this is about:

variable "account" {}

then it should get fixed here: #65

from pre-commit-terraform.

konstantin-recurly avatar konstantin-recurly commented on July 18, 2024

Is this one still relevant?
It seems that this one could be resolved as well.
@james-gonzalez Would you, please, check if this still fails for you with the latest release and the latest terraform-docs.

from pre-commit-terraform.

antonbabenko avatar antonbabenko commented on July 18, 2024

It is safe to close a long time ago.

from pre-commit-terraform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.