Comments (6)
Hi Christopher,
There can be a way to verify that dependencies are installed, but it will make invocation much slower.
I agree we could make README more complete and describe dependencies more accurately. Pull request and ideas are welcome.
from pre-commit-terraform.
This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days
from pre-commit-terraform.
Not sure if this was discussed in a different issue, but I see that some other hooks ship with dependencies, or download them if missing (not sure which); what if pre-commit-terraform did so with it's dependencies?
The specific problem we're running into is that our pre-commit.ci run is failing due to Terraform not being installed in the runner.
Note this would also make installation easier for those that might not have Terraform installed (#445), such as a monorepo where Terraform is mixed with app code, worked on by different people.
Thanks!
from pre-commit-terraform.
@afeld that's not possible to do natively via pre-commit, check pre-commit/pre-commit#1453
from pre-commit-terraform.
I forked the shellcheck-py approach and did the exact same for terraform: https://github.com/yuvipanda/terraform-bin. It's not published on PyPI, but this approach works fine for pre-commit.ci!
I currently have a pre-commit-hooks.yaml file setup on that repo so it is used directly. However, if possible, perhaps it could be made a dependency of this repo, so I could use this repo instead? This way, it would work fine on pre-commit.ci without any issues as well :) Am happy to transfer ownership, etc as needed too.
from pre-commit-terraform.
@yuvipanda if you'd like to talk about this - please open a new issue.
You're the first folk on my way who use pre-commit.ci
, when they can be run in the company's CIs or as GitHub workflow. Also, 100 users are a quite low limit.
So, I don't think that supporting a solution that will work only with this CI is worth anything.
If it can run not only in pre-commit.ci
, then it relates to #418 a little bit.
from pre-commit-terraform.
Related Issues (20)
- [trivy always recursive] terraform_trivy not excluding paths HOT 4
- [fedora, grep 3.8] grep: warning: stray \ before / HOT 4
- Custom Docker image - Pre-install pre-commit hooks inside image HOT 6
- mapfile: command not found in zsh HOT 4
- Add `terragrunt_providers_lock` hook HOT 11
- terraform_checkov hook fails in Docker container since version v1.83.5 HOT 5
- Checkov install silently fails during image build (and is also missing when pulling from ghcr.io) HOT 4
- Bash environment variable expansion not working for trivy HOT 26
- Provide non-root docker build HOT 4
- terraform validate: Force rerun `t init` when plugin cache is enabled and parrallelism conflit happens HOT 8
- Ability to use terraform_plan framework of checkov HOT 8
- [trivy/pre-commit] Terraform trivy configuration excludes .trivyignore files, forcing repetitive ignore statements HOT 7
- Windows Support / Rewrite hooks to Python HOT 11
- Quotation Marks in Environment Variables HOT 2
- Get docker image running in github action HOT 10
- [tf aws provider version] terraform_validate false negative on `aws_kinesis_firehose_delivery_stream.extended_s3_configuration.file_extension` HOT 3
- Add PATH to terraform_docs HOT 7
- [terraform outdated provider] New Data Source: aws_ecr_lifecycle_policy_document HOT 4
- Remove Political Banners from Repo
- [`trivy:ignore:` usage] Terraform Security Check AVD-AWS-0342 HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pre-commit-terraform.