Comments (9)
In an interesting twist the following seems work:
- id: terraform_docs
args: [--args=--with-aggregate-type-defaults, --args=--no-escape]
from pre-commit-terraform.
As @Vlaaaaaaad is saying but enquote values to be like strings. Like this:
- id: terraform_docs
args: ["--args=--sort-by-required", "--args=--with-aggregate-type-defaults", "--args=--no-escape"]
from pre-commit-terraform.
Agree, we can update README to show the examples for both.
from pre-commit-terraform.
To make it work you need two things:
-
Following PR merged into master and new version released (or have your own fork): #77
-
One of the latest PRs merged to the mainline changed the way of passing arguments to the tflint.
I have no clue how this is working for anyone: https://github.com/antonbabenko/pre-commit-terraform#notes-about-terraform_tflint-hooks
- id: terraform_tflint
args: ['--deep']
Maybe I'm missing something important. Per the code in the the script and according to the way how pre-commit passes arguments to the scripts (https://pre-commit.com/#passing-arguments-to-hooks), the only solution which I see is this:
- id: terraform_tflint
args: ['--args', '--module']
from pre-commit-terraform.
Yea, this is busted for me too. Tried with a different module just to make sure and it also fails
hooks:
#- id: terraform_tflint
#args: ['--aws-region=us-west-2']
# - id: terraform_fmt
- id: terraform_docs
args: ['--dest=TEST.md']
Terraform docs...........................................................Failed
- hook id: terraform_docs
- exit code: 1
getopt: unrecognized option '--dest'
from pre-commit-terraform.
The story is the same for both terraform_docs and terraform_tflint as they use the same method of sorting out arguments (getopt) which is making handling arguments in specific way.
from pre-commit-terraform.
Same here with terraform_docs
hook, even in the newest version. Not too familiar with pre-commit or getopt, but with adding
- id: terraform_docs
args: ['--args=--sort-by-required']
it works. However I can't seem to add more args, and this seems like a very bad workaround.
Any thoughts @antonbabenko?
from pre-commit-terraform.
OK, that seems to be working. Would be nice for it to be consistent with other pre-commit hook args (as the README indicates).
from pre-commit-terraform.
v1.25.0 of pre-commit-terraform
has been just released after #77 was merged which means that terraform_tflint
is usable.
Closing this issue.
from pre-commit-terraform.
Related Issues (20)
- Add `terragrunt_providers_lock` hook HOT 11
- terraform_checkov hook fails in Docker container since version v1.83.5 HOT 5
- Checkov install silently fails during image build (and is also missing when pulling from ghcr.io) HOT 4
- Bash environment variable expansion not working for trivy HOT 26
- Provide non-root docker build HOT 4
- terraform validate: Force rerun `t init` when plugin cache is enabled and parrallelism conflit happens HOT 8
- Ability to use terraform_plan framework of checkov HOT 8
- [trivy/pre-commit] Terraform trivy configuration excludes .trivyignore files, forcing repetitive ignore statements HOT 7
- Windows Support / Rewrite hooks to Python HOT 11
- Quotation Marks in Environment Variables HOT 2
- Get docker image running in github action HOT 10
- [tf aws provider version] terraform_validate false negative on `aws_kinesis_firehose_delivery_stream.extended_s3_configuration.file_extension` HOT 3
- Add PATH to terraform_docs HOT 7
- [terraform outdated provider] New Data Source: aws_ecr_lifecycle_policy_document HOT 4
- Remove Political Banners from Repo
- [`trivy:ignore:` usage] Terraform Security Check AVD-AWS-0342 HOT 9
- Terragrunt validate-inputs hook? HOT 7
- Validate failing to upgrade lock file locally on version change HOT 3
- Intermittently "no such file or directory" error seen when using trivy pre-commit hook HOT 9
- [misspell in `--hook-config` option] terraform_docs hook fails to detect out-of-date document HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pre-commit-terraform.