Can't use arguments for module inspection about pre-commit-terraform HOT 9 CLOSED

In an interesting twist the following seems work:

    - id: terraform_docs
      args: [--args=--with-aggregate-type-defaults, --args=--no-escape]

from pre-commit-terraform.

As @Vlaaaaaaad is saying but enquote values to be like strings. Like this:

    - id: terraform_docs
      args: ["--args=--sort-by-required", "--args=--with-aggregate-type-defaults", "--args=--no-escape"]

from pre-commit-terraform.

Agree, we can update README to show the examples for both.

from pre-commit-terraform.

To make it work you need two things:

1. Following PR merged into master and new version released (or have your own fork): #77

2. One of the latest PRs merged to the mainline changed the way of passing arguments to the tflint.

I have no clue how this is working for anyone: https://github.com/antonbabenko/pre-commit-terraform#notes-about-terraform_tflint-hooks

  - id: terraform_tflint
    args: ['--deep']

Maybe I'm missing something important. Per the code in the the script and according to the way how pre-commit passes arguments to the scripts (https://pre-commit.com/#passing-arguments-to-hooks), the only solution which I see is this:

  - id: terraform_tflint
    args: ['--args', '--module']

from pre-commit-terraform.

Yea, this is busted for me too. Tried with a different module just to make sure and it also fails

  hooks:
          #- id: terraform_tflint
          #args: ['--aws-region=us-west-2']     
          #    - id: terraform_fmt
    - id: terraform_docs
      args: ['--dest=TEST.md']

Terraform docs...........................................................Failed
- hook id: terraform_docs
- exit code: 1

getopt: unrecognized option '--dest'

from pre-commit-terraform.

The story is the same for both terraform_docs and terraform_tflint as they use the same method of sorting out arguments (getopt) which is making handling arguments in specific way.

from pre-commit-terraform.

Same here with terraform_docs hook, even in the newest version. Not too familiar with pre-commit or getopt, but with adding

    - id: terraform_docs
      args: ['--args=--sort-by-required']

it works. However I can't seem to add more args, and this seems like a very bad workaround.

Any thoughts @antonbabenko?

from pre-commit-terraform.

OK, that seems to be working. Would be nice for it to be consistent with other pre-commit hook args (as the README indicates).

from pre-commit-terraform.

v1.25.0 of pre-commit-terraform has been just released after #77 was merged which means that terraform_tflint is usable.

Closing this issue.

from pre-commit-terraform.