Fails on earlier PostgreSQLs about postgresql HOT 12 CLOSED

@scottanderson42 this seems like a good time to fork and adjust your own copy to taste. Not sure it makes sense to generate configurations for older versions of the software, but that may just be me?

from postgresql.

It seems to me that one could use Ansible's version_compare() filter in the postgresql.conf.j2 template and conditionally not put the offending configuration directives for older versions of PostgreSQL.

http://docs.ansible.com/playbooks_variables.html#version-comparison-filters

from postgresql.

Always an option, sure. There's a cost/benefit tradeoff in that, though, plus more permutations to test and verify going forward. Just thought I'd chime in on a months old issue is all.

from postgresql.

If Ansible is used to bootstrap a system that's ok to forget old versions of PostgreSQL. But if playbooks are run from time to time on hosts running different versions of Pg, this is nice to support at least the last versions. A workaround would be to checkout this role several times on different commits following the versions we need to support... but it's a bit ugly, I think.

from postgresql.

@rud since there's a "version" option, users expect several versions to be installable. If only some versions are, it must be clear and not fail with an obscure error message.

@sebalix there are still enough servers deployed in production with older versions to make it a valid use case IMHO. When an old PG is part of a officially supported stack (ie. Odoo v7 officially targets PG 9.1) and PG works well enough, operators will be reluctant to upgrade.

from postgresql.

We are in the same case, we manage PostgreSQL from version 9.1 to 9.4 (and some 8.X too, but it's not a problem if we don't support them via Ansible).

from postgresql.

Just starting out with this recipe and PostgreSQL 9.2, LOG: unrecognized configuration parameter "unix_socket_directories" in file "/etc/postgresql/9.2/main/postgresql.conf" line 57 etc ...

from postgresql.

I think a PR to fix this is welcome 🌟

from postgresql.

We would almost certainly merge an PR around a good implementation of this fix, such as is being discussed.

from postgresql.

It has already be done for PostgreSQL 9.3 and 9.4: #66
We just need to add postgresql.conf files related to the 9.2 version and update available options:

• add the upstream postgresql.conf-9.2.orig (from the Debian package for instance)
• make a diff between the 9.3.orig and 9.2.orig
• copy postgresql.conf-9.3.j2 to postgresql.conf-9.2.j2 and adapt it following the previous diff
• update default/main.yml
• update .travis.yml to test this version

I can do it if you want.

from postgresql.

I started to work on the support of 9.1 and 9.2 versions. There is some conflicts with the PostgreSQL pre-installed by Travis, I try to fix them and I will make a PR.

from postgresql.

@sebalix Thanks man!

from postgresql.