Limited functionality for context manager about python-seabreeze HOT 2 CLOSED

Hi Dave,

thanks for contributing!

The reason I added the context managers like this, was just so I could use a with statement instead of a try...finally block around the global measurement logic and guarantee that the spectrometer is closed. I am not entirely sure if opening and closing the spectrometer connection for every measurement will work, because Spectrometer._open_device() calls lib.device_open(self._dev) which does some spectrometer initialization. (I do believe the initialization is a no-op in cseabreeze for most spectrometers, but I think not for all)

(In the pyseabreeze case it resets the usb connection, which might not be desirable while you run your experiment)

So what I am actually saying is:
If you go ahead with implementing the change and submitting a pull request, we should wait with merging it into master until we can confirm correct operation for a few different spectrometer models and operating systems.

I can test a USB2000+ and a Spark under Linux, Windows and OSX with both backends.

Thanks,
-Andreas

from python-seabreeze.

I'm closing this issue since automatic closing of spectrometers is quite a bit improved and the contextmanager fuinctionality will be removed with v2.0

from python-seabreeze.