apa512 / rethinkdb-protobuf Goto Github PK

It could be nice to have the version of this library match the latest protobuf version so it's clear there is a one to one mapping between the two. Then when you see this library as a dependency you know exactly which protobuf version you're pulling in.

It looks a little bit odd that the generated class doesn't have a Java package and is just a bare class. While I can't think of any problems of doing this in Clojure, it's generally not good to do this. This would also make this class reusable for other Java libraries. One possibility is to do what this Java driver did and add a package declaration to the proto file: https://github.com/npiv/rethink-java-driver/blob/master/src/main/proto/q2l.proto#L1

I'm not an expert on protocol buffers and haven't looked too deeply into lein-protobuf to see what the options are there or how other people do it. What are your thoughts?