apauzies / eclipse-minimap-view Goto Github PK

Eclipse Version: Indigo Service Release 2
Build id: 20120216-1857

We can click on the minimap to jump to points in the file, but there's no way to scroll it. What's more, it's impossible to get to the bottom of the minimap if it's longer than the view size.

Eclipse Version: Indigo Service Release 2
Build id: 20120216-1857

This plugin is a great start! Just wanna toss in a few "critical" feature tickets. :)

First, the minimap needs to scroll in sync with the main editor, highlighting the visible region.

MiniMap throws an NPE in Kepler:

eclipse.buildId=4.3.0.I20130605-2000
java.version=1.6.0_45
java.vendor=Sun Microsystems Inc.
BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=de_DE
Framework arguments: -product org.eclipse.epp.package.jee.product
Command-line arguments: -os win32 -ws win32 -arch x86_64 -product org.eclipse.epp.package.jee.product

Error
Thu Aug 01 10:20:56 CEST 2013
Unhandled event loop exception

java.lang.NullPointerException
at com.pauzies.minimap.views.MiniMapView.changeEditor(MiniMapView.java:86)
at com.pauzies.minimap.views.MiniMapView.access$0(MiniMapView.java:82)
at com.pauzies.minimap.views.MiniMapView$1.mouseUp(MiniMapView.java:98)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:220)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1057)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4170)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3759)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1113)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:997)
at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:138)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:610)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:567)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
at org.eclipse.equinox.launcher.Main.run(Main.java:1450)

When there are folded sections of code or comments the mini map gets off by the number of folded lines.

I can produce a video of the problem if helpful.

I know, this is an obvious one and already noted in the readme. Still had to add it here ;-))

Can you update the documentation with instructions on how to test and use this plugin.

I used the Version: 3.5.2 of Eclipse
I put the folder /plugins containing the .jar (com.pauzies.minimap_1.0.0.201301120125.jar) in my eclipse dropin directory
Then, I restarted eclipse
I can't find minimap in the available view

Until the entire first pagefull of code is off the screen, the minimap highlight region does not update. After this happens it updates correctly until the very top of the file is touched again after which the same effect occurs.

I can provide a video if it is helpful.

Both scrolling down in the code view and the minimap - whether by mousewheel or dragging the mouse - leaves the highlight in place if the file is short (less than 100 lines for me). Only moving the text cursor reliably updates the minimap highlight down.

My guess is that this is related to 100 lines not filling an entire second screen. With longer files, I see a similar lag until I scroll beyond the first "page break".