Comments (2)
Looks like it's because the PID search isn't very bulletproof. If my working folder contains string dredd-hooks
, then any running process will be matched and killed.
$ ps axu | grep 'dredd-hooks' | grep ruby
honzajavorek 43086 100.0 0.1 2471588 16520 s003 R+ 3:39PM 4:40.68 ruby /Users/honzajavorek/Workspace/dredd-hooks-ruby/bin/dredd-hooks-ruby
honzajavorek 43036 0.0 0.2 2483232 30648 s003 S+ 3:39PM 0:00.66 ruby /Users/honzajavorek/Workspace/dredd-hooks-ruby/vendor/bundle/ruby/2.0.0/bin/cucumber
Workaround:
puts "Killing server..."
system "for i in `ps axu | grep 'server.rb' | grep ruby | awk '{print $2}'`; do kill -9 $i; done > /dev/null 2>&1"
puts "Killing handler..."
system "for i in `ps axu | grep 'dredd-hooks' | grep -v 'cucumber' | grep ruby | awk '{print $2}'`; do kill -9 $i; done > /dev/null 2>&1"
(See the grep -v 'cucumber'
I added.) With such fix the tests run and pass correctly.
from dredd-hooks-template.
🎉 This issue has been resolved in version 1.0.0 🎉
The release is available on:
Your semantic-release bot 📦🚀
from dredd-hooks-template.
Related Issues (18)
- Tests do not validate hooks can listen on different ports HOT 3
- Update all existing hook repos with the latest changes in this template HOT 10
- Document a process for updating this repo & propagating changes to all hook handlers HOT 1
- Don't use `@debug` in test HOT 2
- CLI HOT 2
- Windows support HOT 1
- Dredd should pass list of hook files resolved
- Rewrite the template to Node.js HOT 1
- Do not rely on global installed dredd HOT 1
- Do not assume my hook handler is installed as global executable HOT 4
- Test the 'upgrade' CLI command HOT 1
- Be explicit about Dredd path? HOT 1
- Change the placeholder for the hooks handler executable HOT 1
- Cucumber tests assume that TCP server will emit a "Starting" message on stdout HOT 2
- Simplify server steps HOT 1
- Add a feature which requires hooks handler to react to SIGTERM
- Aruba needs to be upgraded HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dredd-hooks-template.