Giter VIP home page Giter VIP logo

Comments (8)

alessbell avatar alessbell commented on May 26, 2024 5

Hi all 👋 This regression is related to the bug fix in #11202. We're looking into it and should have an update soon, thanks for your patience.

from apollo-client.

alessbell avatar alessbell commented on May 26, 2024 2

@bengry yes, I can view it now. I'll need to dig into this a bit more and I'm nearing the end of my day, but will take a look as soon as I can. Thanks!

from apollo-client.

varbrad avatar varbrad commented on May 26, 2024 2

Just adding a comment here to say we're experiencing the same issue, it appears our defined typePolicies are being ignored and certain types we do not wish to normalise are being erroneously included in the cache, which then breaks several things across our tests and application, and leads to the same behaviour as seen above.

For example, we have a query that returns something similar to the below;

query TermsAndConditions {
  xyz {
    hasSignedTerms
  }
}

Where xyz: XYZ and type XYZ { hasSignedTerms: Boolean! }

Unfortunately the xyz type (obfuscated here) has no identifying label/id we can use, so we employ a strategy whereby it's type is given a keyFields: false value.

In 3.8 this would always mean the data property would return { __typename: 'XYZ', hasSignedTerms: true/false } whereas within 3.9 we are seeing frequent returns of { __typename: 'XYZ' } with the hasSignedTerms property being omitted entirely (which then breaks things as our TS types assume it always exists, etc.).

from apollo-client.

eltonio450 avatar eltonio450 commented on May 26, 2024 2

I think the same happens with empty lists

from apollo-client.

alessbell avatar alessbell commented on May 26, 2024 2

The fix will go out in a next patch release in the next day or two - I've tested snapshot release 0.0.0-pr-11576-20240206204955 with your sandbox @bengry and the bug no longer occurs. Thank you for reporting this issue!

from apollo-client.

alessbell avatar alessbell commented on May 26, 2024

Hi @bengry 👋 Thanks for providing the reproduction - unfortunately I'm not able to access it:

CleanShot 2024-02-01 at 15 25 25

Would you mind checking that it's shared publicly (assuming that was your intent)? Thanks!

from apollo-client.

bengry avatar bengry commented on May 26, 2024

Hi @bengry 👋 Thanks for providing the reproduction - unfortunately I'm not able to access it:

Would you mind checking that it's shared publicly (assuming that was your intent)? Thanks!

Woops, try again now please

from apollo-client.

github-actions avatar github-actions commented on May 26, 2024

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Client usage and allow us to serve you better.

from apollo-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.