Potentially unintentionally large AoE breaking changing to typescript `MockedResponse` in type 3.9 about apollo-client HOT 4 CLOSED

Yeah, unfortunately TVariables is used in a contravariant position here, which forces the variance of the generic argument to in out.

Generally: while we try to guarantee "no breaking changes" for runtime code, that is not true for TypeScript annotations - sometimes we just have to break a type's behaviour to enable an improvement in developer experience in the long term. But of course, we try to keep these changes to a minimum.

The change here is hard to avoid, and using any as a generic argument default is a solution we really want to try to avoid.
any is a great tool when used deliberately (and while it should be used sparingly, you probably shouldn't lint against it), but it should be deliberately used in userland code, not as a default.

I'm investigating a few unorthodox solutions for this (see this tweet, but I can't guarantee that anyone will come out of it.

In the meantime, can I suggest that you use a helper type like

type MockedResponseArray = ReadonlyArray<MockedResponse<Record<string, any>, any>>

?

That way you introduce any only in one place in your codebase.

from apollo-client.

Could you please try #11848 and report back if that works for you?

npm i @apollo/[email protected]

from apollo-client.

Could you please try #11848 and report back if that works for you?

npm i @apollo/[email protected]

@phryneas

This appears to work!

from apollo-client.

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Client usage and allow us to serve you better.

from apollo-client.