[apollo-datasource-rest] Content-type: application/json not added when body is string about datasource-rest HOT 2 CLOSED

Hey @rjoaopereira, sorry for the delay in responding to this.

Can you help me understand what you're trying to do that this behavior is breaking?

• Do you want to set a body as a plain text (double-quote escaped?) string and have us still set the application/json header since it's valid JSON?
• Are you trying to pass in already stringified JSON as the body and have us recognize that and set the header?

For 1: I'm not sure I see the value, but if this is your use case I'm interested to hear about it. Why is it useful to set that header?
For 2: I think this adds a fair amount of overhead to look at every string body, try and parse it, then assign the header if it succeeds (unless there's a better, faster way to detect valid JSON). Would parsing the object in the resolver or in the fails() function be reasonable?

This can be worked around right now (in the v3 version) by using the willSendRequest hook to inspect the body and set the header yourself if you choose to do that. Unfortunately this can't be done in v4 yet due to a separate issue (which I have a PR open for).

from datasource-rest.

We think this is working as intended. Happy to discuss further.

from datasource-rest.