apolopena / express-react-starter Goto Github PK

Problem this feature will solve

Currently hot reload only works on port 3000 and not on port 7777

Hot reload works when the react client is using the CRA dev server but doesnt work when the client is plugged into the actual Express server (such as on port 7777)

Background

Proposed Solution

Implment a hot reload system for the port that the Express server is running. By default this is 7777

Constraints and Assumptions

<! -- Any constraints and/or assumption relevant for the development and use of this feature? -->

Alternatives or Workarounds

Assuming you are using the default Express Server port 7777:

1. Save changes in a .tsx src file
2. Rebuild files: In /client run: yarn run build
3. Refresh the preview browser for port 7777 by clicking the button or running: op -7777 from the project root.

Additional context

Add any other context or screenshots about the feature request here.

Describe the bug

This project wont build on gitpod. It fails during the image build step

Screenshots

Steps to reproduce

create a new workspace from this repo

Expected behavior

workspace should build on Gitpod

Additional information

This project was build on a gitpod-laravel-start version less that 1.4 so that is why it is broken. gitpod-laravel-starter versions less than 1.4 all broke because they did not support php version changes in the underlying gitpod workspace image, mostly due to the implmentation of xdebug.

Since this project uses a subset of gitpod-laravel-starter the fix involves a bit of surgery to pluck the relevant parts from v1.4 and put them into this project.

In the fututre I will figure out a cleaner way to update the 'gitpod-starter' framework.

The CHANGELOG and README point to gitpod-laravel-starter 1.3 for the Gitpod integration core files.
this is not true, actually its a subset of gitpod-laravel-starter v1.4

Update the meta files to describe this.

Fix this: