Giter VIP home page Giter VIP logo

kliva's People

Contributors

aalok05 avatar bartlannoeye avatar depechie avatar jasteratmicrosoft avatar pieeatingninjas avatar punker76 avatar timheuer avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

kliva's Issues

Add activity picture upload

I stopped during my ride today for a nice picture .. but neither Kliva or the Strava site currently support uploading a picture ... ๐Ÿ˜ž

Defer load Pivot items that are not always going to be used

For views that you may not need a PivotItem for, they should be marked for defer loading and then un-deferred when needed. something like:

<Pivot>
  <PivotItem Header="Item 1" />
  <PivotItem Header="Item 2" x:DeferLoadStrategy="Lazy" x:Name="UnusedPivot" />
  <PivotItem Header="Item 3" />
</Pivot>

then code:

if (UnusedPivot == null) {
  FindName("UnusedPivot");
}
UnusedPivot.Visibility = Visibility.Visible;

Good pattern to use for items that may not always be visible in the UI.

Missing API call - Get related activities

To show the list of athletes that participated in a given activity we need to query for all related activities based upon the activity id of a selected activity.

In the WinRT 8.1 app the API call for this is: string.Format("{0}/{1}/related{2}", Constants.STRAVA_ACTIVITY_ENDPOINT, id,...

But it seems this is missing from StravaDotNet.
So we need to add it in Kliva

Loading activities with saved filter settings

When you select 'my activities' as active filter and close / reopen the app, you'll get the activity feed of 'my activities'.

But the filter selection on top will not show this, it will point to Show all activities.

Secondly, loading saved activities through this, will no longer show athlete avatars?

screenshot 31

bug in CachedKeyedIncrementalLoadingbase.LoadNewData

The timestamp = await LocalCacheService.getCacheTimestamp(name); line needs to be moved out of the if (!_hasLoaded) block, so that the cache time is checked on refresh operations.

I removed my fork to get rid of the bad history, so I don't have a place to check in.

Provide 'empty' Activity detail screen

Right now the Activity detail screen already has the text controls set for all the statistics, without an activity being selected. This looks rather odd, but an empty screen isn't perfect either as this doesn't invite to select an activity.

A possible solution would be to show a blurred detail screen to invite the selection of an activity. Issue: this can't be an image if we want it to scale perfect to the real screen on each device.

image

Eliminate calls to Photos API if not current user

Since the APIv3 does not allow retrieving photos for any athlete, the GetPhotos shouldn't be called unless that user. The API does tell you for ANY activity how many photos, but the check for the count is presently insufficient if you can't enumerate them. So right now an unnecessary call is being made to the API which will always return an empty array.

Adjust margin height of pivot items

Followers list on profile page and Kudos/Comments list on Activity detail have different top margin in reference to pivot headers
Also check Top athletes on segment detail

Different format for times on user statistics

Hi,

on the user stats page it displays total times in dd:hh:mm format. So if I cycled for 30 hours it will show 1:06:00, which is basically quite confusing as it could also mean 1 hour and 6 minutes.

Maybe you should "humanize" these values with a postfix, like 4d 10h 3m which is obvious and easy to understand.

Thx!

Inactive titlebar color

Do we need to change the inactive titlebar color? Verify what the default color is and change if needed...

titleBar.InactiveBackgroundColor = titleBar.BackgroundColor = Windows.UI.Colors.Black;
titleBar.InactiveForegroundColor = titleBar.ForegroundColor = Windows.UI.Colors.White;
titleBar.ButtonInactiveBackgroundColor = titleBar.ButtonBackgroundColor = Windows.UI.Colors.Black;
titleBar.ButtonInactiveForegroundColor = titleBar.ButtonForegroundColor = Windows.UI.Colors.White

Strava login issues

We've experienced several users having issues logging in to Strava. There are several possible reasons, sometimes it just worked by retrying to log in. We've also received following feedback from a user:

Regarding the issue that I was having with kliva I found that I could resolve it by matching my language and region on my phone. If I have my phone and English and the region as Mexico it does not let me log in which I suppose is related to the strava API.

Improve navigation flow

Add an icon to view switcher for activity view
Fix navigation to what Jake is doing in his sample
Build empty views on view switcher hook up switching

Photo count mismatch agains Photos.Count

When requesting Activities we currently don't get full detailed information.
Meaning that the Photo property isn't filled in, so we validate if we need to retrieve extra photo data by checking the photo_count field.
Seems that Strava isn't fail prove on this! When we get photos that aren't stored on Instagram the photo_count field will show 0 even though that when we request the photo data, we get Photos.Count that is higher than 0.

We need to check if we can circumvent this problem somehow

Add caching to API calls

Strava api calls are limited in time

  • In memory vs on disk (eg Akavache)
  • Different timespans as some endpoints expire faster (eg kudos/comments)

Settings options for Kliva

We still need to expand the use of our Settings class, we'll add a feture list here as reference what's todo and what's done.

  • Keep track of the last selected Activity feed filter
  • Have a sorting option for Activity feed, ordered on activity start datetime or activity end datetime
  • Let user decide what metric unit he prefers

Landscape orientation on phone

Some pages have issues when rendered in landscape mode on a windows 10 phone.
For example the activity detail page, you are unable to view / scroll through the statistics in a good way.

I would rather suggest to block landscape mode, most of the layout is designed with portrait in mind.

Pivot not receiving swipe events

When on mobile on the activity detail screen, the pivot will not react to swipe gestures when there is no content below the pivot header.

Example, when there are no kudos or comments given, you can't swipe from the Kudos pivot to the Comments pivot. Only way to do the swipe is by selecting the pivot header.

Activities out of order

The current cache returns activities out of order compared to the site (but in correct timestamp order according to timezones):
App
image

Site
image

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.