appgeist / restful-next-api Goto Github PK

The default logging of unknown errors could be improved here: https://github.com/appgeist/restful-next-api/blob/master/defaultErrorHandler.js#L16

• It should use console.error so that errors are printed to process.stderr.
• It doesn't print other error properties, just the stack. In some cases, errors contain other useful properties such as details or code (e.g.: most of Node.js errors have a code property).

My proposal is to change that line to:

console.error(util.inspect(err, false, 5));

...so that errors are printed to stderr as well as error properties.

While http-status-codes is used internally to get the error messages, as I user I can use or not use http-status-codes in my code, e.g.:

throw new ApiError(403);  // instead of throw new ApiError(FORBIDDEN);

Because of that, I would say to make it a dependency instead of a peer-dependency. However, the examples can still use http-status-codes for best practices.