Giter VIP home page Giter VIP logo

ckanext-agsview's People

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

jguo144 jqnatividad hamhands smartcolumbus-ide opengov-opendata injune1123 dathere

ckanext-agsview's Issues

Mixed Content Warning

Was able to use a Proxy to serve up the this info

https://jqnatividad-prod.apigee.net/mapservices-bostonredevelopmentauthority-org/arcgis/rest/services/Maps/Zoning/MapServer/0

from

http://mapservices.bostonredevelopmentauthority.org/arcgis/rest/services/Maps/Zoning/MapServer/0

However, there is still mixed content warning from ags_fs_view/ags_ms_view js loading http://epsg.io.

https://github.com/AppGeo/ckanext-agsview/blob/master/ckanext/agsview/public/js/ags_fs_view.js#L72

https://github.com/AppGeo/ckanext-agsview/blob/master/ckanext/agsview/public/js/ags_ms_view.js#L106

See https://data.boston.gov/dataset/zoning-districts/resource/d993c51f-0224-429e-81c1-d71e1b507b5e

cc @calvinmetcalf @GuidoS @pgirard @jguo144 @samibaig

Embeds don't work

When trying to embed it on a third party site, or when using ckanext-featuredviews to feature the map on the dataset landing page.

You get this Javascript error:

Uncaught TypeError: str.replace is not a function
    at Object.trim (ags_fs_view.js:497)
    at cleanUrl (ags_fs_view.js:14179)
    at NewClass.initialize (ags_fs_view.js:16565)
    at NewClass.initialize (ags_fs_view.js:17075)
    at new NewClass (ags_fs_view.js:648)
    at Object.featureLayer (ags_fs_view.js:17376)
    at Module.loadJson (ags_fs_view.js:23094)
    at Module.initialize (ags_fs_view.js:23090)
    at Function.module.createInstance (jquery.form-warning.min.js;sandbox.min.js;module.min.js;pubsub.min.js;client.min.js;notify.min.js;i…:64)
    at String.<anonymous> (jquery.form-warning.min.js;sandbox.min.js;module.min.js;pubsub.min.js;client.min.js;notify.min.js;i…:64)

cc @GuidoS @pgirard

Namespace Issue

There is a namespace issue if you install this extension along with ckanext-spatial.
Both extensions have a file that's labeled the same "public/js/common_map.js".

Support for *non* proxy sites

We are not running proxies and agsview has been returning an internal server error for the services we're working with. Logs below:

[Thu Aug 17 17:46:37.620186 2017] [:error] [pid 17045:tid 140527971874560] [remote 127.0.0.1:42818] data-module-path="{{ h.with_proxy(resource_view.get('ags_url') or resource.url) }}"
[Thu Aug 17 17:46:37.620188 2017] [:error] [pid 17045:tid 140527971874560] [remote 127.0.0.1:42818] File '/usr/lib/ckan/default/src/ckanext-agsview/ckanext/agsview/plugin.py', line 31 in w$
[Thu Aug 17 17:46:37.620190 2017] [:error] [pid 17045:tid 140527971874560] [remote 127.0.0.1:42818] proxies = json.loads(ags_view_proxy())
[Thu Aug 17 17:46:37.620192 2017] [:error] [pid 17045:tid 140527971874560] [remote 127.0.0.1:42818] File '/usr/lib/python2.7/json/init.py', line 338 in loads
[Thu Aug 17 17:46:37.620194 2017] [:error] [pid 17045:tid 140527971874560] [remote 127.0.0.1:42818] return _default_decoder.decode(s)
[Thu Aug 17 17:46:37.620195 2017] [:error] [pid 17045:tid 140527971874560] [remote 127.0.0.1:42818] File '/usr/lib/python2.7/json/decoder.py', line 366 in decode
[Thu Aug 17 17:46:37.620197 2017] [:error] [pid 17045:tid 140527971874560] [remote 127.0.0.1:42818] obj, end = self.raw_decode(s, idx=_w(s, 0).end())
[Thu Aug 17 17:46:37.620199 2017] [:error] [pid 17045:tid 140527971874560] [remote 127.0.0.1:42818] File '/usr/lib/python2.7/json/decoder.py', line 385 in raw_decode
[Thu Aug 17 17:46:37.620201 2017] [:error] [pid 17045:tid 140527971874560] [remote 127.0.0.1:42818] raise ValueError("No JSON object could be decoded")
[Thu Aug 17 17:46:37.620203 2017] [:error] [pid 17045:tid 140527971874560] [remote 127.0.0.1:42818] ValueError: No JSON object could be decoded

Rolled back to ac26b9e and now the plugin works. Are proxies required or is this a bug?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.