appiko / nrf5x-firmware Goto Github PK

ITT is now a parameter that is the blanking time after a trigger from any source where another trigger does not happen

In the first SENSE_FEEDBACK_TIMEOUT_MS a red pulse indication is given to the user on detecting motion. Will this have any effect if the light sensing also happens at the same time?

Now this always gives connected. If this is a thing to be done in the future, we can just comment it out with a TODO

These two are redundant since there is a cmd_successful_data callback function

The main readme file has a couple of typos as well as some repetitions. Please correct when making the release.

Connection ID is for?

The ms-timer should be able to time at least 24 hours. Rework the macros to convert the timing ticks to ms and vice versa used by different modules.

As of now the out gen config parameters are computed at every trigger for both the PIR and timer. Since this is the same every time, it can be computed as soon as the parameters are received from the app. This will allow the out gen start to be called as right when the trigger is received.

Only if the POST request is success or failure as of now.

Although the struct for 'sim800_http_req_t' has a request type for GET, it is not supported to get the response data from either GET or POST. We can make an implementation where the buffer is in SIM800 module or the main application. Where would the location of the buffer be better?

Change from the current implementation for the PIR mode.