Giter VIP home page Giter VIP logo

Comments (3)

Mithi83 avatar Mithi83 commented on July 17, 2024

Reminds me of my review of the retexturing commit: 3735739

src/main/java/appeng/api/util/AEColor.java had a comment that could explain your observation:

-    public static final List<AEColor> VALID_COLORS = Arrays.asList(WHITE, ORANGE, MAGENTA, LIGHT_BLUE, YELLOW, LIME,
            PINK, GRAY, LIGHT_GRAY, CYAN, PURPLE, BLUE, BROWN, GREEN, RED, BLACK);
    // TODO (RID): Sorted the colours according to the colour wheel
+    public static final List<AEColor> VALID_COLORS = Arrays.asList(WHITE, LIGHT_GRAY, GRAY, BLACK, LIME, YELLOW,
            ORANGE, BROWN, RED, PINK, MAGENTA, PURPLE, BLUE, LIGHT_BLUE, CYAN, GREEN);

from applied-energistics-2.

Mari023 avatar Mari023 commented on July 17, 2024

maybe...
the change in index matches with up with the way the colors are wrong

from applied-energistics-2.

Mari023 avatar Mari023 commented on July 17, 2024

this seems suspicious...

Applied-Energistics-2/src/main/java/appeng/block/networking/CableBusBlock.java

Lines 248 to 255 in 216cf72

public boolean recolorBlock(BlockGetter level, BlockPos pos, Direction side,
DyeColor color, Player who) {
try {
return this.cb(level, pos).recolourBlock(side, AEColor.values()[color.ordinal()], who);
} catch (Throwable ignored) {
}
return false;
}

it uses the ordinal of the DyeColor as the index for AEColor, the later is now different

(this method is called by the color Applicator)

from applied-energistics-2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.