appsinet / arc-phpstan Goto Github PK

Please tag any release number - 1.0.0 or whatever you think is more suitable. This will help to install this lib more easily.

Hi,

We are using phabricator with a single repo and multiple projects in it.
For now phpstan is started from the repository root and as a consequence it cannot find the composer autoloader.

I think adding a configuration option for the autoload-file might be a solution, but maybe there could be something better?

I can do a pull request if that's the way to go.

Thanks

When running with arc lint:

Error  (phpstan) phpstan violation
    Error: Strict comparison using

When running directly phpstan:

Strict comparison using !== between null and string will always evaluate to true.

I guess regex here https://github.com/appsinet/arc-phpstan/blob/master/lint/linter/PhpstanLinter.php#L143 should be fixed:

$result = array();
        if (null !== $stdout && '' !== $stdout) {
            preg_match_all('/[a-zA-Z\/.]+:[0-99999]+:[a-zA-Z\/:_#\'()= \\\\$.0-99999\[\]]+/m', $stdout, $messages);
            foreach ($messages[0] as $warning) {