aquerr / chestrefill Goto Github PK

Possibility to configure messages to each refillable container when the refill occurs (individually) and when someone opens for the first time after refill.

Feature Request

It would be cool to have ability for creating refillable hoppers.

Let's add something like that!

Feature Request

It would be cool to have ability for creating refillable droppers.

Let's add something like that!

It would be very nice if there was an option to refill a container with one or more randomly selected items.

Love your plugin, thanks!

https://gist.github.com/ziceptor/970c6bb077f92590d1b35b1644815ee0

forge-1.12.2-14.23.2.2611-universal.jar
spongeforge-1.12.2-2611-7.1.0-BETA-2931.jar
ChestRefill-1.12.2-1.0.0.jar

Environment

• Sponge Version: <7.1.6

• Plugin Version: 1.4.0

What happens?

When I type /cr list I get a java.lang.NullPointerException.

I am using this plugin on a 1.12.2 hunger games-like server, and currently have 147 refillable chests (yes, it took me a couple of hours :s). The error occured when I created the 120th refillable chest, maybe it's some sort of index out of bouds issue? Is the memory for storing these chests dynamically allocated? Just throwing out thoughts...

Expected result

A list of all the refillable containers in the chat.

More information

Error log from the terminal:
(pastebin, easier to read)
[19:56:20] [Server thread/INFO] [minecraft/DedicatedServer]: Error occurred while executing command: null [19:56:20] [Server thread/ERROR] [Sponge]: Error occurred while executing command 'cr l' for source DedicatedServer: null java.lang.NullPointerException: null at io.github.aquerr.chestrefill.commands.ListCommand.execute(ListCommand.java:64) ~[ListCommand.class:?] at org.spongepowered.api.command.args.ChildCommandElementExecutor.execute(ChildCommandElementExecutor.java:255) ~[ChildCommandElementExecutor.class:1.12.2-2825-7.1.6] at org.spongepowered.api.command.spec.CommandSpec.process(CommandSpec.java:388) ~[CommandSpec.class:1.12.2-2825-7.1.6] at org.spongepowered.api.command.dispatcher.SimpleDispatcher.process(SimpleDispatcher.java:340) ~[SimpleDispatcher.class:1.12.2-2825-7.1.6] at org.spongepowered.common.command.SpongeCommandManager.process(SpongeCommandManager.java:337) [SpongeCommandManager.class:1.12.2-2825-7.1.6] at net.minecraft.command.ServerCommandManager.func_71556_a(SourceFile:1156) [dh.class:?] at net.minecraft.server.dedicated.DedicatedServer.func_71333_ah(DedicatedServer.java:433) [nz.class:?] at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:398) [nz.class:?] at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:668) [MinecraftServer.class:?] at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526) [MinecraftServer.class:?] at java.lang.Thread.run(Unknown Source) [?:1.8.0_221]
I should maybe point out that my containers.json file has about 50.000 lines...
(Got a big kit assigned to 147 chests :s)

Is it a memory problem? Can it be fixed?

Suggestion: my kits.json has 500 lines (it's just 1 kit). Maybe don't copy every item from the kit to the chest items-attribute in container.json, this results in 500 extra line per chest registry in containers.json, maybe this leads to memory corruption while loading it when playing live? (50.000 lines!) Maybe try creating a pointer to the kit (in "items") in containers.json for every chest instead of copying all the items from the kit.

/cr list is the only command that doesn't work, everything else works fine.

When you restart your server all chest's reset so every time i reset server i must again type "/cr c" and yeah. Please fix that!!

Just archery. The chests there.
https://gist.github.com/ziceptor/98ad67bea59d8f4bb5c8b60413ce69ad

Environment

• Sponge Version: spongeforge-1.12.2-2768-7.1.6-RC3616

• Plugin Version: ChestRefill-1.12.2-1.5.0-pre

What happens?

My timings report shows that chestrefill cause lag spikes. I have 20 Chests with auto refill disabled ( "time": 0 ) and the options "replace-existing-items", "hidden-if-no-items" set to true. Hiding block = minecraft:packed_ice

Expected result

No tps issues

More information

Timings: https://timings.aikar.co/?id=459e2232734e43d2ae557d7a903ae1ee

would it be possible to add a command or something to force reset chests that dont have anything in them? I see this plugin very useful for creating something like a hunger games kinda thing so would def need a way to regenerate the stuff after 'a game' was to end.

Environment

• Sponge Version: 8.2.0

• Plugin Version:

What happens?

Server doesn't start with error [java.lang.ThreadGroup:uncaughtException:1052]: net.minecraftforge.fml.loading.moddiscovery.InvalidModFileException: Missing ModLoader in file (ChestRefill-2.0.1-API-8.2.0.jar)

Expected result

Working server

More information

https://pastebin.com/iVvkEw11 full log

... with enchanted items.

forge-1.12.2-14.23.2.2611-universal.jar
spongeforge-1.12.2-2611-7.1.0-BETA-2990.jar
ChestRefill-1.12.2-1.2.1.jar

In the console error. At this point, I cannot provide a log.

Feature Request

It would be cool to have ability for creating refillable dispensers.

Let's add something like that!

What happens?

Chest time is not changed after editing the file. (Contents are changed but not the chest time)

Expected result

Refilling time should be changed to the new one if we change the time node in the chests.json file.