ar-siddiqui / curve_number_generator Goto Github PK

A lot of the application of CN is comparing pre and post-development scenarios.

Providing a module to compare two CN grids will make CN tool rock even more.

From Stephen Duncan:
Just a note, it would be nice if for hybrid HSG's that the tool would give you an option to average out the CN's, rather than just pick either the A B C or D options, but that's about it!

This will be useful for

1. Rest of the world
2. Developing Post Dev Scenario by Modifying a particular LU or AOI, like how it is done in Q-NSPECT

Can you please upload the source code into this repository and add a proper homepage link in metadata.txt

I observed one thing that I want a clarification.

1. If I use the default CN look up table, the cn field of the generated cn shapefile is in decimal; this is good since I can rasterize it easily;
2. However, I use my own CN look up table, the cn field of the generated cn shapefile is a text string; is this a bug? I would like the field is still in decimal under this situation.

Just like QGIS displays news feed on the opening of the page, the CN tool can do this as well using tool help. This would benefit to provide news updates etc such as new version available.

If the AOI is a square and the CRS is not 5070. Then during the reprojection of the raster downloaded from NLCD to the CRS of the AOI, some pixels for corners are missed. This is because of the nature of how projection work.

Before reprojection

After projection

This causes gaps in data on two of the corners.

The most updated NLCD dataset in Hawaii is 2011. However, the generator pulls the dataset from the 2019 dataset. Is there a way to change the codes to pull from the 2011 Hawaii dataset?

This is where the 2011 Hawaii dataset is: https://www.mrlc.gov/data/noaa-2011-high-resolution-land-cover-hawaii-0

This feature would allow users to

• Calculate CN by any local land use and soil data
• Compare pre and post-development Curve Number Changes
• Use this plugin anywhere in the world (currently, it works for CONUS only)

The following methodology will be adopted to implement this feature.

Workflow

• CN Plugin will have two modules, the existing one that will download data from the internet and a new one that will take user input.
• The user will provide local Land Use and Soil data to the new module.
• The user will also provide a custom lookup table always.

Tried running the plugin tool with QGIS 3.18.3-Zurich on Windows 10.

On the initial run, an error popped up regarding some type of SSL Certificate issue. I hit "ignore", but not "ignore and save". The tool failed because it couldn't pull the data down. On subsequent runs, the pop-up wouldn't open but the tool still wouldn't work. I uninstalled and reinstalled the plugin, still no popup, still no success. The error message indicated that it was on the server side, but I guessed this was a client-side issue.

I was able to fix this by manually creating an certificate exception under Settings > options > Authentication > Manage Certificates > Servers (tab) and created one for www.mrlc.gov. I wasn't sure which errors needed to be ignored so I checked essentially all of them.

Tool then ran fine.

Also, let me just say, thanks a ton for creating this! You are a selfless human saving people many human-hours of frustration.

Reasons

For

1. No File Management

Against

1. Usage log should be hidden from users

Potential Issues

• Restart of QGIS will keep the value? Yes it will
• Upgrading version may delete the variable?
• Different profiles have the same or different variables? Different values
• Is variable available in different versions? Yes

Resources

https://qgis.org/pyqgis/3.6/core/QgsExpressionContextUtils.html?highlight=globalscope#qgis.core.QgsExpressionContextUtils.setGlobalVariable

https://gis.stackexchange.com/questions/240085/how-to-get-layer-variables-using-qgis-python-apis

https://gis.stackexchange.com/questions/189075/how-to-change-a-project-variable-using-python

It looks like a change was applied to the GEOS GeoServer
jms-cluster: switch to using managed dependency for log4j

Now the Curve_number_generator may not be getting downloads.

Here is the Log Message:
QGIS version: 3.18.2-Zürich
QGIS code revision: 515138c171
Qt version: 5.11.2
GDAL version: 3.1.4
GEOS version: 3.8.1-CAPI-1.13.3
PROJ version: Rel. 6.3.2, May 1st, 2020
Processing algorithm…
Algorithm 'Curve Number Generator' starting…
Input parameters:
{ 'OutputCurveNumberLayer' : True, 'OutputNLCDImperviousRaster' : True, 'OutputNLCDLandCoverRaster' : True, 'OutputNLCDLandCoverVector' : False, 'OutputSoilLayer' : True, 'areaboundary' : 'D:/FLO-2D Docs/Short Course/AFMA 2021/Advanced Class/Module 1/Lesson 1.gpkg|layername=grid', 'cnlookup' : None, 'drainedsoilsleaveuncheckedifnotsure' : False }

Area Boundary layer extent area is 1,273.9463 acres

Successfully downloaded https://www.mrlc.gov/geoserver/mrlc_display/NLCD_2019_Impervious_L48/ows?version=1.3.0&service=WMS&layers=NLCD_2019_Impervious_L48&styles&crs=EPSG:2223&format=image/geotiff&request=GetMap&width=279&height=221&BBOX=656965.3593088828,957270.0,665335.3593088828,963900.0&
Results: {'OUTPUT': 'C:/Users/ComuterName/AppData/Local/Temp/processing_tpjsop/a9cb30bd23e84eb59afa4a9035c9b814/OUTPUT.file.0&'}
Unable to execute algorithm
Incorrect parameter value for INPUT
Unable to execute algorithm
Could not load source layer for INPUT: C:/Users//ComuterName/AppData/Local/Temp/processing_tpjsop/a9cb30bd23e84eb59afa4a9035c9b814/OUTPUT.file.0& not found
Unable to execute algorithm
Could not load source layer for INPUT: C:/Users//ComuterName/AppData/Local/Temp/processing_tpjsop/a9cb30bd23e84eb59afa4a9035c9b814/OUTPUT.file.0& not found
Execution failed after 1.82 seconds

Loading resulting layers
Algorithm 'Curve Number Generator' finished

Create change log in the WIKI

With the template set in QNSPECT, the Plugin should have proper layer sinks and use QgsLayerPostProcessorInterface to stylize.

This would allow the tool to be used in batch processing, and command-line environments properly.

When trying to run the custom algorithm, the "_" is removed from the grid_code column. I think this may be causing an issue where the cn field returned is Null. This occurs even when using the NLCD, Soils, and default cn lookup table created in the standard algorithm.

Since CN generator is also used as a downloader for NLCD data, sometimes users would like to download data at a courser resolution.

Currently, it is float32 which takes up more space and is not acceptable to HEC-RAS as Land Cover.