ar0551 / wasp Goto Github PK

A check for reserved characters should be added to all name inputs.

Currently, the Aggregation Graph returns a graph connecting the centers of each connected parts with each other. For various applications (e.g., structural analysis or topology studies) it could be useful to have a graph where lines connect the parts through their connected connections.
This currently can be created combining the output of the graph with a DeconstructPart component, but an option for generating this automatically out of the components would be handy.

The global constraints check function fails when mixing constraints which have the required options set to True with constraints which have it set to False.
This happens because the constraints check function does not separate between the two, and adding a required constraint automatically makes all the optional constraints not considered.

Hi Andrea, would you consider progressively transitioning the Wasp plugin to Csharp, probably starting with the most heavy components (field based aggregation seems to be the worst offender)?

Currently all Adjacency/Exclusion Constraints are always required. Adding a required/optional parameters, as it is already available on the global constraints, would allow more flexibility.
Requested here: https://www.youtube.com/watch?v=dnrK8wpUNmg&lc=UgwPz8HAjrYn41xj82R4AaABAg.9I5UwGV4hWB9_56plBVrwP

When aggregating with a Part Catalog containing some part amounts set to 0, if the aggregation is blocked by local constraints, the algorithm adds unwanted parts which should not be allowed.
A check is needed in the PartCatalog.return_weighted_part() function to avoid this.

Currently, changes to a Part Catalog are not passed to the Aggregation class by the aggregation components. The issue is how to handle changes, as if a Catalog has been emptied already and changes are made to the input Catalog, this would refill the whole catalog, hence adding again also the parts that were already placed.
One option would be to keep track of the input catalog in a separate variable, compare the new input one with the stored version, and update only the ones that changes with the difference between the stored one and the input one.

It happens rarely, but in the case of two parts connecting in a way that forces the part centers to overlap, Wasp automatically assumes the parts overlap as well. While this is true in most cases, in few ones (e.g. a part with a pass-through hole exactly in the middle) the centers overlap, but the parts do not.
Maybe another method for checking overlaps or a better mesh collision check might be needed.

Graph component should check if the connections belong to the same Part when checking for connectivity with Full Graph mode.

When computing the full aggregation graph, the Graph component currently uses the Wasp global_tolerance value. It would be useful to allow the user to set a custom tolerance, as in certain cases (e.g., interlocking connections) elements should be considered connected even is the connections are at a specific distance from each other (see attached screenshot)

Hi Andrea, it would be tremendously beneficial to be able to send aggregations to and from Hops components, as this would open up parallel computing for Wasp - I know that there is a save to file method that I could use, but thought I would ask you to expose the JSON encoded aggregation which can then be used as a String to send to a hops component?

A "merge aggregation" components would help solve the issue, by renumbering part_ids before the merge, and check for additional connections between the two aggregations.

Hey !
It seems like wasp sometimes doesn't test some connexions.
My guess is that it doesn't (always?) test another part if the first part didn't work, removing the possibility for a match.

link to Gh file : https://we.tl/t-XQiz74nJKV
And 2 screens to illustrate the problem.
The highlighted green space should be populated with the highlighted black one.