arapelle / cmtk Goto Github PK

• Call target_default_warning_options() if cmake option NO_DEFAULT_WARNING_OPTIONS is undefined.

• add_cpp_executable_test

• add_cpp_executable_basic_tests

• add_cpp_library_example

• add_cpp_library_basic_examples

• add_cpp_library_test

• add_cpp_library_basic_tests

• Function which link libraries to object shared and static targets correctly
  • PRIVATE and PUBLIC targets are linked to the object targets.
  • PUBLIC and INTERFACE targets are linked to the shared and static targets.
• In add_cpp_library() SHARED and STATIC are optional now.

For static and shared targets:

• ARG_PUBLIC must be preceded by PUBLIC.
• ARG_INTERFACE must be preceded by INTERFACE.

Look at strn branch code_coverage for gcovr.

• Rename it disable_in_source_build().
• Just get build real/absolute path and source real/absolute path and check that source build is not found in build path.

like generate_verbose_library_config_file(), ...

In Utility:

macro(find_package_if_not_target target package_name)
    if(NOT TARGET ${target})
        find_package(${package_name} ${ARGN})
    endif()
endmacro()

Use cmake_parse_arguments() with list keywords: IF, THEN, ELSE.

Create a cache variable if SPDLOG_ACTIVE_LEVEL does not exist.
The cache variable is a string enum : "TRACE" "DEBUG" "INFO" "WARN" "ERROR" "CRITICAL" "OFF".

The init value is set to DEBUG if build type is Debug, RELEASE if build type is Release or TRACE otherwise.

• Add option HEADER_ONLY.

• Analyze, POC
• Clean
• List params
• Implement
• Test no regression

• add_cpp_library() new parameter NAMESPACE
• Create ALIAS for static and shared targets
• add_cpp_honly_library() new parameter NAMESPACE
• Create ALIAS for honly target

PUBLIC is too confusing (even for me!). So, it is deprecated.
BUILD_SHARED and BUILD_STATIC can be ON, OFF, UNDEFINED, OPTION.
(OPTION and UNDEFINED have the same meaning. Just that, UNDEFINED is a possible value of a trioption.)
OPTION (and UNDEFINED too) means building SHARED (or STATIC) target depends on an option.

So, PUBLIC should be replaced by:

BUILD_SHARED OPTION
BUILD_STATIC OPTION

Should UNDEFINED value of trioption be renamed OPTION ? probably not.

# target_SPDLOG_ACTIVE_LEVEL_definition()
function(target_SPDLOG_ACTIVE_LEVEL_definition target)
    cmake_parse_arguments(PARSE_ARGV 1 "ARG" "" "LEVEL" "")
    if(ARG_LEVEL)
        set(SPDLOG_ACTIVE_LEVEL ${ARG_LEVEL})
    endif()
    fatal_ifndef("Variable SPDLOG_ACTIVE_LEVEL is not defined." SPDLOG_ACTIVE_LEVEL)
    target_compile_definitions(${target} PRIVATE SPDLOG_ACTIVE_LEVEL=${SPDLOG_ACTIVE_LEVEL})
endfunction()

• Replace value TRACE by SPDLOG_LEVEL_TRACE, ... in set_SPDLOG_ACTIVE_LEVEL_ifndef().

If the variable is DEFINED, BUILD_SHARED|STATIC becomes the variable value.
Otherwise, a cache option is created.

When a project is a subproject (git submodule for example) which creates a uninstall script,
it must not remove files of siblings projects installed before him.

When the list of files to remove by the script is created, the list of files already treated by another uninstall script
must be removed from the list.

Remove functions:

• generate_default_version_header()
• configure_version_header()

Add doc for:

• Utility;
  • fatal_ifdef()
  • fatal_ifndef()
  • fatal_if_none_is_def()
  • set_ifndef()
  • set_iftest()
  • trioption()
  • option_or_set_ifdef()
  • trioption_or_set_ifdef()
• configure_headers()
• set_SPDLOG_ACTIVE_LEVEL_ifndef()
• target_default_warning_options()
• generate_version_macro_header() ?

• Rename functions.
• Add doc.

• Rename install_library_package().

Replace by set_buid_type_ifndef([TYPES Release Debug ...] [DEFAULT 0|Release])

https://cmake.org/cmake/help/latest/guide/using-dependencies/index.html#fetchcontent-and-find-package-integration

• CppLibraryExamples
• CppExecutableTests
• CppExecutableProject
• CppLibraryTests

Use doc:
https://cmake.org/cmake/help/latest/guide/importing-exporting/index.html#exporting-targets-from-the-build-tree

Examples:
https://github.com/skypjack/entt

• Analyze, POC
• List params
• Implement
• Test no regression

BUG : When install_library_package() is called with UNINSTALL_SCRIPT with no parameter, UNINSTALL_SCRIPT is not DEFINED. So, cmake_uninstall.cmake script are not installed.

• Clarify CMAKE_INSTALL_MANIFEST_FILES, CMTK_INSTALL_FILES and files variables.
• Close CMake ticket

Add parameters to parse:

• VERSION version
• FILENAME filename: filename of the uninstall script.
• PACKAGE_DIR dir

• Modern API: use FILE_SET HEADERS.
• New organization allowing to test executable.

• find_or_simple_fetch() (or find_or_fc_declare_and_make_available())

• Split main header: a header for each resource function is generated.
• A namespace for each resource subfolder.

Arguments for add_rsc_cpp_library():

• NAME name
• [PARENT_NAMESPACE parent_ns]
• [INLINE_PARENT_NAMESPACE parent_ns]
• [PRIVATE_RESOURCE_HEADERS]
• [PRIVATE_RESOURCE_PATHS_HEADER]
• add_cpp_library() arguments

Generated lib API:

• find_serialized_resource()

Doc:

• Documentation

• Use param keywords:
  OBJECT, STATIC, SHARED, HEADER_ONLY.
  One of STATIC, SHARED, HEADER_ONLY is required.
• Rename cpp_library_link_libraries()