(I am wandering through the print visitors at this moment to find root cause / possibl

Uniform buffer object declarations not being emitted correctly. about glsl-optimizer HOT 3 OPEN

aras-p commented on May 18, 2024

Uniform buffer object declarations not being emitted correctly.

from glsl-optimizer.

Comments (3)

themikelester commented on May 18, 2024

Any update on this? Did you have any luck plynkus?

from glsl-optimizer.

plynkus commented on May 18, 2024

With some local, dirty, probably use case specific hacks to _mesa_print_ir_glsl() within ir_print_glsl_visitor.cpp, as I recall. I haven't looked at it in a while, but this is a good reminder to pull anew / retest / consider something more clean.

from glsl-optimizer.

Asubayo commented on May 18, 2024

Same issue. Yes, UBO are parsed but no printed in the glsl output.
Indeed, a quick modifications can be done in the function _mesa_print_ir_glsl (file ir_print_glsl_visitor.cpp), especially in the ir_print_glsl_visitor visitor for variable :

void ir_print_glsl_visitor::visit(ir_variable *ir)

After the line :

buffer.asprintf_append ("%s%s%s%s", cent, inv, interp[ir->data.interpolation], mode[decormode][ir->data.mode]);

we can add a ubo printer like :

buffer.asprintf_append ("%s%s%s%s", cent, inv, interp[ir->data.interpolation], mode[decormode][ir->data.mode]);
	print_precision (ir, ir->type);
	print_type(buffer, ir->type, false);

	if (ir->type->base_type == GLSL_TYPE_INTERFACE)
	{
		buffer.asprintf_append("\n{\n");

		for (auto pid = 0u; pid < ir->type->length; ++pid)
		{
			const auto &structField = ir->type->fields.structure[pid];
			
			buffer.asprintf_append("\t");
			print_precision(ir, structField.type);
			print_type(buffer, structField.type, false);
			buffer.asprintf_append(" ");
			buffer.asprintf_append(structField.name);

			if (structField.type->base_type == GLSL_TYPE_ARRAY)
			{
				buffer.asprintf_append("[%u]", structField.type->length);
			}

			buffer.asprintf_append(";\n");
		}

		buffer.asprintf_append("\n}");
	}
	
	buffer.asprintf_append (" ");
	print_var_name (ir);

from glsl-optimizer.

Recommend Projects