arasmr / hyf-javascript1 Goto Github PK

Hi Emre, here is my feedback on your homework.

• When you work on your homework in VSCode it is best to open the root folder that contains the entire Git repo rather than one of its subfolders. So, in this case, open the folder hyf-javascript1 rather than the week2 folder in VSCode. The file .eslintrc.json and the folder .vscode can best reside in the project's root folder, so that they automatically apply to week2 and week3 etc.
• You are not using semicolons to terminate your statements. This is fine if you do it consistently (which I think you have done). In class we will be using semicolons (consistently), because you will find them in most examples on the Internet and in textbooks. (For my own work I've stopped using semicolons.)

1assignment

• Use at most one blank line to separate blocks of code.
• Pay attention to punctuation in your text strings: a comma should always be followed by a space.

3assignment

• Use let and const in preference over var.
• A colon : should be followed by a space in your text strings.

4assignment

• colons: see above

Not much to comment here. I think you have done very well. Congrats!