The ng-aria from arbus

ng-aria's People

Stargazers

Watchers

ng-aria's Issues

Correct best practices

Please do not use the angular-reserved namespaces in your APIs. See: https://github.com/angular/angular-component-spec

Specifically, I would recommend against naming the module ngAria, and recommend against $-prefixed names for services.

A PR for this into angular core (as we discussed) could use these names, but it's important that 3rd party plugins don't use these names or there might be unexpected behavior for consumers of this module if this does land in core.

Refactor suggestion #1

The ariaProvider publishes the following

var ariaFactory = function(){
    return {
      ariaHidden: watchClass('ng-hide', 'ariaHidden'),
      ariaChecked: watchAttr('checked', 'ariaChecked', false),
      ariaDisabled: watchAttr('disabled', 'ariaDisabled', false),
      ariaRequired: watchAttr('required', 'ariaRequired', false),
      ariaInvalid: watchClass('ng-invalid', 'ariaInvalid')
    };
  };

  return{
    enable: function(config){
      if(angular.isUndefined(config)){
        currentConfig = defaultConfig;
      }else{
        this.setConfig(config);
      }
    },
    setConfig: function(config){
      currentConfig = angular.extend(defaultConfig, config);
    },
    $get: ariaFactory
  };

I suggest that the ariaFactory variable is superfluous since the aria Provider is instantiated only one time.

  return {
    enable: function(config){
      if(angular.isUndefined(config)){
        currentConfig = defaultConfig;
      }else{
        this.setConfig(config);
      }
    },
    setConfig: function(config){
      currentConfig = angular.extend(defaultConfig, config);
    },
    $get:  function(){
      return {
        ariaHidden: watchClass('ng-hide', 'ariaHidden'),
        ariaChecked: watchAttr('checked', 'ariaChecked', false),
        ariaDisabled: watchAttr('disabled', 'ariaDisabled', false),
        ariaRequired: watchAttr('required', 'ariaRequired', false),
        ariaInvalid: watchClass('ng-invalid', 'ariaInvalid')
      };
    }
  };