ardar / flowlib Goto Github PK

What steps will reproduce the problem?
* Downloading filelists
* Downloading files where size is unknown before request.

What is the expected output? What do you see instead?
* DownloadItem.SegmentStarted event is trigged when download of
file/segment starts.

What version of the product are you using? ~~(Do not write latest)~~
FlowLib 20080628


Please provide any additional information below.
hackward first reported this bug in FAQ section.

What steps will reproduce the problem?
1. Share any files
2. Join hub
3. try to add new folder to share

What is the expected output? What do you see instead?
Share should be added without InvalidOperationException

What version of the product are you using? ~~(Do not write latest)~~
SVN r493    

On what operating system?
Windows 7 (7100)

Call Stack? ~~(Line numbers and exception type helps much)~~
hubnmdcprotocol.cs
Exception on line 
foreach (System.Collections.Generic.KeyValuePair<string, 
Containers.ContentInfo> var in hub.Share)

InvalidOperationException - collection have been changed

Please provide any additional information below.
Probably exception thrown because AddContent Function does not lock share

I'm trying to write dc client with share manager. I'm created sharing 
dialog like StrongDC - folder tree with ability to check needed folders.
After each check programm calls AddVirtualDir function of Share object.
If user selects several folders i have following error:

Argument Exception : 
Length of result array is too small. Check destIndex and length values and 
lower bound of array. 

in line

SortedList<string, ContentInfo> tmpShare = new SortedList<string, 
ContentInfo>(share);

(Share.cs line 696)

To reproduce this situation you can use following code:
Share s = new Share("my");
DirectoryInfo di=new DirectoryInfo("C:\\");
foreach (DirectoryInfo d in di.GetDirectories())
{
    s.AddVirtualDir(d.Name, d.FullName);
}



I'm using SVN version of flowlib from 4 feb 2009


OS: Windows Vista SP1, Windows XP Sp3

In:
protected virtual void UpdateMyInfo(bool firstTime)
sometimes when this code is executed
                System.Threading.Thread t = new System.Threading.Thread
(new System.Threading.ThreadStart(OnMyINFOPool));
                t.Priority = System.Threading.ThreadPriority.Lowest;
                t.Name = "MyINFO Pool";
                t.Start();
A System.OutOfMemoryException is being thrown when trying to do t.Start()


What is the expected output? What do you see instead?
Some form of try catch should be used,  maybe with a small sleep before 
you retry.

What version of the product are you using? ~~(Do not write latest)~~
ast thing from the SVN.

On what operating system?
Windows Vista

Call Stack? ~~(Line numbers and exception type helps much)~~


Please provide any additional information below.

What steps will reproduce the problem?
1. Try to download something in passive mode.


What version of the product are you using? ~~(Do not write latest)~~
SVN r522

Please provide any additional information below.
take a look at transfernmdcprotocol.cs line 590:
trans.Source.UserId = trans.User.StoreID;
Issue can be fixed if use:
trans.Source.UserId = "{hubaddress}{hubport}"+trans.User.StoreID;

What steps will reproduce the problem?
1. Join hub
2. Start dowbnloading big file with many sources 4 GB /80 Sources
3. Search for alternatives, add all sources to download item
4. call start transfer for all sources

What is the expected output? What do you see instead?
it should work i think=)

What version of the product are you using?
SVN r482

On what operating system?
Windows 7 7022

Call Stack? ~~(Line numbers and exception type helps much)~~
First IOException:
The process cannot access the file '{File path}' because it is being used 
by another process.
File: transfernmdcprotocol.cs Line: 278


Second SocketException:
remote host has closed connection
File: Connections\TcpConnectionListener.cs Line: 91

Please provide any additional information below.
First of all i got exception №1, i have avoided it using limit for active 
transfers (40)
after that it start downloading correctly (using 30-40 sources), but some 
time later i got second exception. I have changed 
catch (ObjectDisposedException)
to
catch (Exception)
and then it looks like starts downloading normally

When I found flowlib first time I was very happy because it is fully 
written in my favoutite language (C#) But I was confused after watching 
examples - It was needed to write more than hundred lines of code to 
download one user filelist. I have decide to write my client using FlowLib. 
After almost year of coding I have finished developing. Now I want to make 
it stable. Unfortunately it cannot work for long time. It has memory leak 
and I dont know reason. I have prepared new program layer what can be used 
in flowlib.
It is single hub DC Engine. It accumulates most of Flowlib possibilities 
and provide easy-to use access to DC functions. For example, here the code 
to download file from hub:

static DCEngine dc = null;
static void Main(string[] args)
{
HubSetting settings = new HubSetting();
settings.Address = "hub.o-go.ru";
settings.DisplayName = "AdvancedBot";
dc = new DCEngine(settings);
dc.StateChanged += new EventHandler(dc_StateChanged);
dc.Connect();
}
static void dc_StateChanged(object sender, EventArgs e)
{
if(dc.State == EngineState.Logged)
{
dc.DownloadManager.DownloadCompleted += new 
FmdcEventHandler(DownloadManager_DownloadCompleted);
dc.DownloadFile(new Magnet("magnet:?
xt=urn:tree:tiger:DAFZ6VGGTY5LDNWTBGC7DGMBXSOCU66J23Y6ZCQ&xl=13750994&dn=En
igma_-_Metamorphosis.mp3"));
}
}
static void DownloadManager_DownloadCompleted(object sender, FmdcEventArgs 
e)
{
Console.WriteLine("File downloaded");
dc.Dispose();
}

This code will establish hub connection, then it will find sources and 
download a file using templorary file and multisegment downloading. This 
code mostly taken from my client. It also has feature that disconnects slow 
connections at download end. it works in active and passive mode.

3 things needed to be changed in flowlib to use attached code:
1. DownloadItem.DownloadPriority Type should be uncommented
2. DownloadItem.Priority Property should exists
3. UserInfo.TCPPORT functionality should be added like UDPPORT (And it 
shuold be used in hubprotocol if Share object is null)

I'm still working on that code, and It was great if you will add it to 
flowlib or help me to create stable version.

What steps will reproduce the problem?
1. Join hub
2. Start dowbnloading big file with many sources 4 GB /80 Sources
3. Search for alternatives, add all sources to download item
4. call start transfer for all sources

What is the expected output? What do you see instead?
it should work i think=)

What version of the product are you using?
SVN r482

On what operating system?
Windows 7 7022

Call Stack? ~~(Line numbers and exception type helps much)~~
First IOException:
The process cannot access the file '{File path}' because it is being used 
by another process.
File: transfernmdcprotocol.cs Line: 278


Second SocketException:
remote host has closed connection
File: Connections\TcpConnectionListener.cs Line: 91

Please provide any additional information below.
First of all i got exception №1, i have avoided it using limit for active 
transfers (40)
after that it start downloading correctly (using 30-40 sources), but some 
time later i got second exception. I have changed 
catch (ObjectDisposedException)
to
catch (Exception)
and then it looks like starts downloading normally

1) change ActiveDownloadFilelistFromUser.cs like this:

                case Actions.UserOnline:
                    UserInfo usrInfo = e.Data as UserInfo;
                    if (usrInfo == null) return;
                    users.Enqueue(usrInfo.ID);
                    bool hasMe = (hub.GetUserById(hub.Me.ID) != null);
                    if (hasMe && users.Count > 0)
                        Console.Write(users.Count + " users");
                    while (hasMe && users.Count > 0)
                    {
                        string usrId = users.Dequeue();
                        User usr = null;
                        if ((usr = hub.GetUserById(usrId)) != null)
                        {
                            ContentInfo info = new ContentInfo
(ContentInfo.FILELIST, BaseFilelist.XMLBZ);
                            info.Set(ContentInfo.STORAGEPATH, currentDir + 
@"Filelists\" + usr.ID + ".dcxml.bz2");
                            DownloadItem dwnItem = new DownloadItem(info);
                            downloadManager.AddDownload(dwnItem, new Source
(hub.RemoteAddress.ToString(), usr.ID));
                            UpdateBase(this, new FmdcEventArgs
(Actions.StartTransfer, usr)); // Start transfer to user
                            for (int i = 0; i < 300; i++)
                                if (downloadManager.ContainsDownload
(dwnItem))
                                    System.Threading.Thread.Sleep(100);
                            downloadManager.RemoveDownload(dwnItem);  // 
to avoid other bug during saving many filelists at one time
                        }
                    }
                    break;

2) also add next line in the beginning of this class
        public Queue<string> users = new Queue<string>();

- this code successfully downloads all filelists from english nicks, but 
never downloads filelists from russian nicks even on russian system locale.
Why? - I don't know.
What happens? - simply exiting from the cycle by timeout (30 seconds) - 
only for russian nicks (without any program exeptions).
What is the expected output? - downloading all filelists, even from 
russian nicks.
What do you see instead? - downloading filelists only from english nicks.
What version of the product are you using? - FlowLib 20080628.
On what operating system? - Windows XP Eng + Russian MUI + Russian system 
locale.
Call Stack? - there are no any exceptions.
Other info - using DC++ hub PtokaX 0.3.6.0

What steps will reproduce the problem?
1. Create UDPConnection
2. call StartListen
3. try to stop :)

I think it should have Dispose function 

What steps will reproduce the problem?
1. Join hub
2. Download someone filelist
3. Try DownloadManager.AddDownload on two distinct files

What is the expected output? 
It should add 2 different DownloadItem
What do you see instead?
It has only one DownloadItem and 2 equal sources 

What version of the product are you using?
SVN r475

On what operating system?
Windows Vista Sp1

No exeptions thrown


Please provide any additional information below.
It correctly add DownloadItem from 2 different users

What steps will reproduce the problem?
1. Join hub
2. Download filelist from user
3. Start download file
4. Search for alternative sources
5. Add sources to DownloadManager

What is the expected output? 
After downloading, DownloadCompleted event should fire

What do you see instead?
At download finish All segments marked as downloaded, no any events fires.

What version of the product are you using? 
SVN r478

On what operating system?
Windows Vista SP1

Please provide any additional information below.
Sometimes I got exception on line 269 col 47 transfernmdcprotocol.cs
fs.Unlock(trans.CurrentSegment.Start, trans.CurrentSegment.Length);
Exception: File already unlocked
and 
trans.CurrentSegment.Start equals to trans.CurrentSegment.Length

What steps will reproduce the problem?
1. Add several files to queue from same user
2. Wait for file 1 to download

What is the expected output? What do you see instead?
Expected output: Continue downloading file 2 after file 1 is finished
Instead: File 1 completes fine, and nothing happens

What version of the product are you using? On what operating system?
SVN 288

What step will reproduce the problem?
Connecting to any ADC hub.

What is the expected output? 
Successfully connect to the ADC hub.

What do you see instead?
"Protocol is not supported. I only support ADC 1.0/ADCS 0.10 and prior"
shown as main chat message.

What version of the product are you using?
FlowLib (20080628)


Please provide any additional information below.
In file AdcProtocol.cs...

At line 752:

version = double.Parse(ctm.Protocol.Substring( ctm.Protocol.IndexOf("/") +1
).Replace(".", ","));

At line 805:

version = double.Parse(rcm.Protocol.Substring( rcm.Protocol.IndexOf("/") +1
).Replace(".", ","));

The Replace methods should be removed to successfully return the correct
protocol version.

What steps will reproduce the problem?
1. Join hub
2. Start dowbnloading big file with many sources 4 GB /80 Sources
3. Search for alternatives, add all sources to download item
4. call start transfer for all sources

What is the expected output? What do you see instead?
it should work i think=)

What version of the product are you using?
SVN r482

On what operating system?
Windows 7 7022

Call Stack? ~~(Line numbers and exception type helps much)~~
First IOException:
The process cannot access the file '{File path}' because it is being used 
by another process.
File: transfernmdcprotocol.cs Line: 278


Second SocketException:
remote host has closed connection
File: Connections\TcpConnectionListener.cs Line: 91

Please provide any additional information below.
First of all i got exception №1, i have avoided it using limit for active 
transfers (40)
after that it start downloading correctly (using 30-40 sources), but some 
time later i got second exception. I have changed 
catch (ObjectDisposedException)
to
catch (Exception)
and then it looks like starts downloading normally

[deleted issue]

Hey,

When I'm creating a linked-list of ConnectedHub's that are connected to a
few(3) heavy-load hubs at the same time.
After connecting im logging all incoming msgs to a file.

I'm using the latest FlowLlib

After a while the program crashes with:


Unhandled Exception: Unhandled Exception: Unhandled Exception: 
System.ObjectDisposedException: Cannot access a disposed object. Object
name: 'System.Net.Sockets.Socket'.
   at System.Net.Sockets.Socket.EndSend(IAsyncResult asyncResult,
SocketError& errorCode)
   at System.Net.Sockets.Socket.EndSend(IAsyncResult asyncResult)
   at FlowLib.Connections.TcpConnection.OnSendData(IAsyncResult async)
   at FlowLib.Connections.Hub.OnSendData(IAsyncResult async)
   at System.Net.LazyAsyncResult.Complete(IntPtr userToken)
   at System.Net.ContextAwareResult.CompleteCallback(Object state)
   at System.Threading.ExecutionContext.Run(ExecutionContext
executionContext, ContextCallback callback, Object state)
   at System.Net.ContextAwareResult.Complete(IntPtr userToken)
   at System.Net.LazyAsyncResult.ProtectedInvokeCallback(Object result,
IntPtr userToken)
   at
System.Net.Sockets.BaseOverlappedAsyncResult.CompletionPortCallback(UInt32
errorCode, UInt32 numBytes, NativeOverlapped* nativeOverlapped)
   at
System.Threading._IOCompletionCallback.PerformIOCompletionCallback(UInt32errorCo
de,
UInt32 numBytes, NativeOverlapped* pOVERLAP) 
System.ObjectDisposedException: Cannot access a disposed object.Object
name: 'System.Net.Sockets.Socket'.
   at System.Net.Sockets.Socket.EndSend(IAsyncResult asyncResult,
SocketError& errorCode)
   at System.Net.Sockets.Socket.EndSend(IAsyncResult asyncResult)
   at FlowLib.Connections.TcpConnection.OnSendData(IAsyncResult async)
   at FlowLib.Connections.Hub.OnSendData(IAsyncResult async)
   at System.Net.LazyAsyncResult.Complete(IntPtr userToken)
   at System.Net.ContextAwareResult.CompleteCallback(Object state)
   at System.Threading.ExecutionContext.Run(ExecutionContext
executionContext, ContextCallback callback, Object state)
   at System.Net.ContextAwareResult.Complete(IntPtr userToken)
   at System.Net.LazyAsyncResult.ProtectedInvokeCallback(Object result,
IntPtr userToken)
   at
System.Net.Sockets.BaseOverlappedAsyncResult.CompletionPortCallback(UInt32
errorCode, UInt32 numBytes, NativeOverlapped* nativeOverlapped)
   at
System.Threading._IOCompletionCallback.PerformIOCompletionCallback(UInt32
errorCode, UInt32 numBytes, NativeOverlapped* pOVERLAP)
System.ObjectDisposedException: Cannot access a disposed object. Object
name: 'System.Net.Sockets.Socket'.
   at System.Net.Sockets.Socket.EndSend(IAsyncResult asyncResult,
SocketError& errorCode)
   at System.Net.Sockets.Socket.EndSend(IAsyncResult asyncResult)
   at FlowLib.Connections.TcpConnection.OnSendData(IAsyncResult async)
   at FlowLib.Connections.Hub.OnSendData(IAsyncResult async)
   at System.Net.LazyAsyncResult.Complete(IntPtr userToken)
   at System.Net.ContextAwareResult.CompleteCallback(Object state)
   at System.Threading.ExecutionContext.Run(ExecutionContext
executionContext, ContextCallback callback, Object state)
   at System.Net.ContextAwareResult.Complete(IntPtr userToken)
   at System.Net.LazyAsyncResult.ProtectedInvokeCallback(Object result,
IntPtr userToken)
   at
System.Net.Sockets.BaseOverlappedAsyncResult.CompletionPortCallback(UInt32
errorCode, UInt32 numBytes, NativeOverlapped* nativeOverlapped)
   at
System.Threading._IOCompletionCallback.PerformIOCompletionCallback(UInt32
errorCode, UInt32 numBytes, NativeOverlapped* pOVERLAP)

What steps will reproduce the problem?
1. Download any file
2. Increase TcpConncetion.cs buffer to big value like 10000000000
3. Watch speed it show incorreclty.


What is the expected output? What do you see instead?
It should calculates correctly

What version of the product are you using? ~~(Do not write latest)~~
SVN r 489


On what operating system?
Windows 7 RC (7100)


Please provide any additional information below.
Speed shows incorreclty because Collector used wrong field if message is 
FlowLib.Containers.BinaryMessage

I think it should be fixed like here:
GeneralProtocolDataCollector.cs
change 
protected override void HandleReceived(IConMessage msg) 
body to
if (msg is FlowLib.Containers.BinaryMessage)
{
TotalBytesReceived += (msg as FlowLib.Containers.BinaryMessage).Length;
}
else TotalBytesReceived += msg.Bytes.Length;

What steps will reproduce the problem?
1. Start 3 transfers to the same user

What steps will reproduce the problem?
1. Join hub, wait while all users loaded
2. Rejoin hub

possible will occur without reconnection

What is the expected output? What do you see instead?
Look at Protocol_Update event handler, event type Actions.UserOnline
UserInfo class attached to event always has IsOperator== false for all 
types of users

What version of the product are you using? ~~(Do not write latest)~~
SVN r482

On what operating system?
Windows Vista SP1

Please provide any additional information below.
If i get User object from hub it has right value of IsOperator

What steps will reproduce the problem?
1. Start download transfer
2. call TransferManager.EndTransfer() method or ITransfer.Disconnect() of 
created transfer

What is the expected output? What do you see instead?
Transfer should stop. Application stops responding.

What version of the product are you using? ~~(Do not write latest)~~
SVN r482

On what operating system?
Windows Vista Sp1

Call Stack? ~~(Line numbers and exception type helps much)~~
no exceptions

What steps will reproduce the problem?
1. Join any russian hub
2. Watch nicklist 


What is the expected output? What do you see instead?
- please watch attached image

What version of the product are you using? ~~(Do not write latest)~~
FlowLib 2008/Nov/21 (SVN)

On what operating system?
Windows XP sp2

Call Stack? ~~(Line numbers and exception type helps much)~~
No exceptions.

Please provide any additional information below.
-All works fine in FlowLib third release

What steps will reproduce the problem?
1. Join hub
2. Start search by tth


What is the expected output? 
Search should start. 
What do you see instead?
Nothing happens.

What version of the product are you using? 
FlowLib SVN r478

On what operating system?
Windows 7 7022

Call Stack? 
no any exceptions

Please provide any additional information below.
I dont know how to properly create SearchInfo to seach by tth.

following code works:
SearchInfo si= new SearchInfo();
si.Set(SearchInfo.SEARCH, "TTH:" + di.ContentInfo[ContentInfo.TTH]);
si.Set(SearchInfo.EXTENTION, "$1");

next code do not work:
SearchInfo si= new SearchInfo();
si.Set(SearchInfo.TYPE,"2");
si.Set(SearchInfo.SEARCH,downloadItem.ContentInfo[ContentInfo.TTH]);

What steps will reproduce the problem?
1. Open Solution in Mono Develop
2. Build Solution
3. Build Fails.

What is the expected output? What do you see instead?

Build succeded, 0 errors, 0 warnings.

What version of the product are you using? ~~(Do not write latest)~~

20071222, 20080119, trunk

On what operating system?

Mac OS X

Call Stack? ~~(Line numbers and exception type helps much)~~

Performing main compilation...
Compilation failed: 2 error(s), 0 warnings

/Users/sreyan/Downloads/FlowLib20071222/Source/FlowLib/Utils/Compression/ZLibSub
Methods/DeflaterHuffman.cs(807,77):
error CS1002: Expecting `;'
/Users/sreyan/Downloads/FlowLib20071222/Source/FlowLib/Utils/Compression/ZLibSub
Methods/DeflaterHuffman.cs(814,27):
error CS1518: Expected `class', `delegate', `enum', `interface', or `struct'


Build complete -- 2 errors, 0 warnings
Please provide any additional information below.

Our interet provider have set 2 standart port for p2p: 10853 tcp, 6803 udp.
I want to use active connection to download files and to search files. If 
i set tcp port to hub.Share.Port I can download files but can't use 
search. If I set udp port to hub.Share.Port I can search but can't 
download anything. If I not set hub.Share.Port I cant both search and 
download files.

What steps will reproduce the problem?
1. Upload something
2. When uploading it eats 100Kb per second more memory
3. After upload it dont releases memory.

What is the expected output? What do you see instead?
I think it should release unused memory

What version of the product are you using? ~~(Do not write latest)~~
SVN r526

On what operating system?
Windows 7100

Call Stack? ~~(Line numbers and exception type helps much)~~
After some time it throws OUT OF MEMORY exception.

Please provide any additional information below.
after 5-10 minuets of uploading for different users, my program uses 200-
600Mb of RAM.

In file AdcProtocol.cs at line 1211: 

Update(con, new FmdcEventArgs(Actions.TransferRequest, new
TransferRequest(usr.ID, hub, usr.UserInfo, true)));

if (usr.UserInfo.ContainsKey(UserInfo.SECURE))
    hub.Send(new RCM(usr.ID, hub, hub.Me.ID, usr.ID));
else
    hub.Send(new RCM(usr.ID, hub, "ADCS/0.10", hub.Me.ID, usr.ID));
break;


Should be:

if (usr.UserInfo.ContainsKey(UserInfo.SECURE))
    hub.Send(new RCM(usr.ID, hub, "ADCS/0.10", hub.Me.ID, usr.ID));
else
    hub.Send(new RCM(usr.ID, hub, hub.Me.ID, usr.ID));
break;


What version of the product are you using?
Flowlib (20080628)

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?


Please provide any additional information below.

line 216 transfernmdcprotocol: 
using (System.IO.FileStream fs =
System.IO.File.OpenWrite(trans.DownloadItem.ContentInfo.Get(ContentInfo.STORAGEP
ATH)))

file is being used by someone else exception

What steps will reproduce the problem?
1. Download file
2. Try browsing directory where file is being downloaded

What version of the product are you using? On what operating system?
SVN 247

I am trying to build a bot for a ADCS hub. The hub is using a self signed
SSL certificate and on connecting the following unhanded exception stops
execution:

System.Security.Authentication.AuthenticationException: The remote
certificate is invalid according to the validation procedure.

I tried XMPL which also uses flowlib to see if it was just wrong coding on
my behalf but this is the XMPL dump:

*****************************
Version: 20090108
Is Mono?: False
Is Installed?: True
Connection Mode: 1
IP: 146.232.***.********************************
System.Security.Authentication.AuthenticationException: The remote
certificate is invalid according to the validation procedure.
   at System.Net.Security.SslState.CheckThrow(Boolean authSucessCheck)
   at System.Net.Security.SslState.get_SecureStream()
   at System.Net.Security.SslStream.Write(Byte[] buffer, Int32 offset,
Int32 count)
   at FlowLib.Connections.TcpConnection.Send(Byte[] raw) in
C:\Download\Code\FlowLib\trunk\FlowLib\Connections\TcpConnection.cs:line 608
   at FlowLib.Connections.TcpConnection.Send(IConMessage msg) in
C:\Download\Code\FlowLib\trunk\FlowLib\Connections\TcpConnection.cs:line 585
   at FlowLib.Connections.TcpConnection.SetupRecieveCallback(Socket sock)
in C:\Download\Code\FlowLib\trunk\FlowLib\Connections\TcpConnection.cs:line 467
   at FlowLib.Connections.TcpConnection.OnConnect(IAsyncResult ar) in
C:\Download\Code\FlowLib\trunk\FlowLib\Connections\TcpConnection.cs:line 435
   at System.Net.LazyAsyncResult.Complete(IntPtr userToken)
   at System.Net.ContextAwareResult.CompleteCallback(Object state)
   at System.Threading.ExecutionContext.Run(ExecutionContext
executionContext, ContextCallback callback, Object state)
   at System.Net.ContextAwareResult.Complete(IntPtr userToken)
   at System.Net.LazyAsyncResult.ProtectedInvokeCallback(Object result,
IntPtr userToken)
   at System.Net.Sockets.Socket.ConnectCallback()
   at System.Net.Sockets.Socket.RegisteredWaitCallback(Object state,
Boolean timedOut)
   at
System.Threading._ThreadPoolWaitOrTimerCallback.PerformWaitOrTimerCallback(Objec
t
state, Boolean timedOut)


I did find something which looks like a solution here:
http://blog.jameshiggs.com/2008/05/01/c-how-to-accept-an-invalid-ssl-certificate
-programmatically/

Though I do not have the skill required to implement that into flowlib

line 365 in hubnmdcmessages svn 111: address = new
System.Net.IPEndPoint(ip, port);

crashes on negative port

What steps will reproduce the problem?
Happend twice while being connected to our Aquila testhub, both times from
exPERten as sender ip.

What is the expected output? What do you see instead?
No crash :P

What version of the product are you using? On what operating system?
SVN 111

Please provide any additional information below.

What steps will reproduce the problem?
1. Add download from one user and let it start downloading (finish create
file and actually start downloading)
2. Download filelist from different user

What is the expected output? What do you see instead?
Expected output: Continue download of file from user 1, and download
filelist from user 2.
Instead: Crash

What version of the product are you using? On what operating system?
SVN 288

Please provide any additional information below.
KeyNotFoundException PropertyContainer.cs line 135

    [External Code] 
>
FlowLib.dll!FlowLib.Containers.PropertyContainer<string,string>.this[string].get
(string
key = "tth") Line 135 + 0xd bytes   C#

FlowLib.dll!FlowLib.Containers.ContentInfo.Compare(FlowLib.Containers.ContentInf
o
x = {FlowLib.Containers.ContentInfo}, FlowLib.Containers.ContentInfo y =
{FlowLib.Containers.ContentInfo}) Line 191 + 0x24 bytes C#

FlowLib.dll!FlowLib.Containers.DownloadItem.Compare(FlowLib.Containers.DownloadI
tem
x = {FlowLib.Containers.DownloadItem}, FlowLib.Containers.DownloadItem y =
{FlowLib.Containers.DownloadItem}) Line 242 + 0x35 bytes    C#
    FlowLib.dll!FlowLib.Containers.DownloadItem.Compare(object x =
{FlowLib.Containers.DownloadItem}, object y =
{FlowLib.Containers.DownloadItem}) Line 265 + 0xe bytes C#
    FlowLib.dll!FlowLib.Containers.DownloadItem.CompareTo(object obj =
{FlowLib.Containers.DownloadItem}) Line 271 + 0xa bytes C#
    [External Code] 

FlowLib.dll!FlowLib.Managers.DownloadManager.AddDownload(FlowLib.Containers.Down
loadItem
d = {FlowLib.Containers.DownloadItem}, FlowLib.Containers.Source s =
{Source[202.173.151.148:3126, Carraya]}) Line 166 + 0x10 bytes  C#

Nothing.exe!Nothing.Managers.TransferManager.DownloadFilelist(Nothing.HubGui.Hub
Form
hub = {Nothing.HubGui.HubForm, Text: [-SandSlottet-] - People will forget
what you said to them, but never how you made them feel}, string id =
"Carraya") Line 267 + 0x4c bytes    C#

Nothing.exe!Nothing.HubGui.HubUserListControl.FilelistMenuItem_Click(object
sender = {Download Filelist}, System.EventArgs e = {System.EventArgs}) Line
158 + 0x3e bytes    C#
    [External Code] 
    Nothing.exe!Nothing.Program.Main() Line 19 + 0x1a bytes C#
    [External Code] 

*What steps will reproduce the problem?*
1. Join hub
2. Start downloading big (more 20 Mb) file

*What is the expected output?*
Expecting file download. 
*What do you see instead?*
{"Process unable to access file {file name} because it used by another 
process."}

*What version of the product are you using?*
Flowlib 20090203 SVN + Share file from Issue 19

*On what operating system?*
Windows Vista SP1, UAC active

*Call Stack?*
   в System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   в System.IO.FileStream.Init(String path, FileMode mode, FileAccess 
access, Int32 rights, Boolean useRights, FileShare share, Int32 
bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String 
msgPath, Boolean bFromProxy)
   в System.IO.FileStream..ctor(String path, FileMode mode, FileAccess 
access, FileShare share)
   в System.IO.File.OpenWrite(String path)
   в FlowLib.Protocols.TransferNmdcProtocol.ParseRaw(Byte[] b, Int32 
length) в C:\Users\Erty Hackward\Documents\Visual Studio 2008\Projects
\FlowLib\FlowLib\Protocols\transfernmdcprotocol.cs:line 274
   в FlowLib.Connections.TcpConnection.OnRecievedData(IAsyncResult ar) в C:
\Users\Erty Hackward\Documents\Visual Studio 2008\Projects\FlowLib\FlowLib
\Connections\TcpConnection.cs:line 518
   в System.Net.LazyAsyncResult.Complete(IntPtr userToken)
   в System.Net.ContextAwareResult.CompleteCallback(Object state)
   в System.Threading.ExecutionContext.runTryCode(Object userData)
   в 
System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup
(TryCode code, CleanupCode backoutCode, Object userData)

File transfernmdcprotocol.cs line 274 column 40

*Please provide any additional information below.*
fadil.khodabuccus found this bug too at 2009-02-10 (FAQ section)

DownloadItem.cs Line 230
should be 
if(segmentsDownloaded==null)  segmentsDownloaded = new 
BitArray((int)segCount);

If DownloadItem deserialized it contains segmentsInProgress equals to null 
but segmentsDownloaded is loaded from xml and should not be replaced with 
new object.

Function hub.GetUserById not returns user by StoreID.

UserID field in SearchResultInfo class does not allows to get User object 
to start downloading from that user.

What steps will reproduce the problem?
[2008-01-01 17:37] <Carraya> I still however get false for both IsOperator
and IsSetOp even after oplist is sent
[2008-01-01 17:37] <Carraya> in case Actions.OpUsers:
[2008-01-01 17:38] <Carraya> even for the ids in oplist I get false
[2008-01-01 17:41] <Flow84> hmm...
[2008-01-01 17:41] <Flow84> i may have forgot something in OnUpdate in Hub.
[2008-01-01 17:41] <Carraya> and I often get null for  u =
hub.GetUserById(oplist[i]);
[2008-01-01 17:42] <Carraya> actually almost all the time except for
chatrooms in ynhub
[2008-01-01 17:42] <Flow84> what even do you listen on?
[2008-01-01 17:42] <Carraya> one sec
[2008-01-01 17:42] <Carraya> hubConnection.Update += new
FlowLib.Events.FmdcEventHandler(Hub_InUpdate);

What is the expected output? What do you see instead?
Expected output is userinfo ui != null for hub.GetUserById(oplist[i]);
and true for UserInfo.IsOperator

What version of the product are you using? On what operating system?
SVN 100

                case Actions.OpUsers:
                    string[] oplist = (string[])e.Data;
                    for (int i = 0; i < oplist.GetUpperBound(0); i++)
                    {
                        u = hub.GetUserById(oplist[i]);

                        // FIX ME
                        if (u != null) // OFTEN NULL EXCEPT YnHub ChatRoom
                        {
                            // FIX ME
                            bool test = u.UserInfo.IsOperator; // always false
                            test = u.UserInfo.IsSetOP; // always false
                            userlist.Invoke(UserAddDelegate, new Object[] {
u.UserInfo });
                        }
                    }
                    break;

Please provide any additional information below.

1) change ActiveDownloadFilelistFromUser.cs like this:

                case Actions.UserOnline:
                    UserInfo usrInfo = e.Data as UserInfo;
                    if (usrInfo == null) return;
                    users.Enqueue(usrInfo.ID);
                    bool hasMe = (hub.GetUserById(hub.Me.ID) != null);
                    if (hasMe && users.Count > 0)
                        Console.WriteLine(users.Count + " users");
                    while (hasMe && users.Count > 0)
                    {
                        string usrId = users.Dequeue();
                        User usr = null;
                        if ((usr = hub.GetUserById(usrId)) != null)
                        {
                            ContentInfo info = new ContentInfo
(ContentInfo.FILELIST, BaseFilelist.XMLBZ);
                            info.Set(ContentInfo.STORAGEPATH, currentDir + 
@"Filelists\" + usr.ID + ".dcxml.bz2");
                            Console.WriteLine(usr.ID);
                            DownloadItem dwnItem = new DownloadItem(info);
                            downloadManager.AddDownload(dwnItem, new Source
(hub.RemoteAddress.ToString(), usr.ID));
                            UpdateBase(this, new FmdcEventArgs
(Actions.StartTransfer, usr)); // Start transfer to user
                            for (int i = 0; i < 300; i++)
                                if (downloadManager.ContainsDownload
(dwnItem))
                                    System.Threading.Thread.Sleep(100);
                            downloadManager.RemoveDownload(dwnItem);  // 
to avoid other bug during saving many filelists at one time
                        }
                    }
                    break;

2) also add next line in the beginning of this class
        public Queue<string> users = new Queue<string>();

3) use address "127.0.0.1" for hub IP

- this code successfully connects to my hub, shows all nicks on the hub,
but downloads filelist only from one IP (localhost)
and can't download filelists for others.

Why? - I don't know.
What happens? - simply exiting from the cycle by timeout (30 seconds) - 
for other users (without any program exeptions).
What is the expected output? - downloading all filelists, from all users.
What do you see instead? - downloading filelist only from one user - with 
the same IP as the hub.
What version of the product are you using? - FlowLib 20080628.
On what operating system? - Windows XP Eng + Russian MUI + Russian system 
locale.
Call Stack? - there are no any exceptions.
Other info - my DC++ hub PtokaX 0.3.6.0,
VS 2005, and this code are running on the same computer.

What steps will reproduce the problem?
1. Join hub
2. Start dowbnloading big file with many sources 4 GB /80 Sources
3. Search for alternatives, add all sources to download item
4. call start transfer for all sources

What is the expected output? What do you see instead?
it should work i think=)

What version of the product are you using?
SVN r482

On what operating system?
Windows 7 7022

Call Stack? ~~(Line numbers and exception type helps much)~~
First IOException:
The process cannot access the file '{File path}' because it is being used 
by another process.
File: transfernmdcprotocol.cs Line: 278


Second SocketException:
remote host has closed connection
File: Connections\TcpConnectionListener.cs Line: 91

Please provide any additional information below.
First of all i got exception №1, i have avoided it using limit for active 
transfers (40)
after that it start downloading correctly (using 30-40 sources), but some 
time later i got second exception. I have changed 
catch (ObjectDisposedException)
to
catch (Exception)
and then it looks like starts downloading normally

What steps will reproduce the problem?
I'm not sure. I think exception details is enough to solve issue.

What version of the product are you using? ~~(Do not write latest)~~
SVN r482

On what operating system?
Windows Vista SP1

Call Stack? ~~(Line numbers and exception type helps much)~~
hubnmdcmessages.cs Line 476
Exception: Input string has wrong format

tmp[1] = "45$SR"
raw = "$Search 10.108.45.159:45$SR Crazy Pictures\Starcraft 2\ss3-
hires.jpg�581886 12/15�TTH:EPBWT243YWN3IOYDEUNMBNUWW3NYYIYKUJRVSKI 
(10.110.1.10:411)"

What steps will reproduce the problem?
1. Load share
2. Add files to share (it will start hashing)
3. Wait several seconds
4. Add another directory to share


What is the expected output? What do you see instead?
When share trying to save itself it throws exception

What version of the product are you using? ~~(Do not write latest)~~
SVN r493

On what operating system?
Windows 7

Call Stack? ~~(Line numbers and exception type helps much)~~
Share.cs Save method
foreach (KeyValuePair<string, ContentInfo> item in share)
- collection has been changed

Please provide any additional information below.
Think it should in lock section

What steps will reproduce the problem?
1. try to download anything in nmdc
2. on Protocol_ChangeDownloadItem you should find DownloadItem from 
download manager, but you can not because trans.Source.UserID is actually 
StoreID instead of ID

What is the expected output? What do you see instead?
I think it should be ID or how I should get DownloadItem in this case?

What version of the product are you using? ~~(Do not write latest)~~
SVN r532

On what operating system?
Windows 7 7100

Possible the issue is in "get" section of TransferRequest.Source property

What steps will reproduce the problem?
1. Try to use FileOperation.SaveObject when windows start to shutdown


What is the expected output? What do you see instead?
It should work. XmlSerializer fails when trying to create new instance.

What version of the product are you using? ~~(Do not write latest)~~
SVN r522

On what operating system?
Windows XP, Windows Vista, Windows 7


Please provide any additional information below.
This is not FlowLib bug, it is internal NET Framework bug. It occurs 
because XmlSerializer trying to create new assembly instead getting it from 
cache. This bug can be avoided by using next fix:

FileOperation.cs Line 33 should be:
XmlSerializer s = new XmlSerializer(obj.GetType());
instead of
XmlSerializer s = new XmlSerializer(obj.GetType(), new XmlRootAttribute());

At this case XmlSerializer will take generated assembly from cache.
Of course line 44 should be fixed too.

You can find addition information here:
http://social.msdn.microsoft.com/Forums/ru-
RU/netfxremoting/thread/6b7f1635-6f01-49e1-9929-7652e2d084be

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


What version of the product are you using? ~~(Do not write latest)~~


On what operating system?


Call Stack? ~~(Line numbers and exception type helps much)~~


Please provide any additional information below.

What steps will reproduce the problem?
1. Start download any big file

When download one file from one source TaskManager shows 100% processor 
usage.

What version of the product are you using?
SVN r478

On what operating system?
Windows Vista Sp1

Please provide any additional information below.
Then download starts, my gui works very slow, Windows Forms Timers pass 
their ticks. If I move my main form over screen it lags. I have Pentium 4 
3.2 GHz dual core processor, and 1 GB RAM. I'm tryed to find place where 
thread created for each transfer but failed.

What steps will reproduce the problem?
1. Join any nmdc hub using Cyryllic symbols DisplayName. for example = 
"Владислав"
2. Try to upload filelist to other client


- What is the expected output? What do you see instead?
- Expecting file upload. Nothing happens.

using FlowLib SVN 20090203 + Share file from Issue 19.

Windows Vista Sp1

No any exceptions triggered.

I'm trying to download filelist from flowlib based client using FlyLinkDC 
(active connection), all works normally while nick does not contain any 
cyryllic symbols.
By default flowlib cant connect to hub using such nick. to solve this I 
use following code:

hub.Connect();
if (hub.Protocol is HubNmdcProtocol)
{
    HubNmdcProtocol prot = (HubNmdcProtocol)hub.Protocol;
    prot.Encoding = Encoding.Default;
}

Hub_Protocol_Update event fires
Protocol_ChangeDownloadItem event dont fires, but should

I can not use IShare interface because it is not completly realized.
For example hubnmdcprotocol.cs line 360. This is code that handles search 
messages. 
In my case there is no need to iterate through all items in share because 
search can 
be done much faster in SQL (I'm using SQL share)
Next BaseFileList.cs function CreateFilelist() - this function requires 
share object 
to implement ICollection interface. And then it trying to sort content. 
This work 
also can be done by SQL.
My suggestion is to create two virtual functions in Share class(or in 
IShare). First 
is Search and second is GetVirtualList. I have already done this work, you 
can see it 
in my example (when I tried to download all filelists om hub) Both 
functions located 
at document bottom.

What steps will reproduce the problem?
1. Use the attached code with r563
2. Connect to opendchub
3. Request user filelist

What is the expected output?
Downloaded filelist

What do you see instead?
Error

What version of the product are you using? 
r563

On what operating system?
Fedora 15 x64

Call Stack? (Console output)
bofh tool
OUT: HSUP ADBAS0 ADBASE ADTIGR

IN: $Lock Sending_key_isn't_neccessary,_key_won't_be_checked. Pk=Same_goes_here.
OUT: $Supports NoHello NoGetINFO |
OUT: $Key 
Ác° Ðp�ƒCàÁbc¡Ñ”5²�°/%DCN096%//%DCN000%//%DCN096%/a/%DCN000%/!1°U
7CàÁb‚��”5²Óp£Ã°Ð/%DCN096%/€à�¤|
OUT: $ValidateNick FlowLib|
IN: $HubName Open DC Hub
IN: <Hub-Security> This hub is running version 0.8.2 of Open DC Hub.
IN: $Hello FlowLib
OUT: $Version 1.0091|
OUT: $GetNickList|
OUT: $MyINFO $ALL FlowLib <FlowLib,M:A,H:1/0/0,S:0>$ $�$$0$|
IN: Welcome to the hub. Enjoy your stay.
IN: $NickList FlowLib$$bofh$$
IN: 
IN: $OpList 
IN: 
IN: $MyINFO $ALL FlowLib <FlowLib,M:A,H:1/0/0,S:0>$ $�$$0$
OUT: $ConnectToMe bofh 127.0.0.1:12345|
DIS:127.0.0.146099FlowLib.Utils.FmdcException: Exception of type 
'FlowLib.Utils.FmdcException' was thrown.
action=21 data=bofh

What steps will reproduce the problem?
1. Add several DownloadItems with one source to DownloadManager
2. Remove one DownloadItem


What is the expected output? What do you see instead?
After remove one DownloadItem sourceItems will be empty but should not.


What version of the product are you using?
SVN r478

On what operating system?
Windows Vista SP1

Please provide any additional information below.
I think it can be fixed by changing in RemoveDownload implementation 
sourceItems.Remove(var);
to
if(tmpSrc.Count==0) sourceItems.Remove(var);