Argo CI should set branch parameter while launching CI workflow.

Environments:

helm version :
version.BuildInfo{Version:"v3.2.4", GitCommit:"0ad800ef43d3b826f31a5ad8dfbb4fe05d143688", GitTreeState:"clean", GoVersion:"go1.13.12"}

helm repo :
argo https://argoproj.github.io/argo-helm/

install command:
helm install argo-ci argo/argo-ci --version 0.1.6

Result:
Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(ServiceAccount.metadata): unknown field "namspace" in io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta

Helm Debug Message:
helm install argo-ci argo/argo-ci --version 0.1.6 --dry-run --debug

install.go:159: [debug] Original chart version: "0.1.6"
install.go:176: [debug] CHART PATH: /root/.cache/helm/repository/argo-ci-0.1.6.tgz

Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(ServiceAccount.metadata): unknown field "namspace" in io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta
helm.go:84: [debug] error validating "": error validating data: ValidationError(ServiceAccount.metadata): unknown field "namspace" in io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta
helm.sh/helm/v3/pkg/kube.scrubValidationError
/home/circleci/helm.sh/helm/pkg/kube/client.go:570
helm.sh/helm/v3/pkg/kube.(*Client).Build
/home/circleci/helm.sh/helm/pkg/kube/client.go:159
helm.sh/helm/v3/pkg/action.(*Install).Run
/home/circleci/helm.sh/helm/pkg/action/install.go:254
main.runInstall
/home/circleci/helm.sh/helm/cmd/helm/install.go:229
main.newInstallCmd.func1
/home/circleci/helm.sh/helm/cmd/helm/install.go:117
github.com/spf13/cobra.(*Command).execute
/go/pkg/mod/github.com/spf13/[email protected]/command.go:842
github.com/spf13/cobra.(*Command).ExecuteC
/go/pkg/mod/github.com/spf13/[email protected]/command.go:950
github.com/spf13/cobra.(*Command).Execute
/go/pkg/mod/github.com/spf13/[email protected]/command.go:887
main.main
/home/circleci/helm.sh/helm/cmd/helm/helm.go:83
runtime.main
/usr/local/go/src/runtime/proc.go:203
runtime.goexit
/usr/local/go/src/runtime/asm_amd64.s:1357
unable to build kubernetes objects from release manifest
helm.sh/helm/v3/pkg/action.(*Install).Run
/home/circleci/helm.sh/helm/pkg/action/install.go:256
main.runInstall
/home/circleci/helm.sh/helm/cmd/helm/install.go:229
main.newInstallCmd.func1
/home/circleci/helm.sh/helm/cmd/helm/install.go:117
github.com/spf13/cobra.(*Command).execute
/go/pkg/mod/github.com/spf13/[email protected]/command.go:842
github.com/spf13/cobra.(*Command).ExecuteC
/go/pkg/mod/github.com/spf13/[email protected]/command.go:950
github.com/spf13/cobra.(*Command).Execute
/go/pkg/mod/github.com/spf13/[email protected]/command.go:887
main.main
/home/circleci/helm.sh/helm/cmd/helm/helm.go:83
runtime.main
/usr/local/go/src/runtime/proc.go:203
runtime.goexit
/usr/local/go/src/runtime/asm_amd64.s:1357

Please help me to find out some clues!

Helm install is failing with error

k8smaster@k8smaster:~$ helm install argo/argo-ci --name argo-ci
Error: Job failed: DeadlineExceeded

Here are pod logs,

Error from server (Forbidden): error when retrieving current configuration of:
Resource: "apiextensions.k8s.io/v1beta1, Resource=customresourcedefinitions", GroupVersionKind: "apiextensions.k8s.io/v1beta1, Kind=CustomResourceDefinition"
Name: "workflows.argoproj.io", Namespace: ""
Object: &{map["apiVersion":"apiextensions.k8s.io/v1beta1" "kind":"CustomResourceDefinition" "metadata":map["name":"workflows.argoproj.io" "annotations":map["kubectl.kubernetes.io/last-applied-configuration":""]] "spec":map["group":"argoproj.io" "names":map["plural":"workflows" "shortNames":["wf"] "kind":"Workflow"] "scope":"Namespaced" "version":"v1alpha1"]]}
from server for: "STDIN": customresourcedefinitions.apiextensions.k8s.io "workflows.argoproj.io" is forbidden: User "system:serviceaccount:default:default" cannot get resource "customresourcedefinitions" in API group "apiextensions.k8s.io" at the cluster scope

Looks like issue with the roles. I just followed the instructions present in README file. Are there any steps missing, before hitting helm installation? Please help!

I'd love to give argo-ci a try, but the instructions on https://argoproj.github.io/argo-ci rely on an outdated helm chart so I'm requesting a refresh for the "try-it-out" instructions.

Of course, I'd love to see more docs in general, but this could get me at least past the initial hurdle.

Argo CI launches workflow using destination repo instead of source repo for PR. Such workflow always fail because scr commit don't exist in destination repo.

Argo CI should label CI workflow with workflow controller instanceid. This is required to support installing Argo CI in a cluster with multiple argo workflow controllers.

Create build workflow and configure integration with argo.applatix.net

After entering username and password, I am receiving this error when trying to login with the CLI after initial install:

rpc error: code = FailedPrecondition desc = transport: received the unexpected content-type "text/plain; charset=utf-8"

As I read somewhere, Argo CI has been deprecated and superseded by Argo Events which can be used together with Argo Workflows to achieve CI.

The first time I stumbled over Argo CI, I was very confused. It would be helpful if you could write a deprecation notice in the readme and point to Argo Events as replacement.

Will private repositories be supported with k8s secret?

I have noticed argo-ci job webhook posting can take extremely long to complete. In the following case, it takes 1 hour:

$ argo get argo-ci-ctfws -o wide
Name:             argo-ci-ctfws
Namespace:        default
ServiceAccount:   default
Status:           Succeeded
Created:          Tue Jan 16 14:48:10 -0800 (1 hour ago)
Started:          Tue Jan 16 14:48:10 -0800 (1 hour ago)
Finished:         Tue Jan 16 15:55:41 -0800 (7 minutes ago)
Duration:         1 hours 7 minutes 31 seconds
Parameters:
  revision:       f2b8f248ab8d483e0ba41a287611393500c7b507
  repo:           https://github.com/argoproj/argo.git

STEP                                               PODNAME                   DURATION  ARTIFACTS  MESSAGE
 ✔ argo-ci-ctfws                                                             8m
 └-·-✔ ci(make controller-image)                   argo-ci-ctfws-1082140864  7m
   ├-✔ ci(make executor-image)                     argo-ci-ctfws-3448139115  8m
   ├-✔ ci(make cli-linux)                          argo-ci-ctfws-2033759993  2m
   ├-✔ ci(make cli-darwin)                         argo-ci-ctfws-172564014   4m
   ├-✔ ci(make ui-image)                           argo-ci-ctfws-3026041666  7m
   ├-✔ ci(dep ensure && make lint)                 argo-ci-ctfws-4148832474  1m
   ├-✔ ci(dep ensure && make test)                 argo-ci-ctfws-3336451261  3m
   └-✔ ci(dep ensure && ./hack/verify-codegen.sh)  argo-ci-ctfws-1510344862  53s

 ✔ onExit                                                                    59m
 └---✔ dc131471-8e47-41c9-99a4-fca7bf1ca0f3        argo-ci-ctfws-250292847   59m

When I run argo logs against the pod, it returns no output.

Argo CI sets status for commit in src repo instead of dst repo for cross repo commits. Status should be set for commit in PR destination repository.

:(

Why are repos configured via the UI? Why not another CRD or CRD+Secret?

I am very interested in Argo for declarative workflows, and it seems like it's opinionated in the interest of being declarative and repeatable, so I'm quite curious why argo-ci seems to take a slightly different approach.

Thanks!

Do you plan any interaction with Draft?

Gitlab support could be integrated by ignoring the gitlab-ci.yml. We could use the same polling method and authentication as gitlab and provide the same level of integration that gitlab-ci does with the UI.

User should be able to configure webhook using Argo CI management UI instead of doing it manually using Github UI

Argo CI should be able to handle events from private github repositories

It'd be great to have a polling mode instead of webhook notification mode for more generic implementation scenarios (without GitHub).

Tracking issue for historical builds data support. Argo CI should automatically remove completed workflows from kubernetes and move to persistent data storage.

• Prepare design document

Hi,

Amazing stuff, good work!
Any chance you support bitbucket private repositories webhooks soon?

Hi,

I would like to know if argo-ci does support kubernetes 1.9 or later?
After installed argo-ci I'm getting the error below in the argo-ci-ci pod.

no such file or directory, open '/var/run/secrets/kubernetes.io/serviceaccount/ca.crt'

I think the path has been changed last year to /var/lib/kubelet/pki .

Full log:
kubectl logs -n argoproj argo-ci-ci-74c8cc8859-c758h {"name":"add-status","hostname":"argo-ci-ci-74c8cc8859-c758h","pid":6,"level":50,"err":{"message":"ENOENT: no such file or directory, open '/var/run/secrets/kubernetes.io/serviceaccount/ca.crt'","name":"Error","stack":"Error: ENOENT: no such file or directory, open '/var/run/secrets/kubernetes.io/serviceaccount/ca.crt'\n at Error (native)\n at Object.fs.openSync (fs.js:640:18)\n at Object.fs.readFileSync (fs.js:508:33)\n at Object.getInCluster (/app/node_modules/kubernetes-client/lib/config.js:35:17)\n at Object.createKubeCrdClient (/app/util.js:48:62)\n at Object.<anonymous> (/app/app.js:37:36)\n at next (native)\n at /app/app.js:7:71\n at __awaiter (/app/app.js:3:12)\n at Object.createServers (/app/app.js:36:12)","code":"ENOENT"},"msg":"ENOENT: no such file or directory, open '/var/run/secrets/kubernetes.io/serviceaccount/ca.crt'","time":"2019-01-24T04:48:23.231Z","v":0}

Instead of forcing a username/password when setting up the GitHub webhook, allow for the use a GitHub Personal Access Token instead.

Is there any plan to support Dockerhub repositories?