arionum / json-rpc Goto Github PK

I propose that we remove the bitcoin-lib package from Composer. The only place the bitcoin library seems to be used is on line 430 of index.php.

RawTransaction::encode($t)

This package has been deprecated for 3 years (Bit-Wasp/bitcoin-lib-php#104), and shouldn't be used. It's also incompatible with PHP 7.2 due to its explicit requirement of the php-mcrypt extension which is no longer available in PHP.

They recommend moving to the bitcoin-php package, but as the only feature used from it was the RawTransaction which no longer seems to be a feature in the new package, we could probably quite easily remove the use of this method and custom-write a new implementation to replace it.