arirusso / midi-eye Goto Github PK

View Code? Open in Web Editor NEW

24.0 3.0 1.0 88 KB

Ruby MIDI input event listener

License: Other

Ruby 100.00%

listener event-listener midi ruby midi-eye midi-controller midi-messages midi-device hardware music

midi-eye's Issues

Overflow(?) Thread Hang Issue

Consider the following script, adapted from the main example in the doc:

require "midi-eye"
#puts UniMIDI::Input.gets
@input = UniMIDI::Input.use(2)
midi_listener = MIDIEye::Listener.new(@input)
midi_listener.listen_for(:class => [MIDIMessage::NoteOn, MIDIMessage::NoteOff]) {|event| puts event[:message]}
midi_listener.run

When playing a midi controller very quickly (arguably unnecessarily so), the interpreter hangs without failure or exception, requiring a cmd interrupt. This may just be a limitation of Ruby threads, but I'm positing the potential issue nevertheless.

Cannot `run` due to nil device buffer

Code:

def find_mpk(io)
  io.all.find { |device| device.name.downcase.strip.include?("mpk mini") }
end

input = find_mpk(UniMIDI::Input)

midi_listener = MIDIEye::Listener.new(input)
midi_listener.listen_for(:class => [MIDIMessage::NoteOn, MIDIMessage::NoteOff]) {|event| puts event[:message]}
midi_listener.run

Error:

Traceback (most recent call last):
        7: from C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/midi-eye-0.3.10/lib/midi-eye/listener.rb:137:in `block in listen'
        6: from C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/midi-eye-0.3.10/lib/midi-eye/listener.rb:126:in `listen_loop'
        5: from C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/midi-eye-0.3.10/lib/midi-eye/listener.rb:126:in `loop'
        4: from C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/midi-eye-0.3.10/lib/midi-eye/listener.rb:127:in `block in listen_loop'
        3: from C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/midi-eye-0.3.10/lib/midi-eye/listener.rb:106:in `poll'
        2: from C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/midi-eye-0.3.10/lib/midi-eye/listener.rb:106:in `each'
        1: from C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/midi-eye-0.3.10/lib/midi-eye/listener.rb:107:in `block in poll'
C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/midi-eye-0.3.10/lib/midi-eye/source.rb:24:in `poll': undefined method `length' for nil:NilClass (NoMethodError)

Source:

midi-eye/lib/midi-eye/source.rb

Line 24 in dc9f2fa

messages = @device.buffer.slice(@pointer, @device.buffer.length - @pointer)

Note that changing the input to input = UniMIDI::Input.first allows the code to work just fine,.

Potential MIDIMessage content/logging error

Consider the following short script (adapted from the example given in the doc)

require "midi-eye"

@input = UniMIDI::Input.use(1)
midi_listener = MIDIEye::Listener.new(@input)
midi_listener.listen_for {|event| puts event[:message]}
midi_listener.run

When running, tied to a device (Alesis V49) I know to be in position 1, to save testing time, I repeatedly hit 1 key. This is the resulting output:

#<MIDIMessage::NoteOn:0x000000000337c078>
#<MIDIMessage::NoteOff:0x0000000003445338>
#<MIDIMessage::NoteOff:0x0000000003454ef0>
#<MIDIMessage::NoteOff:0x00000000034642d8>
#<MIDIMessage::NoteOff:0x000000000344e618>
#<MIDIMessage::NoteOff:0x000000000342c1a8>
#<MIDIMessage::NoteOff:0x00000000033f65f8>
#<MIDIMessage::NoteOff:0x00000000033a7e30>
#<MIDIMessage::NoteOff:0x000000000337e260>
#<MIDIMessage::NoteOff:0x000000000335da10>
#<MIDIMessage::NoteOff:0x000000000332dea0>
#<MIDIMessage::NoteOff:0x0000000003112e40>
#<MIDIMessage::NoteOff:0x00000000030d4a00>
#<MIDIMessage::NoteOff:0x0000000002f8de30>
#<MIDIMessage::NoteOff:0x000000000345efb8>
...

I would expect both a NoteOn and a NoteOff for each key pressed.
If i start pressing keys "simultaneously" i get mixed messages, some NoteOn, others NoteOff, but once I return to pushing one key repeatedly, the behavior resurfaces.

Another device, a Novation Launchpad Pro, has the opposite issue, where one note is pressed repeatedly, NoteOn messages are the only messages shown.

I have confirmed both of my controllers are functioning on their respective ports with a program called MIDI-OX:

Alesis V49

TIMESTAMP IN PORT STATUS DATA1 DATA2 CHAN NOTE EVENT
 000008F5   5  --     92    37    13    3  G  3 Note On
 0000095D   5  --     82    37    00    3  G  3 Note Off
 00000FB7   5  --     92    37    15    3  G  3 Note On
 0000102B   5  --     82    37    00    3  G  3 Note Off
 0000117C   5  --     92    37    15    3  G  3 Note On
 000011E1   5  --     82    37    00    3  G  3 Note Off
 00001323   5  --     92    37    15    3  G  3 Note On
 0000138A   5  --     82    37    00    3  G  3 Note Off
 000014B0   5  --     92    37    14    3  G  3 Note On
 00001517   5  --     82    37    00    3  G  3 Note Off
 00001647   5  --     92    37    14    3  G  3 Note On
 000016AE   5  --     82    37    00    3  G  3 Note Off

Novation Launchpad Pro

TIMESTAMP IN PORT STATUS DATA1 DATA2 CHAN NOTE EVENT
 000004FC   3  --     98    45    4A    9  A  4 Note On
 00000578   3  --     98    45    00    9  A  4 Note Off
 0000071F   3  --     98    45    3B    9  A  4 Note On
 000007CF   3  --     98    45    00    9  A  4 Note Off
 000008D2   3  --     98    45    4A    9  A  4 Note On
 00000991   3  --     98    45    00    9  A  4 Note Off
 00000A6B   3  --     98    45    3B    9  A  4 Note On
 00000B21   3  --     98    45    00    9  A  4 Note Off
 00000BFA   3  --     98    45    4D    9  A  4 Note On
 00000C8F   3  --     98    45    00    9  A  4 Note Off

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.