armstrongj / sostore Goto Github PK

Why not using Python's UUID module for the "_random_id" function, instead of creating a random integer? Should be the more proper way :-)

Currently, the randomize args can be given for the insert function only. Thus, a random ID is only generated when "enforced" by the user. So when only creating a random ID once, it's more like creating an offset.

Probably it makes sense to move randomize to the Collection class as a class attribute. When creating an instance of the class with randomize=True, every ID is randomly chosen, which at the bottom line give true randomization.