arnarthor / bs-electron Goto Github PK

Hey @arnarthor
I'm working with this lib right now and wondering what path you might want to take for updates. I'm a little new to the electron world, so do you know if there's any issue to updating the electron dep for this library?

Currently it's set to ^2.0.8 in this repo, but I've had no trouble so far running it against ^4.0.4 in my fork https://github.com/Schmavery/bs-electron/blob/094ddbfbd5f6b930a0fdc57892050385f26f0308/package.json#L18

Does it make sense to submit a PR to update it?

(I was also wondering if there's a reason that you pushed the *.bs.js artifacts or if that was a mistake)

If that sounds good to you, I'd love to follow up with PRs with support for menus and whatever other functions we need to expose for our app.
Thanks for making this, saving a lot of time on my end already 😄