arschles / assert Goto Github PK

they should report one stack frame above. not sure if this is even possible to fix

The official Go FAQ outlines an Equaler interface that looks like this:

type Equaler interface {
    Equal(Equaler) bool
}

This library should provide that interface and check for it in assert.Equals calls. If both arguments are Equaler implementations, it should call expected.Equal(actual) instead of using reflect.DeepEqual.

This feature would allow people to write custom equality checks for use in tests and otherwise. It would help especially with testing equality on complex types like deeply nested structs or pointers.

It often doesn't make sense to fail a test because one iteration of a loop failed in a table driven test. It would be helpful to have some construct that you can create before the loop starts, report errors during iteration (concurrency safe) and then check afterward. Usage like this would be nice:

func TestExamples(t *testing.T) {
  loopChecker := assert.NewLoop()
  for exampleNum, exampleFunc := range examplesMap {
    // True() calls exampleFunc and returns its value. It calls t.Errorf if it returned false
    if !loopChecker.True(t, exampleNum, exampleFunc()) {
      continue
    }
  }
}
// ReportFatal() calls t.Fatalf if any errors were reported in the loop
loopChecker.ReportFatal(t, "examples")

The examples in the README suggest that you call functions like assert.NoErr(err), when it should be assert.NoErr(t, err).

• identical arbitrary structs don't work - they should do "deep equal"
• pointers should be traversed

also func Equal doesn't work when one of the parameters is nil

see deis/steward#235 (comment)

This build failure was discovered in PR #12, and the specific build failure is here: https://travis-ci.org/arschles/assert/jobs/168611811