arsen / image-optimizer Goto Github PK

The compression this tool achieves is awesome compared to ImageOptim without lossy compression. As soon as I allow ImageOptim to execute using lossy compression, I get similar results.

When the process runs it creates a tmp. directory which because of the dot at the end is an invalid name so it cannot be deleted at the end of the process. The trailing dot occurs because the results.files array contains relative paths that start with dots (eg ./images/file01.png) and this is appended to the ./tmp string to create the temporary directory.

The fix is to remove the leading dot prior to appending to the ./tmp variable.

This change needs to be made in several places within the image-optimize.js file. The reason I have not submitted this change as a pull request is that I am not in a position to test that the change still functions under Linux (or OSX) so I raised the issue here.

I have attached my altered file (please note that my changes were done in a rush to get the utility to work so I apologise if they are not elegant).

image-optimize.zip

Thanks for developing such a handy tool.

Using image-optimizer on a folder that was already optimized resulted in some files being bigger and having a negative percentage reduction. Instead of showing the negative percentage the program showed NaN%

`### Before optimizing ###
Files: 14
Total Size: 42kb

1. Processing file: images/1.png ... done! (0%)
2. Processing file: images/2.png ... done! (33%)
3. Processing file: images/3.png ... done! (NaN%)
4. Processing file: images/4.png ... done! (0%)
5. Processing file: images/5.png ... done! (NaN%)
6. Processing file: images/6.png ... done! (NaN%)
7. Processing file: images/7.png ... done! (52%)
8. Processing file: images/8.png ... done! (0%)
9. Processing file: images/9.png ... done! (0%)
10. Processing file: images/10.png ... done! (0%)
11. Processing file: images/11.png ... done! (0%)
12. Processing file: images/12.png ... done! (0%)
13. Processing file: images/13.png ... done! (NaN%)
14. Processing file: images/14.png ... done! (NaN%)

    After optimizing

    Files: 14
    Total Size: 24kb
    Total size reduced by: 17kb (42%)
    #########################
    Done copying files back to original location`