Examples in readme should be updated as Rpm is deprecated in favour to RpmAbstraction.Base.

Also please correct phrase about Storage implementation:

Then, you implement com.yegor256.rpm.Storage interface.

Storage from artipie.asto should be implemented.

When using NamingPolicy.Sha1Prefixed with Rpm, Repomd generate same SHA1 prefixes for all metadata files. The prefix should be different and depend on files content.

We are not filling all XML elements, as they are filled by the createrepo. Try to create a sample repository with createrepo and compare with what we are generating in our XML files. You will see that we don't fill every required element. Many of them are simply omitted. This is definitely a bug.

Let's create simple CLI tool to generate metadata for rpm packages. We need some class for this CLI with main() method (don't forget to define main method in pom.xml). It will be a wrapper for Rpm class. The syntax of this tool can be:

java -jar rpm-adapter.jar --naming-policy=simple --digest=SHA256 update ./package.rpm
# or
java -jar rpm-adapter.jar batchUpdate ./repo-dir/

So there are some options, one command, and one (or more) required positional arguments.

Options are:

• naming-policy - (optional, default simple) configures NamingPolicy for Rpm
• digest - (optional, default sha256) configures Digest instance for Rpm

Commands are:

• update - update one or more .rpm packages. It's equivalent of Rpm#update call
• batchUpdate - update specified directory as RPM repository, same as Rpm#batchUpdate call

Update asto dependency to fix artipie/asto#142 bug

Yegor Bugayenko should be changed to artipie.com

The puzzle 69-a899429c from #69 has to be resolved:

The puzzle was created by @g4s8 on 08-Apr-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Add optional support of prefixes for rpm files

The puzzle 32-75a1be06 from #32 has to be resolved:

The puzzle was created by HDouss on 12-Mar-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

I want to compare the all the repodata generate by run RpmTest.java to the repodata generate by artifacts,Can you help me achieve it？

Add a test to verify aarch64 rpm package works

Now integration test uses ProcessBuilder to execute docker. Testcontainers library provides higher abstraction level. It allows to create simple-in-use and reusable components. Also, it's designed for the unit testing purpose and provides lots of useful containers to create necessary environment for integration tests runs.

We need to rewrite existing code to start docker container with testcontainers library usage

The file v8location_rootfs-1213-lpu-1.0.0-3.aarch64.rpm causes unexpected failure in RPM adapter (version 0.51.1), exception:

'String index out of range: 0'
java.lang.StringIndexOutOfBoundsException: String index out of range: 0
        at java.lang.String.charAt(String.java:658) ~[?:1.8.0_212]
        at com.artipie.rpm.PrimaryProcessor.writeFiles(PrimaryProcessor.java:298) ~[rpm-adapter-0.51.1.jar:?]
        at com.artipie.rpm.PrimaryProcessor.lambda$null$5(PrimaryProcessor.java:199) ~[rpm-adapter-0.51.1.jar:?]
        at io.reactivex.internal.operators.completable.CompletableFromAction.subscribeActual(CompletableFromAction.java:34)

We should redefine this interface to support different business scenarios.
For example

class RepoData {
       String filename.
       InputStream fileStream.
}
RepoData repoData updata(RepoData[] repodata,String[] fileList,String model)

Description:
1、repodata:Existing repodata data needs to be transferd
2、filelist:Batch files need to generate repodata.
3、model: Add or delete files
4、we hope you can return the file stream.

The puzzle 69-b66a2919 from #69 has to be resolved:

The puzzle was created by @g4s8 on 08-Apr-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 41-ab144851 from #41 has to be resolved:

The puzzle was created by Victor Noël on 31-Mar-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 41-df9cd1a3 from #41 has to be resolved:

The puzzle was created by Victor Noël on 02-Apr-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Metadata file repomd.xml uses wrong links. E.g. if a source file has a name 123abc-filelists.xml (where 123abc is a hashsum of the file), and gzipped file has a name 567def-filelists.xml.gz, then repomd.xml will contains a link:

<data type="filelists">
  <location href="123abc-filelists.xml.gz" />
  <!-- other data -->
</data>

So it just appends .gz suffix to source file name instead of using correct gzipped file name.

Now rpm-adapter can generate the repodata files for a single rpm package. That's not enough.
We should support directory-level repodata for all the rpm packages in one directory. As createrepo did.

The puzzle 17-f66e78ab from #17 has to be resolved:

The puzzle was created by paulodamaso on 24-Mar-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Rpm.update() may not include references to primary, filelists and other to repomd.xml file in some cases, bug other metadata files seems to be ok.

1、We should support filelist feature.
2、It is necessary to be able to switch

See #63 (comment).

Let's add more tests for Rpm metadata generators:

• verify that it can update multiple files one by one
• verify that the content is correct for all supported digests and NamingPolicy implementations
• verify that it doesn't brake existing metadata in case of invalid package (e.g. generate metadata for first package, then try to generate for broken package)

The test com.artipie.rpm.RpmTest#addsSingleRpm is broken with error

java.io.FileNotFoundException: /etc/hosts (Too many open files)
	at java.base/java.io.FileInputStream.open0(Native Method)
	at java.base/java.io.FileInputStream.open(FileInputStream.java:213)
	at java.base/java.io.FileInputStream.<init>(FileInputStream.java:155)
	at io.netty.resolver.HostsFileParser.parse(HostsFileParser.java:132)
	at io.netty.resolver.HostsFileParser.parseSilently(HostsFileParser.java:89)
	at io.netty.resolver.HostsFileParser.parseSilently(HostsFileParser.java:76)
	at io.vertx.core.impl.resolver.DnsResolverProvider.<init>(DnsResolverProvider.java:123)
	at io.vertx.core.spi.resolver.ResolverProvider.factory(ResolverProvider.java:39)
	at io.vertx.core.impl.AddressResolver.<init>(AddressResolver.java:75)
	at io.vertx.core.impl.VertxImpl.<init>(VertxImpl.java:169)
	at io.vertx.core.impl.VertxImpl.vertx(VertxImpl.java:92)
	at io.vertx.core.impl.VertxFactoryImpl.vertx(VertxFactoryImpl.java:40)
	at io.vertx.core.impl.VertxFactoryImpl.vertx(VertxFactoryImpl.java:32)
	at io.vertx.core.impl.VertxFactoryImpl.vertx(VertxFactoryImpl.java:27)
	at io.vertx.core.Vertx.vertx(Vertx.java:75)
	at io.vertx.reactivex.core.Vertx.vertx(Vertx.java:118)
	at com.artipie.asto.fs.RxFile.<init>(RxFile.java:64)
	at com.artipie.rpm.Repomd.lambda$performUpdate$17(Repomd.java:197)

MacOS.

Rpm class generates 7 files on update():

• repomd.xml
• primary.xml
• primary.xml.gz
• filelists.xml
• filelists.xml.gz
• other.xml
• other.xml.gz

Most probably primary.xml, filelists.xml and other.xml files are not needed, since repomd.xml (the main metadata file) has a links only to .xml.gz versions of these files. Check if createrepo tool generates .xml versions of metadata files and don't upload it to storage in Repomd class if not needed.

The puzzle 69-5a24f18b from #69 has to be resolved:

The puzzle was created by @g4s8 on 08-Apr-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 30-6f533735 from #30 has to be resolved:

The puzzle was created by @g4s8 on 10-Mar-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 69-3c6bbf6c from #69 has to be resolved:

The puzzle was created by @g4s8 on 08-Apr-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

We should cleanup removed files on Rpm.batchUpdate, e.g. if repository has these files:

111.rpm
222.rpm
333.rpm

and user called Rpm.batchUpdate, these files will be added to metadata files. But if user removes any 222.rpm file:

111.rpm
333.rpm

and call Rpm.batchUpdate, then all metadata files will contains links to 222.rpm. We need to remove this file from metadata files too.

The puzzle 69-0165dd8a from #69 has to be resolved:

The puzzle was created by @g4s8 on 08-Apr-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Try to run RepoITCase and read the logs. You will see that dnf install doesn't really install the RPM file. Something is broken. Has to be fixed.

Can we rename class RepoUpdater to something more object-oriented? https://www.yegor256.com/2015/03/09/objects-end-with-er.html

Once the updata processing is complete, you need to return to the production file stream list. It includes other file stream/ primary file stream /repomd.xml file stream /filelist file stream.

Update to parent pom 0.3 and asto 0.14, downgrade to JDK8.

At the moment all tests work with a single .rpm file. We should extend them and see what happens when we have two or more different .rpm files.

test issues

When we use some custom naming policy for metadata files (e.g. hash prefixes), then Rpm can update these files but doesn't remove old versions, e.g. if we have files:

111-filelists.xml.gz
222-others.xml.gz
333-primary.xml.bz
package-one.rpm
repomd.xml

and add new package package-two.rpm, then filelists, others and primary will be updated and the name of them will change (because of hash based naming policy): 111-filelists -> aaa-filelists, 222-others -> bbb-others, 333-primary -> ccc-primary. repomd.xml will have correct links to new files, but old files will present in the storage:

111-filelists.xml.gz
222-others.xml.gz
333-primary.xml.bz
aaa-filelists.xml.gz
bbb-others.xml.gz
ccc-primary.xml.bz
package-one.rpm
repomd.xml

We need to remove old versions of files after such updates.

When we save three rpm package information by blockingStorage, then we use the rpm.batchUpdate to to generate the repodata,the problem happens as below:

1.The rpm-adapter generated three set of filelist/primary/other files, this is ok, but we prefer to get a set of repodata data.
2. the newest set of filelist/other/primary files only contains one package basic information, this point is wrong.

I have sent the incorrect repodata.rar to kirill， please refer to them.

fix it. @g4s8 thanks.

The Origin of RPM Content URL should be changed from https://docs.pulpproject.org/plugins/pulp_rpm/tech-reference/rpm.html to https://docs.pulpproject.org/en/2.9/plugins/pulp_rpm/tech-reference/rpm.html

As the first one isn't working

The puzzle 29-399d2455 from #29 has to be resolved:

The puzzle was created by @g4s8 on 13-Mar-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

I noticed in the code some places where doOnSuccess was used, but incorrectly IMHO.

Sometimes the argument passed to doOnSuccess returns a Completable, but it will never be executed because doOnSuccess does nothing with it. Also sometimes it makes more sense to use map when the passed lambda use the builder pattern.

In this module, we have that is wrong

We also have that should use map imho:

There are no other place in this module, but I think it would make sense to fix it also in other modules? there are no other module with this problem

Currently we use junit 4 in several unit tests. Actual runner is junit 5, but these tests use junit 4 and it works together with junit-vintage-engine.
Need to upgrade all tests to junit 5 and remove redundant libraries.

The puzzle 69-56010550 from #69 has to be resolved:

The puzzle was created by @g4s8 on 08-Apr-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.