arturoesquerra / geolift Goto Github PK
View Code? Open in Web Editor NEWGeoLift is an end-to-end geo-experimental methodology based on Synthetic Control Methods used to measure the true incremental effect (Lift) of ad campaign.
GeoLift is an end-to-end geo-experimental methodology based on Synthetic Control Methods used to measure the true incremental effect (Lift) of ad campaign.
Hi Arturo.
Thanks for this awesome package. We (Nico and I) have already shared with you some of these feedbacks and bugs but I'll post them here so we can do follow up:
GeoLiftData
class object to prevent input errors and less inputs, created when running GeoDataRead
(or equivalent)TrimControls
automatically (or warn user) when “too many cities” logic applies: (QT * 5 > QC) or if we already have nloc
results as vector N
. When too many cities are passed, the power calculations last ages.if (max(N) * 5 > length(unique(GeoTestData$location)))
GeoTestData <- TrimControls(GeoTestData)
@examples
into the documentation for every function.augsynth
library issue (changes without version change) [Force user to use version ebenmichael/augsynth@04daba1]NumberLocations
is not 100% usable on the pipeline (it is printed but not returned). What is the relevant outcome to return?GeoLiftPower.search
and the following message is printed: The treatment is larger than 80% of all available data.
plyr
dependency (not used + conflict with dplyr
)attachNamespace
inside functions. Functions have already been imported and when doing this in some servers, it will return errors instead of skipping.GeoDataRead
: Return error message when time_increments
value are not >1 (user inputs only 1 day). This function’s code is poor and extensive; also, you may use lubridate
functions instead.. already solves the dates logic. Even better if you force users to input time class vectors.GeoPlot
should return
the plot object, not print
it. Use can't custom plot if the object is not returned.ggplot2
).using test_locs = TRUE
) might be friendlier. You may use ggplot2::facet_grid
or patchwork
library or similar.GeoLiftPower.search
‘s output to give the user control size dimension.TrimControls
errors should be errors, not prints.utils::globalVariables
can be suppressed using .data$
README.md
file?Error in 1:nrow(BestMarkets_aux[, 1:1]): argument of length 0
CC: @nicocru
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.