aruniverse / adblock-detect-react Goto Github PK

Describe the bug
If the user is using tamper monkey to block ad, it can't be detected by this package

To Reproduce

1. install tamper monkey and find userscript, one sample tamper monkey code, also see this one

// ==UserScript==
// @name         test adsense
// @namespace    http://tampermonkey.net/
// @version      0.1
// @description  try to take over the world!
// @author       You
// @match        http://localhost:3000/*
// @icon         data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==
// @grant        none
// ==/UserScript==

(function() {
    'use strict';

window.addEventListener('load', function () {
   document.querySelectorAll('.adsbygoogle').forEach(a => a.remove())
})

})();

2. refresh the page, ads are gone but no prompt.

Expected behavior
It should be detected.

Screenshots
If applicable, add screenshots to help explain your problem.

Please complete the following information:

• OS: [macOS Ventura 13.1 (22C65)]
• Browser [Chrome]
• Browser Version [109.0.5414.119]
• Package Version [latest, 1.1.0]

Additional context
possible to add some patch in useEffect code to detect

    setTimeout(() => {
      const nodes=document.querySelectorAll(".adsbygoogle");
      if(nodes.length === 0) {
        setAdBlockDetected(true);
      }
    }, 3000);

It doesn't work anymore it bypass uBlock Origin, Brave blocker and more...

We have just had one of our clients, say to us that they use uBlock and they tried to do a payment on our website, which requires a popup to launch and them to verify the card owner details with their bank (normally done via SMS or an Auth app)

However uBlock blocked the popup, which has now caused the customer grief.

Describe the solution you'd like
We would like to be able to disable the submit button or/and display a banner saying please disable uBlock for this website.
this one (https://chrome.google.com/webstore/detail/ublock-origin/cjpalhdlnbpafiamejdnhcphjbkeiagm)

Pass config object to hook to re-check when browser urls changes.

When I make a route change with next-router system and the destination path is not in the adblock whitelist this module does not catch it

Unfortunately, it cannot catch uBlock-Origin.

Hello. I use a custom webpack configuration which doesn't support JSX (only JS/TS/TSX) and when I run a project I have this issue. It's clear what's wrong and a possible solution is to add a specific loader for JSX. But, is it possible to keep only js files inside this package?

Hello, Rejecting doubleclick.net will not affect the display of the ad, why check this address?

Some proxy software deny access to doubleclick.net by default, but it does not affect the display of ads.

It has false positives on my site. The ad is shown, but useDetectAdBlock() returns true.

I have AdBlock Plus installed on my browser and on my website it is not working anymore. It need's to be updated.

Hello. I think it’d be a good idea to add a possibility of setting the hook initial value.

By default the hook initial value is false. But in some cases it might be useful to set the initial value to null just to make sure that the hook did all to define is there Adblock or not.

This feature might be implement by passing a specific argument to the hook.

Hook example: useDetectAdBlock({ initialValue: null })

In code:

…useDetectAdBlock = ({ initialValue = false }) => {
  const [adBlockDetected, setAdBlockDetected] = useState(initialValue);
)}…

Describe the bug

It seems that the package currently does not detect when ads are blocked using brave shields.

To Reproduce

Steps to reproduce the behaviour:

1. Go to https://adblock-detect-react.vercel.app/ using a brave browser.
2. Enable brave shields.
3. See the ad blocker not being detected.

Expected behaviour

The brave shields adblocker should be detected.

Please complete the following information:

• OS: Linux.
• Browser: Brave
• Browser Version: Version 1.48.158 Chromium: 110.0.5481.77 (Official Build) (64-bit)
• Package Version: v1.1.0

Additional context

I tried to find a way to detect when ad blocking is enabled in brave but could not yet find a way. There seems to be a bold object on the navigator, but it doesn't contain any shield information (see brave/brave-browser#10165 (comment)).