aryehraber / statamic-splash Goto Github PK

I just noticed the addon is saving approx 130 lines of data to the entry for a single image... do you think we could trim this down? a lot of that information isn't needed.

Perhaps a config file that stores an array of values to save, and the default can be the bare minimum to load an image.

Not a huge issue but on bigger screens i.e desktop the larger previews when it goes to 3 columns become blurry. Perhaps another break point?

To fix, see: statamic/cms@b34aa01

In the Statamic 3.2.28 update they changed how they do lazy loading for the Thumbnail.vue component

https://github.com/statamic/cms/pull/4943/files

As a result, the grid of search result thumbnails no longer works for the addon since it is passing the data-src array

This addon is broken since the Statamic-Update from v3.3.32 to v3.3.37.

After selecting an image from the list, the thumbnail is not visible.
Probably this issue has something to do with changes in the assets.scss:

https://github.com/statamic/cms/blob/3.3/resources/sass/components/assets.scss

This is what i see when i try to select an image to use

I see the images request does come back successfully from unsplash API but the preview loading images stay as this forever

My environment:
PHP: 8.0
Laravel: 8.82.0
statamic : 3.2.32
statamic-splash: 1.0.6

When deploying to my server using the below Forge deploy script, the addon tags or fieldtype are not found. I suspect this might be a case sensitivity issue, as the addon works perfectly fine locally.

Here's my deploy script and error below:

cd /home/forge/thedepressionproject.mike-martin.ca
git pull origin master
composer install --no-interaction --prefer-dist --optimize-autoloader

https://flareapp.io/share/x7K3107R

The plugin does not seem to properly implement the Unsplash API Guidelines with regard to triggering downloads. When selecting an image, the plugin should send a request to the download endpoint.

Since no downloads are registered with the Unsplash API we are stuck in Demo mode (max 50 requests/h) and are unable to upgrade to Production mode (max 5000 requests/h)

See point 2 in this general guide:
https://help.unsplash.com/en/articles/2511245-unsplash-api-guidelines

And this page specifically discussing the download endpoint:
https://help.unsplash.com/en/articles/2511258-guideline-triggering-a-download

When your application performs something similar to a download (like when a user chooses the image to include in a blog post, set as a header, etc.), you must send a request to the download endpoint returned under the photo.links.download_location property.

The UI for the search / image picker is a little broken (tested in both Chrome and Firefox):

I can't seem to be able to select an image either, the cursor is a zoom icon?

Doesn't seem to be any console errors, so I can't help much more.

Using Statamic v3 Beta 28

I'm unable to upgrade to v4 because of the requirement in the composer.json file. A new release is needed.

Not sure if I am doing something wrong, but when I am trying to select an image it opens up larger in the background and the previously greyed out select button is hidden. Clicking again gets rid of the image in the background and the buttons return, but the image is unselected, so I cannot click select... with resizing the image the select button comes into view sometimes and I can actually select. Any tips about this, is it a bug? No JS error is triggered. See screenshot below.