as / frame Goto Github PK

• Advancing the cursor manually after each insertion was a bug
• Insert should advance the cursor

remove package level variables and add api functionality for this

See frame\select_test.go TestRegion[0-5]

expected result: [n,m) -> m-n
actual result: [n,m] -> m-n + 1

go test
--- FAIL: TestSelectEndLineAndDec (0.02s)
etch.go:67: delta: TestSelectEndLineAndDec.png
FAIL
exit status 1
FAIL github.com/as/frame 2.500s

The tick's wings don't scale. When large fonts are used, this looks bizarre.

This package should not have any dependency on exp/shiny. This includes drawcache, the cane this package leans on for running efficiently on it.

Impossible to upload current reproduction font to github due to license restrictions. Create or use an open font without these restrictions so regression tests can run and pass from a cloned version of the local git repository.

improve scan and redraw algorithm for this complicated feature

Checklist for upcoming API update.

• Write go-fix for incompatible API changes (frame)
• Write go-fix for incompatible API changes (font)
• Fix UTF8 support
• Add tests for cached and uncached
• Remove shiny references from the API documentation
• Update README.md with instructions for running go-fix
• Update README.md with API changes and package changes
• Merge flusher branch with master
• Round up and close related issues resolved by this change
• #37
• #25
• #21
• #17
• #3
• #2

Kerning is a correlation of letter spacing between certain characters to make type more legible. It is currently not supported or implemented due to the structure of frame/box.Run and frame/box.Box.

Supporting a kerning pair would require a one-box lookbehind during the insertion and deletion into a frame.Frame.

Needed to resolve as/a#101

Under certain conditions a hard-coded constant is used to calculate the 1-D x-max point at the end of the frame. If the actual number of characters in the frame exceeds this limit some rendering operations may be limited to the value of the constant.

This is an issue primarily for extremely long runs of text missing hard newline characters.

as/frame/delete.go:133: pt2 := f.pointOf(65536, pt1, n1)

Tracking issue for missing test coverage in frame/box for elastic tabstops.

as noted here:
https://www.reddit.com/r/golang/comments/75nlam/plan9_libframe_in_go_frame/

it seems frame doesn't explicitly say under which license it is released.
(I suspect BSD-3 but...)

hi,

first of all, great library! thanks a lot.

I have tried the basic example, and I noticed that when resizing the window passed its original size, there were a few display glitches (see attached screenshot).

I am on ArchLinux.

Is it just a glitch b/c basic doesn't do all that a robust app should do?
(TBH, I have also noticed the same behaviour in my own little app that's based on exp/shiny as well)

Issue #34 fixed tick scaling with a side effect of changing what the tick's wings look like. This, in turn, makes some of the graphical tests fail erroneously, as they rely on image comparison to check the test results.