Giter VIP home page Giter VIP logo

redux-subscribe's Issues

Why does the return value of fn get dispatched?

I'm using redux-subscribe with plain redux (no react, no vdux or whatever).

Since I'm a redux beginner, I don't understand this line of your code:

Index: node_modules/redux-subscribe/lib/index.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- node_modules/redux-subscribe/lib/index.js	(revision )
+++ node_modules/redux-subscribe/lib/index.js	(revision )
@@ -85,6 +85,7 @@
 
                 if (prev !== next) {
                   (0, _foreach2.default)(function (fn) {
+                    // Why is the return value of fn dispatched again?
                     return dispatch(fn({ path: path, prev: prev, next: next }));
                   }, subscriptions[path]);
                 }

My call to subscribe looks like this:

store.dispatch(subscribe('feature', 'feature', () => {
	renderFeature();
	return {type: null};
}));

But initially I tried doing:

store.dispatch(subscribe('feature', 'feature', renderFeature));

...which failed as the dispatch function is passed a null and cannot find a property type on it. As a result I return {type: null} from my wrapped render function. Am I doing something wrong?

Possible to hook this up to Redux store?

Hi, I'm trying to use this in a way where I can subscribe directly to my Redux store (I work with state mainly thru store and not props). Is this even possible?

Have been trying for a couple of hours now but not got it working. What I would like to do is in my components:

import * as rsub from 'redux-subscribe'

const local = rsub(store.getState());

local.subscribe('foo', 'bar', localAction);

function localAction(path, prev, next) {
	console.log('check out my new data: ', next);
}

Maintaining, docs etc

Hi @ashaffer. Recently I discovered your package because I need to watch for changes in a piece of Redux store. I've started investigating the package and realized that have the following questions:

  1. Are you going to maintain the package?
  2. Are you going to amend docs and add better example(s)?
  3. What's the reason of using path and key for subscribe function?

Thanks in advance :)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.