"Unparsable" NotImplemementedError when getting values from variables about setup-py-upgrade HOT 8 CLOSED

there's no reason to write a setup py like that, inline it and it'll get converted -- see above

from setup-py-upgrade.

note that in the general case you're asking setup-py-upgrade to solve the halting problem, which is intractable

from setup-py-upgrade.

yeah this is (intentionally) not implemented -- probably needs more of a mention in this section in the README: https://github.com/asottile/setup-py-upgrade#what-is-not-supported

there's currently parsing supported for converting this into file: though so if there's some obvious pattern that can be used then that's a possibility:

with open('filename') as f:
    contents = f.read()

setup(varname=contents)

from setup-py-upgrade.

without seeing the setup.py I don't know what case your particular one falls into

from setup-py-upgrade.

yeah this is (intentionally) not implemented -- probably needs more of a mention in this section in the README: https://github.com/asottile/setup-py-upgrade#what-is-not-supported

I think the most valuable would be a clearer error message (print key and reformatted name and indicate that non-literal values are not supported), it's possible to infer what happens from the traceback but it gives a bit of a pause and it's hardly pretty.

without seeing the setup.py I don't know what case your particular one falls into

Much of the metadata is gotten from an other python file so it would be surprising for things to work in retrospect, I just ran the script to take a look.

from setup-py-upgrade.

I'm not sure what you expected 😆 would you like to submit a PR?

from setup-py-upgrade.

I encountered this error too when I ran setup-py-upgrade on this simple setup.py file:

from setuptools import setup

install_requirements = ['attrs']
setup(
    name='test',
    install_requires=install_requirements
)

Is this possible to fix at all, or is there some inherent limitation of python's ast module that makes it unfixable?

from setup-py-upgrade.

Ok, thanks!

from setup-py-upgrade.